Re: RFR: 8255241: [TestBug] Re-enable few ignored tests in javafx.controls module that pass with latest code [v2]

2020-10-23 Thread Kevin Rushforth
On Thu, 22 Oct 2020 17:48:25 GMT, Ajit Ghaisas wrote: >> Some of the ignored unit tests in javafx.controls module pass with latest >> code. >> This bug is to address - >> - removal of ignored tag >> - fixing the test if fix is minor > > Ajit Ghaisas has updated the pull request incrementally

Re: RFR: 8255241: [TestBug] Re-enable few ignored tests in javafx.controls module that pass with latest code [v2]

2020-10-22 Thread Ajit Ghaisas
On Thu, 22 Oct 2020 15:37:38 GMT, Kevin Rushforth wrote: > It works for me on Windows. Have you run it on more than one platform? I have run it on macOS and Windows. > I left one suggestion for you regarding the constants in TableColumnShim. Thanks for this. That's a cleaner way instead of

Re: RFR: 8255241: [TestBug] Re-enable few ignored tests in javafx.controls module that pass with latest code [v2]

2020-10-22 Thread Ajit Ghaisas
> Some of the ignored unit tests in javafx.controls module pass with latest > code. > This bug is to address - > - removal of ignored tag > - fixing the test if fix is minor Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision: