Re: RFR: 8258499: JavaFX: Move src.zip out of the lib directory

2021-07-01 Thread Eric Bresie
Was reading https://stackoverflow.com/questions/29258944/where-is-the-src-zip-for-jdk8u40 on location on sec.zip and they had in similar layout for JDK and Java-Jax locations. Assume as long as jfx isn’t loaded at the same location as JDK (which since it’s a separate project now) this

Re: RFR: 8258499: JavaFX: Move src.zip out of the lib directory

2021-07-01 Thread Ajit Ghaisas
On Wed, 30 Jun 2021 15:06:50 GMT, Kevin Rushforth wrote: > The JavaFX SDK bundle provides a set of modular jars in the `lib` directory. > It provides a `src.zip` file for use by IDEs in that same `lib` directory. If > a developer adds the `lib` directory to their application's module path in

Re: RFR: 8258499: JavaFX: Move src.zip out of the lib directory

2021-06-30 Thread Johan Vos
On Wed, 30 Jun 2021 15:06:50 GMT, Kevin Rushforth wrote: > The JavaFX SDK bundle provides a set of modular jars in the `lib` directory. > It provides a `src.zip` file for use by IDEs in that same `lib` directory. If > a developer adds the `lib` directory to their application's module path in

Re: RFR: 8258499: JavaFX: Move src.zip out of the lib directory

2021-06-30 Thread Marius Hanl
On Wed, 30 Jun 2021 16:16:16 GMT, Kevin Rushforth wrote: > Thanks for running the test. This is sufficient to show that the changed > layout will work with IntelliJ. > > What happens with the current layout, where src.zip is in the lib dir, if you > add the lib dir? Does IntelliJ fail in the

Re: RFR: 8258499: JavaFX: Move src.zip out of the lib directory

2021-06-30 Thread Marius Hanl
On Wed, 30 Jun 2021 15:06:50 GMT, Kevin Rushforth wrote: > The JavaFX SDK bundle provides a set of modular jars in the `lib` directory. > It provides a `src.zip` file for use by IDEs in that same `lib` directory. If > a developer adds the `lib` directory to their application's module path in

Re: RFR: 8258499: JavaFX: Move src.zip out of the lib directory

2021-06-30 Thread Kevin Rushforth
On Wed, 30 Jun 2021 15:06:50 GMT, Kevin Rushforth wrote: > The JavaFX SDK bundle provides a set of modular jars in the `lib` directory. > It provides a `src.zip` file for use by IDEs in that same `lib` directory. If > a developer adds the `lib` directory to their application's module path in

Re: RFR: 8258499: JavaFX: Move src.zip out of the lib directory

2021-06-30 Thread Marius Hanl
On Wed, 30 Jun 2021 15:06:50 GMT, Kevin Rushforth wrote: > The JavaFX SDK bundle provides a set of modular jars in the `lib` directory. > It provides a `src.zip` file for use by IDEs in that same `lib` directory. If > a developer adds the `lib` directory to their application's module path in

RFR: 8258499: JavaFX: Move src.zip out of the lib directory

2021-06-30 Thread Kevin Rushforth
The JavaFX SDK bundle provides a set of modular jars in the `lib` directory. It provides a `src.zip` file for use by IDEs in that same `lib` directory. If a developer adds the `lib` directory to their application's module path in the IDE, it will try to load `src.zip` as if it were a jar file,