[jfx11u] RFR: 8262276: Debug build of WebKit fails

2021-05-08 Thread Kevin Rushforth
Clean backport to jfx11u. Tested on all three platforms, along with my other in-progress backports, all of which are aggregated in my [`kevinrushforth:test-kcr-11.0.12`](https://github.com/kevinrushforth/jfx11u/commits/test-kcr-11.0.12) branch. - Commit messages: - 8262276: Debug

Re: RFR: 8262276: Debug build of WebKit fails [v3]

2021-04-23 Thread Johan Vos
On Tue, 20 Apr 2021 20:03:28 GMT, Arun Joseph wrote: >> Fixing the Debug build of WebKit. >> >> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test >> using a simple HelloWebView app. > > Arun Joseph has updated the pull request with a new target base due to a > merge

Re: RFR: 8262276: Debug build of WebKit fails [v3]

2021-04-23 Thread Johan Vos
On Tue, 20 Apr 2021 20:03:28 GMT, Arun Joseph wrote: >> Fixing the Debug build of WebKit. >> >> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test >> using a simple HelloWebView app. > > Arun Joseph has updated the pull request with a new target base due to a > merge

Re: RFR: 8262276: Debug build of WebKit fails [v3]

2021-04-20 Thread Kevin Rushforth
On Tue, 20 Apr 2021 20:03:28 GMT, Arun Joseph wrote: >> Fixing the Debug build of WebKit. >> >> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test >> using a simple HelloWebView app. > > Arun Joseph has updated the pull request with a new target base due to a > merge

Re: RFR: 8262276: Debug build of WebKit fails [v3]

2021-04-20 Thread Arun Joseph
> Fixing the Debug build of WebKit. > > Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test > using a simple HelloWebView app. Arun Joseph has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: -

Re: RFR: 8262276: Debug build of WebKit fails [v2]

2021-03-29 Thread Arun Joseph
> Fixing the Debug build of WebKit. > > Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test > using a simple HelloWebView app. Arun Joseph has updated the pull request incrementally with one additional commit since the last revision: Fix InternalFunction crash

Re: RFR: 8262276: Debug build of WebKit fails

2021-03-10 Thread PrimosK
On Tue, 9 Mar 2021 15:46:06 GMT, Arun Joseph wrote: >> I think this is actually a lack of physical memory. I was doing tests inside >> Windows Sandbox which has 4GB of memory by default. >> >> After repeating the build procedure inside VM with 16GB of memory the build >> succeeded. >> >>

Re: RFR: 8262276: Debug build of WebKit fails

2021-03-09 Thread Arun Joseph
On Tue, 9 Mar 2021 14:55:59 GMT, PrimosK wrote: >>> when passing `--info` to gradle, the build succeeds. Without passing >>> `--info` it fails. I'll do more testing later. >> >> Interesting. I don't see this problem. I am able to build with or without >> `--info`. I am also now (with this

Re: RFR: 8262276: Debug build of WebKit fails

2021-03-09 Thread PrimosK
On Tue, 9 Mar 2021 12:41:41 GMT, Kevin Rushforth wrote: >> when passing `--info` to gradle, the build succeeds. Without passing >> `--info` it fails. I'll do more testing later. > >> when passing `--info` to gradle, the build succeeds. Without passing >> `--info` it fails. I'll do more testing

Re: Re: RFR: 8262276: Debug build of WebKit fails

2021-03-09 Thread Eric Bresie
Silly question, when building, at what point would any sort of memory setting be provided? Is that a lack of enough physical memory, not enough memory based on an environment variable or config file? Eric Bresie ebre...@gmail.com (mailto:ebre...@gmail.com) > On March 9, 2021 at 12:42:05 AM

Re: RFR: 8262276: Debug build of WebKit fails

2021-03-09 Thread Kevin Rushforth
On Mon, 8 Mar 2021 15:07:30 GMT, Johan Vos wrote: > when passing `--info` to gradle, the build succeeds. Without passing `--info` > it fails. I'll do more testing later. Interesting. I don't see this problem. I am able to build with or without `--info`. I am also now (with this patch) able to

Re: RFR: 8262276: Debug build of WebKit fails

2021-03-09 Thread Kevin Rushforth
On Tue, 9 Mar 2021 06:30:46 GMT, PrimosK wrote: > Please let me know if I should rather discuss this through another channel > (maybe mailing list?). If you still have problems after resolving your "out of heap space" issue, then asking on the

Re: RFR: 8262276: Debug build of WebKit fails

2021-03-08 Thread PrimosK
On Tue, 9 Mar 2021 06:30:46 GMT, PrimosK wrote: >>> > The build failed again. The only difference I can spot at this time is >>> > the line at which the build failed (it changed from 3445 to 3453): >>> > ... >>> > Please let me know if you need any further information. >>> >>> You might be

Re: RFR: 8262276: Debug build of WebKit fails

2021-03-08 Thread PrimosK
On Mon, 8 Mar 2021 16:20:21 GMT, PrimosK wrote: >> when passing `--info` to gradle, the build succeeds. Without passing >> `--info` it fails. I'll do more testing later. > >> > The build failed again. The only difference I can spot at this time is the >> > line at which the build failed (it

Re: RFR: 8262276: Debug build of WebKit fails

2021-03-08 Thread PrimosK
On Mon, 8 Mar 2021 15:07:30 GMT, Johan Vos wrote: >>> The build failed again. The only difference I can spot at this time is the >>> line at which the build failed (it changed from 3445 to 3453): >>> ... >>> >>> Please let me know if you need any further information. >> >> You might be

Re: RFR: 8262276: Debug build of WebKit fails

2021-03-08 Thread Johan Vos
On Mon, 8 Mar 2021 14:06:02 GMT, Kevin Rushforth wrote: >> Hi dear OpenJdk team, >> >> At first I would like to thank you for looking into this. I am the author of >> original `8262276` ticket. >> >> I would just like to share some additional information with you. I've >> fetched and checked

Re: RFR: 8262276: Debug build of WebKit fails

2021-03-08 Thread Kevin Rushforth
On Mon, 8 Mar 2021 08:16:51 GMT, PrimosK wrote: >> Fixing the Debug build of WebKit. >> >> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test >> using a simple HelloWebView app. > > Hi dear OpenJdk team, > > At first I would like to thank you for looking into this.

Re: RFR: 8262276: Debug build of WebKit fails

2021-03-08 Thread PrimosK
On Thu, 4 Mar 2021 06:41:53 GMT, Arun Joseph wrote: > Fixing the Debug build of WebKit. > > Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test > using a simple HelloWebView app. Hi dear OpenJdk team, At first I would like to thank you for looking into this. I am the

RFR: 8262276: Debug build of WebKit fails

2021-03-04 Thread Arun Joseph
Fixing the Debug build of WebKit. Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test using a simple HelloWebView app. - Commit messages: - 8262276: Debug build of WebKit fails Changes: https://git.openjdk.java.net/jfx/pull/417/files Webrev: