Re: RFR: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc [v2]

2021-06-30 Thread Kevin Rushforth
On Wed, 30 Jun 2021 00:15:26 GMT, Alexander Matveev wrote: >> Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of >> cycle is reached regardless if it is repeating or not. > > Alexander Matveev has updated the pull request incrementally with one > additional commit

Re: RFR: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc [v2]

2021-06-29 Thread Alexander Matveev
On Tue, 29 Jun 2021 22:55:50 GMT, Kevin Rushforth wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc >> [v2] > >

Re: RFR: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc [v2]

2021-06-29 Thread Alexander Matveev
> Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of > cycle is reached regardless if it is repeating or not. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8268683: JavaFX MediaPlayer onEndOfMedia

Re: RFR: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc

2021-06-29 Thread Kevin Rushforth
On Tue, 29 Jun 2021 03:07:11 GMT, Alexander Matveev wrote: > Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of > cycle is reached regardless if it is repeating or not. Looks good with one suggested change.

Re: RFR: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc

2021-06-29 Thread Kevin Rushforth
On Tue, 29 Jun 2021 03:07:11 GMT, Alexander Matveev wrote: > Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of > cycle is reached regardless if it is repeating or not. This looks like a good fix, but should have a CSR, since it changes the specification.

RFR: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc

2021-06-28 Thread Alexander Matveev
Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of cycle is reached regardless if it is repeating or not. - Commit messages: - 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc Changes: