Re: RFR: 8269967: JavaFX should fail fast on macOS below minimum version [v2]

2021-07-13 Thread Ambarish Rapte
On Fri, 9 Jul 2021 13:19:20 GMT, Kevin Rushforth wrote: >> This PR implements a version check in the JavaFX runtime initialization code >> on macOS to ensure that the platform is running a version of macOS that is >> at or above the minimum version. If the platform is below the specified >> mi

Re: RFR: 8269967: JavaFX should fail fast on macOS below minimum version [v2]

2021-07-09 Thread Johan Vos
On Fri, 9 Jul 2021 13:19:20 GMT, Kevin Rushforth wrote: >> This PR implements a version check in the JavaFX runtime initialization code >> on macOS to ensure that the platform is running a version of macOS that is >> at or above the minimum version. If the platform is below the specified >> mi

Re: RFR: 8269967: JavaFX should fail fast on macOS below minimum version [v2]

2021-07-09 Thread Kevin Rushforth
> This PR implements a version check in the JavaFX runtime initialization code > on macOS to ensure that the platform is running a version of macOS that is at > or above the minimum version. If the platform is below the specified minimum, > the JavaFX initialization code throws an exception. >

Re: RFR: 8269967: JavaFX should fail fast on macOS below minimum version

2021-07-09 Thread Kevin Rushforth
On Tue, 6 Jul 2021 23:54:12 GMT, Kevin Rushforth wrote: > This PR implements a version check in the JavaFX runtime initialization code > on macOS to ensure that the platform is running a version of macOS that is at > or above the minimum version. If the platform is below the specified minimum,

Re: RFR: 8269967: JavaFX should fail fast on macOS below minimum version

2021-07-09 Thread Johan Vos
On Tue, 6 Jul 2021 23:54:12 GMT, Kevin Rushforth wrote: > This PR implements a version check in the JavaFX runtime initialization code > on macOS to ensure that the platform is running a version of macOS that is at > or above the minimum version. If the platform is below the specified minimum,

Re: RFR: 8269967: JavaFX should fail fast on macOS below minimum version

2021-07-09 Thread Johan Vos
On Fri, 9 Jul 2021 12:20:53 GMT, Kevin Rushforth wrote: > Alternatively, I could add a new JNI function to check the version, and call > that right after the `loadLibrary`. That might be cleaner than doing it as > part of `initIDs` I think it's ok to keep it in the initIDs, as that is called i

Re: RFR: 8269967: JavaFX should fail fast on macOS below minimum version

2021-07-09 Thread Kevin Rushforth
On Tue, 6 Jul 2021 23:54:12 GMT, Kevin Rushforth wrote: > This PR implements a version check in the JavaFX runtime initialization code > on macOS to ensure that the platform is running a version of macOS that is at > or above the minimum version. If the platform is below the specified minimum,

Re: RFR: 8269967: JavaFX should fail fast on macOS below minimum version

2021-07-09 Thread Kevin Rushforth
On Tue, 6 Jul 2021 23:54:12 GMT, Kevin Rushforth wrote: > This PR implements a version check in the JavaFX runtime initialization code > on macOS to ensure that the platform is running a version of macOS that is at > or above the minimum version. If the platform is below the specified minimum,

Re: RFR: 8269967: JavaFX should fail fast on macOS below minimum version

2021-07-09 Thread Johan Vos
On Tue, 6 Jul 2021 23:54:12 GMT, Kevin Rushforth wrote: > This PR implements a version check in the JavaFX runtime initialization code > on macOS to ensure that the platform is running a version of macOS that is at > or above the minimum version. If the platform is below the specified minimum,

RFR: 8269967: JavaFX should fail fast on macOS below minimum version

2021-07-08 Thread Kevin Rushforth
This PR implements a version check in the JavaFX runtime initialization code on macOS to ensure that the platform is running a version of macOS that is at or above the minimum version. If the platform is below the specified minimum, the JavaFX initialization code throws an exception. The minimu