Re: RFR: 8270838: Remove deprecated protected access members from DateTimeStringConverter

2021-07-17 Thread Nir Lisker
On Sat, 17 Jul 2021 14:17:24 GMT, Kevin Rushforth wrote: > If you prefer, you can remove the now-unneeded annotations as part of > [JDK-8250802](https://bugs.openjdk.java.net/browse/JDK-8250802). That's preferred. - PR: https://git.openjdk.java.net/jfx/pull/578

Re: RFR: 8270838: Remove deprecated protected access members from DateTimeStringConverter

2021-07-17 Thread Kevin Rushforth
On Fri, 16 Jul 2021 17:17:06 GMT, Nir Lisker wrote: > `protected` members were changed to package visibility. I just noticed that there are now a few place where the `@SuppressWarnings("removal")` annotation can be removed. See for example, [DateStringConverter.java#L130](https://github.com/op

Re: RFR: 8270838: Remove deprecated protected access members from DateTimeStringConverter

2021-07-16 Thread Kevin Rushforth
On Fri, 16 Jul 2021 17:17:06 GMT, Nir Lisker wrote: > `protected` members were changed to package visibility. Looks good. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/578

RFR: 8270838: Remove deprecated protected access members from DateTimeStringConverter

2021-07-16 Thread Nir Lisker
`protected` members were changed to package visibility. - Commit messages: - Removes deprecated memebers Changes: https://git.openjdk.java.net/jfx/pull/578/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=578&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-827