Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers [v2]

2021-11-04 Thread Nir Lisker
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote: >> Replacements of more immutable collections. >> >> One thing I found was that the field `idMap` in >> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it >> if that's indeed the case. > > Nir Lisker has updated the

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers [v2]

2021-11-04 Thread Johan Vos
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote: >> Replacements of more immutable collections. >> >> One thing I found was that the field `idMap` in >> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it >> if that's indeed the case. > > Nir Lisker has updated the

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers [v2]

2021-11-04 Thread Johan Vos
On Wed, 27 Oct 2021 15:52:38 GMT, Nir Lisker wrote: > @johanvos Can you comment on `idMap` in > `com.sun.java.scene.web.WebViewHelper.WebView`? That is unused and can safely be deleted. - PR: https://git.openjdk.java.net/jfx/pull/627

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers [v2]

2021-10-27 Thread Nir Lisker
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote: >> Replacements of more immutable collections. >> >> One thing I found was that the field `idMap` in >> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it >> if that's indeed the case. > > Nir Lisker has updated the

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers [v2]

2021-10-27 Thread Ambarish Rapte
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote: >> Replacements of more immutable collections. >> >> One thing I found was that the field `idMap` in >> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it >> if that's indeed the case. > > Nir Lisker has updated the

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers [v2]

2021-10-15 Thread Kevin Rushforth
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote: >> Replacements of more immutable collections. >> >> One thing I found was that the field `idMap` in >> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it >> if that's indeed the case. > > Nir Lisker has updated the

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers [v2]

2021-10-15 Thread Kevin Rushforth
On Fri, 15 Oct 2021 16:23:10 GMT, Kevin Rushforth wrote: > > Do you want to do something about `idMap` in > > `com.sun.java.scene.web.WebViewHelper.WebView` that I pointed out in the PR? > > I missed that comment. Where do you see this field? I can't find it anywhere. Oh, I see it now. It's

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers [v2]

2021-10-15 Thread Kevin Rushforth
On Fri, 15 Oct 2021 15:04:00 GMT, Nir Lisker wrote: > Do you want to do something about `idMap` in > `com.sun.java.scene.web.WebViewHelper.WebView` that I pointed out in the PR? I missed that comment. Where do you see this field? I can't find it anywhere. - PR:

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers [v2]

2021-10-15 Thread Nir Lisker
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote: >> Replacements of more immutable collections. >> >> One thing I found was that the field `idMap` in >> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it >> if that's indeed the case. > > Nir Lisker has updated the

Re: RFR: 8272808: Update constant collections to use the new immutable collections - leftovers [v2]

2021-10-15 Thread Nir Lisker
> Replacements of more immutable collections. > > One thing I found was that the field `idMap` in > `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it > if that's indeed the case. Nir Lisker has updated the pull request incrementally with one additional commit since