Re: RFR: 8274699: Certain blend modes cannot be set from CSS [v2]

2021-10-29 Thread Kevin Rushforth
On Fri, 29 Oct 2021 15:37:36 GMT, Marius Hanl wrote: > > Looks good, although the solution in itself remains fishy. Maybe create a > > ticket to implement a better solution in the future? > > yes, the css code is sometimes very ... interesting. I have not looked > closely but it's weird that t

Re: RFR: 8274699: Certain blend modes cannot be set from CSS [v2]

2021-10-29 Thread Marius Hanl
On Fri, 29 Oct 2021 14:34:39 GMT, Michael Strauß wrote: > Looks good, although the solution in itself remains fishy. Maybe create a > ticket to implement a better solution in the future? yes, the css code is sometimes very ... interesting. I didn't had a deep look but it's weird that there are

Re: RFR: 8274699: Certain blend modes cannot be set from CSS [v2]

2021-10-29 Thread Michael Strauß
On Thu, 14 Oct 2021 21:47:16 GMT, Marius Hanl wrote: >> This PR fixes a bug where the blend mode will be falsely recognized as a >> color and therefore won't be set. >> Also a ClassCastException is thrown (The converter expects a String, but >> gets a Color). >> >> Note: There is another simi

Re: RFR: 8274699: Certain blend modes cannot be set from CSS [v2]

2021-10-14 Thread Kevin Rushforth
On Thu, 14 Oct 2021 21:47:16 GMT, Marius Hanl wrote: >> This PR fixes a bug where the blend mode will be falsely recognized as a >> color and therefore won't be set. >> Also a ClassCastException is thrown (The converter expects a String, but >> gets a Color). >> >> Note: There is another simi

Re: RFR: 8274699: Certain blend modes cannot be set from CSS [v2]

2021-10-14 Thread Marius Hanl
> This PR fixes a bug where the blend mode will be falsely recognized as a > color and therefore won't be set. > Also a ClassCastException is thrown (The converter expects a String, but gets > a Color). > > Note: There is another similar bug but I can't reproduce it (Tried with > 18-ea+3). > h

Re: RFR: 8274699: Certain blend modes cannot be set from CSS

2021-10-14 Thread Marius Hanl
On Thu, 14 Oct 2021 17:45:40 GMT, Kevin Rushforth wrote: >> This PR fixes a bug where the blend mode will be falsely recognized as a >> color and therefore won't be set. >> Also a ClassCastException is thrown (The converter expects a String, but >> gets a Color). >> >> Note: There is another

Re: RFR: 8274699: Certain blend modes cannot be set from CSS

2021-10-14 Thread Kevin Rushforth
On Wed, 6 Oct 2021 07:43:15 GMT, Marius Hanl wrote: > This PR fixes a bug where the blend mode will be falsely recognized as a > color and therefore won't be set. > Also a ClassCastException is thrown (The converter expects a String, but gets > a Color). > > Note: There is another similar bug

RFR: 8274699: Certain blend modes cannot be set from CSS

2021-10-06 Thread Marius Hanl
This PR fixes a bug where the blend mode will be falsely recognized as a color and therefore won't be set. Also a ClassCastException is thrown (The converter expects a String, but gets a Color). Note: There is another similar bug but I can't reproduce this (Tried on 18-ea+3). https://bugs.open