On Wed, 30 Mar 2022 10:57:48 GMT, Robert Lichtenberger
wrote:
>> findSibling adapted to only use visible menus when calculating the
>> index.
>
> Robert Lichtenberger has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8251480: TableColumnHead
> findSibling adapted to only use visible menus when calculating the
> index.
Robert Lichtenberger has updated the pull request incrementally with one
additional commit since the last revision:
8251480: TableColumnHeader: calc of cell width must respect row styling
Comment improved.
On Wed, 30 Mar 2022 04:48:30 GMT, Ajit Ghaisas wrote:
>
> Only one minor correction needed is in comment.
Right. Just pushed a correction.
-
PR: https://git.openjdk.java.net/jfx/pull/759
On Tue, 29 Mar 2022 12:11:54 GMT, Robert Lichtenberger
wrote:
> > Have you considered keeping the same while loop in findSibling() method and
> > skipping invisible Menus in it? This is to avoid creating and traversing a
> > new list.
>
> This would not give the correct result. findSibling mu
On Tue, 29 Mar 2022 09:23:24 GMT, Ajit Ghaisas wrote:
> Have you considered keeping the same while loop in findSibling() method and
> skipping invisible Menus in it? This is to avoid creating and traversing a
> new list.
This would not give the correct result. findSibling must return the index
On Tue, 22 Mar 2022 14:42:07 GMT, Robert Lichtenberger
wrote:
> findSibling adapted to only use visible menus when calculating the
> index.
Have you considered keeping the same while loop in findSibling() method and
skipping invisible Menus in it?
This is to avoid creating and traversing a new
findSibling adapted to only use visible menus when calculating the
index.
-
Commit messages:
- 8283509: Invisible menus can lead to IndexOutOfBoundsException
Changes: https://git.openjdk.java.net/jfx/pull/759/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=759&range=00
