Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-26 Thread Tomator
On Fri, 13 May 2022 05:34:08 GMT, Tomator wrote: > When I used BlueJ, I found a problem with Chinese display. > /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode > may return a negative number when no font library is specified in Linux,and > this could cause

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread yosbits
On Fri, 13 May 2022 05:34:08 GMT, Tomator wrote: > When I used BlueJ, I found a problem with Chinese display. > /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode > may return a negative number when no font library is specified in Linux,and > this could cause

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Kevin Rushforth
On Tue, 17 May 2022 13:08:10 GMT, Tomator wrote: > Hello,i have signed oca ,and pull /signed command ,so I'm just wait for OCA > to pass? Yes, at this point you wait for your OCA to be processed. - PR: https://git.openjdk.java.net/jfx/pull/795

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Tomator
On Tue, 17 May 2022 13:34:47 GMT, yosbits wrote: > Reading the author's description of this PR, one wonders why the added > condition is not "glyphCode < 0". > > ```java > if (glyphCode <= 0) {return null;} > ``` Your suggestion is right - PR:

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Kevin Rushforth
On Fri, 13 May 2022 12:21:32 GMT, Kevin Rushforth wrote: > * Submit a bug report with a test case at > [bugreport.java.com](https://bugreport.java.com/) I see that you already have submitted a bug report. You should get an email when it is made public. - PR:

RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Tomator
When I used BlueJ, I found a problem with Chinese display. /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode may return a negative number when no font library is specified in Linux,and this could cause java.lang.ArrayIndexOutOfBoundsException error.So

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Kevin Rushforth
On Fri, 13 May 2022 05:36:03 GMT, Tomator wrote: >> When I used BlueJ, I found a problem with Chinese display. >> /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode >> may return a negative number when no font library is specified in Linux,and >> this could cause

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Tomator
On Mon, 16 May 2022 08:12:54 GMT, Tomator wrote: >> When I used BlueJ, I found a problem with Chinese display. >> /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode >> may return a negative number when no font library is specified in Linux,and >> this could cause

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Tomator
On Fri, 13 May 2022 05:34:08 GMT, Tomator wrote: > When I used BlueJ, I found a problem with Chinese display. > /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode > may return a negative number when no font library is specified in Linux,and > this could cause