Re: Fixing NetBeans Gradle Support for OpenJFX

2020-07-24 Thread Kevin Rushforth
For developer builds, the full version includes the time stamp. This is reflected in the "javafx.runtime.version" system property. For release builds, the time stamp is replaced with the build number. We've never included a time stamp anywhere else, and I don't see much need to add one without

Re: Fixing NetBeans Gradle Support for OpenJFX

2020-07-24 Thread Eric Bresie
Would a inclusion of timestamp within generated META-INF\MANIFEST.MF allow some 'timestamp" without impacting the generated jar name also be worth considering? Eric Bresie ebre...@gmail.com On Thu, Jul 23, 2020 at 12:42 PM Kevin Rushforth wrote: > In that case, we can probably remove the time

Re: Fixing NetBeans Gradle Support for OpenJFX

2020-07-23 Thread Kevin Rushforth
The proposed fix will be to disable the maven publishing tasks by default, and to not set the project.version at all. So this will decouple the maven publishing tasks, and they won't interfere with normal developer or production builds. Joeri or Johan can confirm, but if they ever do upload a

Re: Re: Fixing NetBeans Gradle Support for OpenJFX

2020-07-23 Thread Eric Bresie
Is there a need for some further cleanup dependency between builds maybe to remove duplicate jars / modules with different time stamps? Rather than time stamp in these cases should it just use a SNAPSHOT designation instead? Eric Bresie ebre...@gmail.com > On July 20, 2020 at 5:42:30 PM CDT, Ke

Re: Fixing NetBeans Gradle Support for OpenJFX

2020-07-20 Thread Kevin Rushforth
I filed https://bugs.openjdk.java.net/browse/JDK-8249777 to track fixing the build.gradle to not include the time stamp, at least by default. -- Kevin On 7/20/2020 3:16 PM, Kevin Rushforth wrote: On 7/20/2020 2:05 PM, Laszlo Kishalmi wrote: On 7/20/20 1:15 PM, Kevin Rushforth wrote:    Tha

Re: Fixing NetBeans Gradle Support for OpenJFX

2020-07-20 Thread Kevin Rushforth
On 7/20/2020 2:05 PM, Laszlo Kishalmi wrote: On 7/20/20 1:15 PM, Kevin Rushforth wrote:    That could be prevented by removing line 1547: project.version =    MAVEN_VERSION from the build script. Interesting. That is only used for the maven "publishing" tasks, and shouldn't affect the main

Re: Fixing NetBeans Gradle Support for OpenJFX

2020-07-20 Thread Laszlo Kishalmi
On 7/20/20 1:15 PM, Kevin Rushforth wrote: Hi Laszlo, Thanks for reaching out to us. Neil Smith suggested that I report this on netbeans-dev, which I haven't done yet, but can do today if you still need me to. To answer some of your specific questions: 1. For some reason version calculat

Re: Fixing NetBeans Gradle Support for OpenJFX

2020-07-20 Thread Kevin Rushforth
Hi Laszlo, Thanks for reaching out to us. Neil Smith suggested that I report this on netbeans-dev, which I haven't done yet, but can do today if you still need me to. To answer some of your specific questions: 1. For some reason version calculation is built in the script adding a    second