On Tue, 27 Jul 2021 12:36:52 GMT, Marius Hanl wrote:
> But I'm wondering, this might require more as we don't set this dirty flag
> anymore as soon as we install a selection model again.
> But thinking about this even more, this would be a general problem as soon as
> we switch the combobox
On Tue, 27 Jul 2021 09:55:47 GMT, Jeanette Winzenburg
wrote:
> ComboBox comboBox = new ComboBox<>(items);
> comboBox.setSelectionModel(null);
> installDefaultSkin(comboBox);
Ahh yes, I see, nice catch. I will fix it and update this PR.
But I'm wondering, this might require more as we
On Thu, 22 Jul 2021 19:49:44 GMT, Marius Hanl wrote:
>> This PR fixes multiple NPEs in Choice-and ComboBox, when the selection model
>> is null.
>>
>> ChoiceBox:
>> - Null check in **valueProperty()** listener
>>
>> ComboBox:
>> - Null check in **editableProperty()** listener
>> - Null check
> This PR fixes multiple NPEs in Choice-and ComboBox, when the selection model
> is null.
>
> ChoiceBox:
> - Null check in **valueProperty()** listener
>
> ComboBox:
> - Null check in **editableProperty()* listener*
> - Null check in **valueProperty()** listener
> - Null check in
