Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened [v2]

2020-12-13 Thread Johan Vos
On Sun, 13 Dec 2020 16:21:52 GMT, Johan Vos wrote: >> John Neffenger has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits

Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened [v2]

2020-12-13 Thread Johan Vos
On Fri, 25 Sep 2020 22:21:36 GMT, John Neffenger wrote: >> Fixes [JDK-8201568](https://bugs.openjdk.java.net/browse/JDK-8201568). > > John Neffenger has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes >

Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened [v2]

2020-12-11 Thread John Neffenger
On Tue, 29 Sep 2020 19:47:54 GMT, John Neffenger wrote: >> I don't have access to a Pi right now, so I can't test this (I'll be able to >> test in about 10 days from now though) > > @johanvos, would you mind approving this pull request again? It looks as if > the *ready* label was removed

Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened [v2]

2020-09-29 Thread John Neffenger
On Mon, 21 Sep 2020 18:34:29 GMT, John Neffenger wrote: >> Based on my notes below, I believe this change is safe for any Linux input >> device driver because the driver shouldn't >> receive the intermediate *open* and *close* calls at all. >> Nonetheless, it would be reassuring if someone

Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened [v2]

2020-09-25 Thread John Neffenger
> Fixes [JDK-8201568](https://bugs.openjdk.java.net/browse/JDK-8201568). John Neffenger has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional

Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened

2020-09-21 Thread John Neffenger
On Mon, 29 Jun 2020 18:49:33 GMT, John Neffenger wrote: > Nonetheless, it would be reassuring if someone could try [this > change](https://github.com/openjdk/jfx/pull/258/files) > just once on a mainstream device, such as the Raspberry Pi with a touchscreen > LCD panel. I just placed an

Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened

2020-07-27 Thread torbuntu
On Mon, 27 Jul 2020 16:05:02 GMT, John Neffenger wrote: >>> By the way, do you know whether I would be able to use a PinePhone >> >> I have been trying to run JavaFX on the PinePhone ever since I got it. The >> OS I'm using is Fedora and it is aarch64, >> which means I had to add that arch to

Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened

2020-07-27 Thread John Neffenger
On Mon, 27 Jul 2020 14:26:44 GMT, Tor (torbuntu) wrote: > Is there somewhere I can find an embedded aarch64 version? If I had a PinePhone, I would try to get the 32-bit *armhf* build of JavaFX working. That's the one you build with `gradle -PCOMPILE_TARGETS=armv6hf sdk jmod`. You may need to

Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened

2020-07-27 Thread torbuntu
On Thu, 9 Jul 2020 22:35:01 GMT, John Neffenger wrote: > By the way, do you know whether I would be able to use a PinePhone I have been trying to run JavaFX on the PinePhone ever since I got it. The OS I'm using is Fedora and it is aarch64, which means I had to add that arch to build.gradle to

Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened

2020-07-09 Thread John Neffenger
On Wed, 1 Jul 2020 12:10:23 GMT, Johan Vos wrote: > I don't have access to a Pi right now, so I can't test this (I'll be able to > test in about 10 days from now though) Thank you, Johan. If you have the time, that would be great. Otherwise, merging this for early-access builds of JavaFX 16

Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened

2020-07-01 Thread Johan Vos
On Mon, 29 Jun 2020 18:49:33 GMT, John Neffenger wrote: >> The rationale makes sense (open/open/close) instead of (open/close/open) > > Based on my notes below, I believe this change is safe for any Linux input > device driver because the driver shouldn't > receive the intermediate *open* and

Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened

2020-06-29 Thread John Neffenger
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Mon, 29 Jun 2020 11:26:50 GMT, Johan Vos wrote:

Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened

2020-06-29 Thread Johan Vos
On Sat, 27 Jun 2020 00:21:06 GMT, John Neffenger wrote: > Fixes [JDK-8201568](https://bugs.openjdk.java.net/browse/JDK-8201568). The rationale makes sense (open/open/close) instead of (open/close/open) - Marked as reviewed by jvos (Reviewer). PR:

Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened

2020-06-26 Thread John Neffenger
On Sat, 27 Jun 2020 00:21:06 GMT, John Neffenger wrote: > Fixes [JDK-8201568](https://bugs.openjdk.java.net/browse/JDK-8201568). I thought I could avoid fixing this bug simply by waiting a few years, but the old devices from 2012 and 2013 where the problem occurs are still supported and still