Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT [v5]

2021-10-01 Thread Ambarish Rapte
On Thu, 30 Sep 2021 13:24:26 GMT, Michael Paus wrote: >> Fixes the issue by using the "open" command as discussed before. >> See: https://bugs.openjdk.java.net/browse/JDK-8214158 > > Michael Paus has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT [v5]

2021-09-30 Thread Kevin Rushforth
On Thu, 30 Sep 2021 13:24:26 GMT, Michael Paus wrote: >> Fixes the issue by using the "open" command as discussed before. >> See: https://bugs.openjdk.java.net/browse/JDK-8214158 > > Michael Paus has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT [v5]

2021-09-30 Thread Michael Paus
> Fixes the issue by using the "open" command as discussed before. > See: https://bugs.openjdk.java.net/browse/JDK-8214158 Michael Paus has updated the pull request incrementally with one additional commit since the last revision: Fixed two minor formatting issues - Changes: -

Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT [v4]

2021-09-30 Thread Kevin Rushforth
On Wed, 29 Sep 2021 13:20:08 GMT, Michael Paus wrote: >> Fixes the issue by using the "open" command as discussed before. >> See: https://bugs.openjdk.java.net/browse/JDK-8214158 > > Michael Paus has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT [v4]

2021-09-29 Thread Michael Paus
> Fixes the issue by using the "open" command as discussed before. > See: https://bugs.openjdk.java.net/browse/JDK-8214158 Michael Paus has updated the pull request incrementally with one additional commit since the last revision: Move test to subfolder HostServices - Changes:

Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT [v3]

2021-09-29 Thread Michael Paus
> Fixes the issue by using the "open" command as discussed before. > See: https://bugs.openjdk.java.net/browse/JDK-8214158 Michael Paus has updated the pull request incrementally with one additional commit since the last revision: Fix whitespace errors - Changes: - all: https:/

Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT [v2]

2021-09-29 Thread Michael Paus
> Fixes the issue by using the "open" command as discussed before. > See: https://bugs.openjdk.java.net/browse/JDK-8214158 Michael Paus has updated the pull request incrementally with one additional commit since the last revision: Add test - Changes: - all: https://git.openjdk.

Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT

2021-09-29 Thread Kevin Rushforth
On Tue, 28 Sep 2021 17:19:38 GMT, Michael Paus wrote: > First of all. Shall I follow the bot request above and create a new pull > request? Wouldn't we loose the discussion here then? As long as you don't otherwise need to update your `master` branch, you can wait to reset it until after this

Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT

2021-09-28 Thread Michael Paus
On Tue, 28 Sep 2021 16:06:30 GMT, Michael Paus wrote: > Fixes the issue by using the "open" command as discussed before. > See: https://bugs.openjdk.java.net/browse/JDK-8214158 To answer your questions: 1. I have no idea about LSOpenURLsWithRole. I am not a Mac developer. 2. I have manually test

Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT

2021-09-28 Thread Michael Paus
On Tue, 28 Sep 2021 16:06:30 GMT, Michael Paus wrote: > Fixes the issue by using the "open" command as discussed before. > See: https://bugs.openjdk.java.net/browse/JDK-8214158 First of all. Shall I follow the bot request above and create a new pull request? Wouldn't we loose the discussion her

Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT

2021-09-28 Thread Kevin Rushforth
On Tue, 28 Sep 2021 16:06:30 GMT, Michael Paus wrote: > Fixes the issue by using the "open" command as discussed before. > See: https://bugs.openjdk.java.net/browse/JDK-8214158 This seems like a good RFE. I have a couple overall questions. First, calling `open` was originally proposed in the si