On Fri, 13 Dec 2019 10:48:37 GMT, Ambarish Rapte wrote:
>>> This is moved only to make first operation when disposing. However the race
>>> condition is very rare, but this will just reduce the chances little more.
>>
>> Can you elaborate? Why would there still be a race condition?
>
>> Can yo
On Tue, 10 Dec 2019 07:00:50 GMT, Ambarish Rapte wrote:
> Issue: NPE in GlassScene.frameRendered().
>
> Cause: scenePaintListener is set in setTKScenePaintListener(), used in
> frameRendered() and
> set to null in dispose().
> setTKScenePaintListener() and dispose() are called on JavaFX Applic
On Thu, 12 Dec 2019 23:29:11 GMT, Kevin Rushforth wrote:
>>> 1. In addition to calling the synchronized `setTKScenePaintListener`
>>> method, you moved the call to the beginning of `dispose`. Is there a reason
>>> you needed to do this?
>>
>> This is moved only to make first operation when
On Wed, 11 Dec 2019 17:10:37 GMT, Ambarish Rapte wrote:
>> The change looks OK as far as it goes, meaning that it will fix the specific
>> NPE reported by the bug and is looks like a safe fix.
>>
>> Two questions:
>>
>> 1. In addition to calling the synchronized `setTKScenePaintListener` metho
On Tue, 10 Dec 2019 16:27:10 GMT, Kevin Rushforth wrote:
>> Issue: NPE in GlassScene.frameRendered().
>>
>> Cause: scenePaintListener is set in setTKScenePaintListener(), used in
>> frameRendered() and
>> set to null in dispose().
>> setTKScenePaintListener() and dispose() are called on JavaFX
On Tue, 10 Dec 2019 07:00:50 GMT, Ambarish Rapte wrote:
> Issue: NPE in GlassScene.frameRendered().
>
> Cause: scenePaintListener is set in setTKScenePaintListener(), used in
> frameRendered() and
> set to null in dispose().
> setTKScenePaintListener() and dispose() are called on JavaFX Applic
