Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-28 Thread Phil Race
On Fri, 25 Jun 2021 04:08:30 GMT, Prasanta Sadhukhan wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8223717: javafx printing: Support Specifying Print to File in the API > > modules/javafx.graphics/src/main/java/com

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-28 Thread Phil Race
On Fri, 25 Jun 2021 21:13:31 GMT, Kevin Rushforth wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8223717: javafx printing: Support Specifying Print to File in the API > > modules/javafx.graphics/src/main/java/javafx/

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-28 Thread Phil Race
On Fri, 25 Jun 2021 21:20:53 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/java/com/sun/prism/j2d/print/J2DPrinterJob.java >> line 839: >> >>> 837: security.checkPrintJobAccess(); >>> 838: String file = settings.getOutputFile(); >>> 839: if

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-28 Thread Philip Race
Yes .. we still need to deal with it until it is actually removed. Its going to be here for all the life of JDK 17 LTS which I expect FX will want to support for all that time. -phil. On 6/25/21 6:42 PM, Eric Bresie wrote: security manager That’s not the same security manager being discussed

Re: Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-25 Thread Eric Bresie
> security manager That’s not the same security manager being discussed as being deprecated for Java 17 and beyond is it? Eric Bresie ebre...@gmail.com (mailto:ebre...@gmail.com) > On June 25, 2021 at 4:20:03 PM CDT, Kevin Rushforth (mailto:k...@openjdk.java.net)> wrote: > On Thu, 24 Jun 2021

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-25 Thread Kevin Rushforth
On Thu, 24 Jun 2021 23:00:42 GMT, Phil Race wrote: >> This enhancement adds the String property outputFileProperty() to the >> JobSettings class. >> The value should be a string that references a local file encoded as a URL. >> If this is non-null and set to a location that the user has permissi

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-25 Thread Kevin Rushforth
On Fri, 25 Jun 2021 03:44:56 GMT, Prasanta Sadhukhan wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8223717: javafx printing: Support Specifying Print to File in the API > > modules/javafx.graphics/src/main/java/com

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-25 Thread Kevin Rushforth
On Fri, 25 Jun 2021 07:18:50 GMT, Johan Vos wrote: >> Consistency with other APIs would be the main reason. We could do something >> similar to what we do for `Image`, and treat a string without a protocol as >> a file (although not relative to the classpath as in the case of images), >> turni

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-25 Thread Kevin Rushforth
On Thu, 24 Jun 2021 23:00:42 GMT, Phil Race wrote: >> This enhancement adds the String property outputFileProperty() to the >> JobSettings class. >> The value should be a string that references a local file encoded as a URL. >> If this is non-null and set to a location that the user has permissi

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-25 Thread Prasanta Sadhukhan
On Thu, 24 Jun 2021 23:00:42 GMT, Phil Race wrote: >> This enhancement adds the String property outputFileProperty() to the >> JobSettings class. >> The value should be a string that references a local file encoded as a URL. >> If this is non-null and set to a location that the user has permissi

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-25 Thread Johan Vos
On Thu, 24 Jun 2021 23:19:22 GMT, Kevin Rushforth wrote: >> We aren't ignoring it .. its just handed on, so its going to be the same as >> the other non-writable case .. file could not be created .. printing error >> .. >> we could do some up-front validation if that seems like the way we want

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-24 Thread Kevin Rushforth
On Thu, 24 Jun 2021 23:03:29 GMT, Phil Race wrote: >> As a potential user of this API I have to ask, why would this be a URL >> instead of a File or Path ? Particularly if only "file:" URLs will be >> valid. I can't think of a scenario where it won't always be an extra >> inconvenience to co

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-24 Thread Phil Race
On Thu, 24 Jun 2021 23:19:22 GMT, Kevin Rushforth wrote: >> We aren't ignoring it .. its just handed on, so its going to be the same as >> the other non-writable case .. file could not be created .. printing error >> .. >> we could do some up-front validation if that seems like the way we want

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-24 Thread Phil Race
On Thu, 24 Jun 2021 22:53:57 GMT, Scott Palmer wrote: >> modules/javafx.graphics/src/main/java/javafx/print/JobSettings.java line 474: >> >>> 472: * encoded name of a filesystem file, to which the platform printer >>> 473: * driver should spool the rendered print data. >>> 474: *

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-24 Thread Phil Race
> This enhancement adds the String property outputFileProperty() to the > JobSettings class. > The value should be a string that references a local file encoded as a URL. > If this is non-null and set to a location that the user has permission to > write to, > then the printer output will be spoo

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-24 Thread Phil Race
On Thu, 24 Jun 2021 22:38:40 GMT, Kevin Rushforth wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8223717: javafx printing: Support Specifying Print to File in the API > > modules/javafx.graphics/src/main/java/javafx/

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-24 Thread Scott Palmer
On Thu, 24 Jun 2021 22:25:53 GMT, Kevin Rushforth wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8223717: javafx printing: Support Specifying Print to File in the API > > modules/javafx.graphics/src/main/java/javafx/