Re: RFR: 8238755: allow to create static lib for javafx.media on linux

2020-02-11 Thread Johan Vos
On Tue, 11 Feb 2020 22:23:41 GMT, Alexander Matveev wrote: >> As an alternative, the "iPod" strategy can be used. >> For some reasons, the "ipod-library" protocol is supported in the code >> (Locator), and if that is found, most connection code is bypassed. >> That strategy seems to be much mor

Re: RFR: 8238755: allow to create static lib for javafx.media on linux

2020-02-11 Thread Alexander Matveev
On Tue, 11 Feb 2020 10:59:32 GMT, Johan Vos wrote: >> I added a comment about using an ifdef for `GSTREAMER_LITE` in one of the >> modified files (the others are fine, since those files are entirely >> FX_specific). >> >> One other question: do you need any changes in >> [ConnectionHolder.jav

Re: RFR: 8238755: allow to create static lib for javafx.media on linux

2020-02-11 Thread Alexander Matveev
On Tue, 11 Feb 2020 09:59:10 GMT, Johan Vos wrote: >> modules/javafx.media/src/main/java/com/sun/media/jfxmediaimpl/platform/gstreamer/GSTPlatform.java >> line 66: >> >>> 65: "jrt", >>> 66: "resource" >>> 67: }; >> >> We do not support "resource" protocol in non-static buil

Re: RFR: 8238755: allow to create static lib for javafx.media on linux

2020-02-11 Thread Johan Vos
On Mon, 10 Feb 2020 20:57:30 GMT, Kevin Rushforth wrote: >> * add support for the "resource" protocol (which is used in the GraalVM URLs >> pointing to statically bundled resources) >> * avoid duplicate symbols with different gst plugins >> * statically register gst plugins > > I added a commen

Re: RFR: 8238755: allow to create static lib for javafx.media on linux

2020-02-11 Thread Johan Vos
On Mon, 10 Feb 2020 20:47:01 GMT, Kevin Rushforth wrote: >> * add support for the "resource" protocol (which is used in the GraalVM URLs >> pointing to statically bundled resources) >> * avoid duplicate symbols with different gst plugins >> * statically register gst plugins > > modules/javafx.m

Re: RFR: 8238755: allow to create static lib for javafx.media on linux

2020-02-11 Thread Johan Vos
On Mon, 10 Feb 2020 22:06:40 GMT, Alexander Matveev wrote: >> * add support for the "resource" protocol (which is used in the GraalVM URLs >> pointing to statically bundled resources) >> * avoid duplicate symbols with different gst plugins >> * statically register gst plugins > > modules/javaf

Re: RFR: 8238755: allow to create static lib for javafx.media on linux

2020-02-10 Thread Alexander Matveev
On Mon, 10 Feb 2020 12:26:53 GMT, Johan Vos wrote: > * add support for the "resource" protocol (which is used in the GraalVM URLs > pointing to statically bundled resources) > * avoid duplicate symbols with different gst plugins > * statically register gst plugins modules/javafx.media/src/main/

Re: RFR: 8238755: allow to create static lib for javafx.media on linux

2020-02-10 Thread Kevin Rushforth
On Mon, 10 Feb 2020 12:26:53 GMT, Johan Vos wrote: > * add support for the "resource" protocol (which is used in the GraalVM URLs > pointing to statically bundled resources) > * avoid duplicate symbols with different gst plugins > * statically register gst plugins I added a comment about using

Re: RFR: 8238755: allow to create static lib for javafx.media on linux

2020-02-10 Thread Kevin Rushforth
On Mon, 10 Feb 2020 12:26:53 GMT, Johan Vos wrote: > * add support for the "resource" protocol (which is used in the GraalVM URLs > pointing to statically bundled resources) > * avoid duplicate symbols with different gst plugins > * statically register gst plugins I'll review this and also ask