Re: Re: RFR: 8240688: Remove the JavaBeanXxxPropertyBuilders constructors

2020-03-23 Thread Eric Bresie
Is there any external skara documentation available on all these flags etc? Eric Bresie ebre...@gmail.com > On March 7, 2020 at 8:25:02 AM CST, Kevin Rushforth > wrote: > On Fri, 6 Mar 2020 20:46:39 GMT, Kevin Rushforth wrote: > > > > Marked as reviewed by kcr (Lead). > > > > @arapte can you

Re: RFR: 8240688: Remove the JavaBeanXxxPropertyBuilders constructors

2020-03-09 Thread Ambarish Rapte
On Fri, 6 Mar 2020 17:51:08 GMT, Nir Lisker wrote: > Followup to the deprecation of the JavaBeanXxxPropertyBuilders constructors. > > [CSR](https://bugs.openjdk.java.net/browse/JDK-8240689) Looks good to me. Observed no build errors for apps, tests. - Marked as reviewed by arapte

Re: RFR: 8240688: Remove the JavaBeanXxxPropertyBuilders constructors

2020-03-07 Thread Kevin Rushforth
On Fri, 6 Mar 2020 20:46:39 GMT, Kevin Rushforth wrote: >> Marked as reviewed by kcr (Lead). > > @arapte can you also review this? Now the the CSR is approved, we need something to "wake up" the Skara bot to notice that. @edvbld @rwestberg is there a command that you would recommend to do

Re: RFR: 8240688: Remove the JavaBeanXxxPropertyBuilders constructors

2020-03-06 Thread Kevin Rushforth
On Fri, 6 Mar 2020 17:51:08 GMT, Nir Lisker wrote: > Followup to the deprecation of the JavaBeanXxxPropertyBuilders constructors. > > [CSR](https://bugs.openjdk.java.net/browse/JDK-8240689) Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/140

Re: RFR: 8240688: Remove the JavaBeanXxxPropertyBuilders constructors

2020-03-06 Thread Kevin Rushforth
On Fri, 6 Mar 2020 20:45:23 GMT, Kevin Rushforth wrote: >> Followup to the deprecation of the JavaBeanXxxPropertyBuilders constructors. >> >> [CSR](https://bugs.openjdk.java.net/browse/JDK-8240689) > > Marked as reviewed by kcr (Lead). @arapte can you also review this? - PR:

Re: RFR: 8240688: Remove the JavaBeanXxxPropertyBuilders constructors

2020-03-06 Thread Kevin Rushforth
On Fri, 6 Mar 2020 18:22:24 GMT, Nir Lisker wrote: >> Followup to the deprecation of the JavaBeanXxxPropertyBuilders constructors. >> >> [CSR](https://bugs.openjdk.java.net/browse/JDK-8240689) > > Why was the rfr label not reinstated? @edvbld @rwestberg This is affected by

Re: RFR: 8240688: Remove the JavaBeanXxxPropertyBuilders constructors

2020-03-06 Thread Nir Lisker
On Fri, 6 Mar 2020 17:51:08 GMT, Nir Lisker wrote: > Followup to the deprecation of the JavaBeanXxxPropertyBuilders constructors. > > [CSR](https://bugs.openjdk.java.net/browse/JDK-8240689) Why was the rfr label not reinstated? - PR: https://git.openjdk.java.net/jfx/pull/140