On Mon, 29 Jun 2020 11:33:24 GMT, Johan Vos wrote:
>> I think the code in the `_stop` method is correct after all.
>>
>> The `MonocleTimer` class is written to allow for multiple calls to the pair
>> of `_start` and `_stop` methods (even
>> though I don't think that ever happens), and the
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Sun, 28 Jun 2020 01:56:26 GMT, John Neffenger
> Fixes [JDK-8248381](https://bugs.openjdk.java.net/browse/JDK-8248381).
John Neffenger has updated the pull request incrementally with one additional
commit since the last revision:
Remove POOL_SIZE constant
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/256/files
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Sat, 27 Jun 2020 19:40:53 GMT, John Neffenger
On Sat, 27 Jun 2020 19:37:01 GMT, Kevin Rushforth wrote:
> OK, that seems fine then. I'll take a closer look and then finish my review.
Actually, I think you may be right, though. Sorry for replying before looking
into it. I now think the
`ScheduledThreadPoolExecutor` should be shut down, but
On Sat, 27 Jun 2020 16:25:24 GMT, John Neffenger
wrote:
>> On second thought, this seems more like a workaround than a fix. Maybe it
>> would be better to shutdown the timer to shut
>> it down in an orderly fashion with the FX runtime is terminated. The
>> `QuantumToolkit::exit` method
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Sat, 27 Jun 2020 16:14:36 GMT, Kevin Rushforth
On Sat, 27 Jun 2020 14:34:09 GMT, Johan Vos wrote:
>> Fixes [JDK-8248381](https://bugs.openjdk.java.net/browse/JDK-8248381).
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MonocleTimer.java
> line 38:
>
>> 37: private static final String THREAD_NAME = "Monocle Timer";
On Sat, 27 Jun 2020 14:10:21 GMT, Kevin Rushforth wrote:
>> Note that this is a regression error that is not present in JavaFX 14, so it
>> would be good to fix it before JavaFX 15
>> is released.
>
> The regression was caused by the fix for
>
On Fri, 26 Jun 2020 03:50:02 GMT, John Neffenger
wrote:
> Fixes [JDK-8248381](https://bugs.openjdk.java.net/browse/JDK-8248381).
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MonocleTimer.java
line 38:
> 37: private static final String THREAD_NAME = "Monocle Timer";
>
On Fri, 26 Jun 2020 23:53:21 GMT, John Neffenger
wrote:
>> It looks simple enough for a single reviewer. Since it is in Monocle,
>> @johanvos will probably want to review it.
>
> Note that this is a regression error that is not present in JavaFX 14, so it
> would be good to fix it before
On Fri, 26 Jun 2020 23:23:43 GMT, Kevin Rushforth wrote:
>> Fixes [JDK-8248381](https://bugs.openjdk.java.net/browse/JDK-8248381).
>
> It looks simple enough for a single reviewer. Since it is in Monocle,
> @johanvos will probably want to review it.
Note that this is a regression error that is
On Fri, 26 Jun 2020 03:50:02 GMT, John Neffenger
wrote:
> Fixes [JDK-8248381](https://bugs.openjdk.java.net/browse/JDK-8248381).
It looks simple enough for a single reviewer. Since it is in Monocle, @johanvos
will probably want to review it.
-
PR:
13 matches
Mail list logo
