On Wed, 28 Oct 2020 14:43:52 GMT, Kevin Rushforth wrote:
>> This is a proposed fix for
>> [JDK-8254691](https://bugs.openjdk.java.net/browse/JDK-8254691) to enable
>> GitHub actions for the jfx repo. It is similar in purpose to what was done
>> for the jdk repo.
>>
>> Once this is
On Sat, 31 Oct 2020 14:35:09 GMT, Kevin Rushforth wrote:
>> This works fine. I have a minor comment (about using 15.0.1, but since we
>> don't use that in build.properties either, I think it's not an issue), and
>> apart from that, this looks very good.
>
> I'd rather update the boot JDK to
On Fri, 30 Oct 2020 17:05:37 GMT, Johan Vos wrote:
>> Looks good to me. Verified a dummy PR with two commits.
>> Actions executed correctly on both commits. Also verified that test failure
>> is reported correctly and failed test can be found in log under Actions
>> section.
>
> This works
On Thu, 29 Oct 2020 18:30:47 GMT, Ambarish Rapte wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
On Wed, 28 Oct 2020 14:43:52 GMT, Kevin Rushforth wrote:
>> This is a proposed fix for
>> [JDK-8254691](https://bugs.openjdk.java.net/browse/JDK-8254691) to enable
>> GitHub actions for the jfx repo. It is similar in purpose to what was done
>> for the jdk repo.
>>
>> Once this is
So this doesn’t show lower level test just basically a build successfully
pass/fail on each platform? Or would it show any low level tests if they failed?
Eric Bresie
ebre...@gmail.com (mailto:ebre...@gmail.com)
> On October 28, 2020 at 9:43:53 AM CDT, Kevin Rushforth
On Wed, 28 Oct 2020 14:43:52 GMT, Kevin Rushforth wrote:
>> This is a proposed fix for
>> [JDK-8254691](https://bugs.openjdk.java.net/browse/JDK-8254691) to enable
>> GitHub actions for the jfx repo. It is similar in purpose to what was done
>> for the jdk repo.
>>
>> Once this is
On Tue, 27 Oct 2020 19:02:40 GMT, Kevin Rushforth wrote:
>> ### Note to reviewers:
>>
>> If you want to test this yourself you can pull the PR branch into a branch
>> in your local repo and push it to your personal fork. Something like the
>> following should work for you, assuming that you
> This is a proposed fix for
> [JDK-8254691](https://bugs.openjdk.java.net/browse/JDK-8254691) to enable
> GitHub actions for the jfx repo. It is similar in purpose to what was done
> for the jdk repo.
>
> Once this is integrated, and subsequently merged into your personal fork, a
> GitHub
On Tue, 27 Oct 2020 17:39:08 GMT, Kevin Rushforth wrote:
>>> I noticed this in the openjdk/mobile repository as well, and that looks
>>> great. In that repository, there seems to be a different configuration, as
>>> there is a line for "build" and a line for "test/tier 1" ( e.g.
>>>
On Mon, 26 Oct 2020 08:29:14 GMT, Robin Westberg wrote:
>> The jdk workflow is split into a build job and multiple test jobs (since it
>> takes so long they need the parallelism when running the tests). It's more
>> complicated that way, since you have to feed the results of the build job
>>
On Sat, 24 Oct 2020 16:56:46 GMT, Johan Vos wrote:
>> @rwestberg I was pleasantly surprised to see the Skara bot add this:
>>
>>> | Linux x64 | Windows x64 | macOS x64
>>> -- | -- | -- | --
>>> Build / test | ✔️ (1/1 passed) | ✔️ (1/1 passed) | ✔️ (1/1 passed)
>>
>> I was going to ask you
On Sat, 24 Oct 2020 14:41:08 GMT, Kevin Rushforth wrote:
> This is a proposed fix for
> [JDK-8254691](https://bugs.openjdk.java.net/browse/JDK-8254691) to enable
> GitHub actions for the jfx repo. It is similar in purpose to what was done
> for the jdk repo.
>
> Once this is integrated, and
On Sat, 24 Oct 2020 18:26:29 GMT, Kevin Rushforth wrote:
>>> @rwestberg I was pleasantly surprised to see the Skara bot add this:
>>>
>>> > Linux x64
>>> > Windows x64
>>> > macOS x64
>>> >
>>> >
>>> >
>>> >
>>> > Build / test
>>> > heavy_check_mark (1/1 passed)
>>> > heavy_check_mark (1/1
On Sat, 24 Oct 2020 16:28:28 GMT, Kevin Rushforth wrote:
>> This is a proposed fix for
>> [JDK-8254691](https://bugs.openjdk.java.net/browse/JDK-8254691) to enable
>> GitHub actions for the jfx repo. It is similar in purpose to what was done
>> for the jdk repo.
>>
>> Once this is
On Sat, 24 Oct 2020 14:49:37 GMT, Kevin Rushforth wrote:
>> This is a proposed fix for
>> [JDK-8254691](https://bugs.openjdk.java.net/browse/JDK-8254691) to enable
>> GitHub actions for the jfx repo. It is similar in purpose to what was done
>> for the jdk repo.
>>
>> Once this is
16 matches
Mail list logo
