Re: RFR: 8255940: localStorage is null after window.close() [v6]

2022-02-28 Thread Jay Bhaskar
On Mon, 28 Feb 2022 13:58:03 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add Review Changes > > modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindow.cpp line 851: > >> 849: >>

Re: RFR: 8255940: localStorage is null after window.close() [v6]

2022-02-28 Thread Kevin Rushforth
On Sun, 27 Feb 2022 05:43:27 GMT, Jay Bhaskar wrote: >> Issue: The current implementation of DOMWindow ::localStorage(..) returns >> null pointer in case of page is being closed. >> Fix: It should not return nullptr , as per the [w3c web storage >> spec](https://www.w3.org/TR/2016/REC-webstora

Re: RFR: 8255940: localStorage is null after window.close() [v6]

2022-02-26 Thread Jay Bhaskar
> Issue: The current implementation of DOMWindow ::localStorage(..) returns > null pointer in case of page is being closed. > Fix: It should not return nullptr , as per the [w3c web storage > spec](https://www.w3.org/TR/2016/REC-webstorage-20160419/) > "User agents should expire data from the l

Re: RFR: 8255940: localStorage is null after window.close() [v6]

2022-02-26 Thread Jay Bhaskar
On Sat, 5 Feb 2022 14:57:50 GMT, Kevin Rushforth wrote: >> modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindow.cpp line >> 857: >> >>> 855: return m_localStorage.get(); >>> 856: } >>> 857: >> >> This will change the behavior for the case where page is null or wher