Re: RFR: 8255940: localStorage is null after window.close() [v7]

2022-03-03 Thread Jay Bhaskar
On Tue, 1 Mar 2022 10:00:58 GMT, Ambarish Rapte wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Clean up test and fix > > modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindow.cpp line 850: > >> 848:

Re: RFR: 8255940: localStorage is null after window.close() [v7]

2022-03-01 Thread Ambarish Rapte
On Tue, 1 Mar 2022 02:42:54 GMT, Jay Bhaskar wrote: >> Issue: The current implementation of DOMWindow ::localStorage(..) returns >> null pointer in case of page is being closed. >> Fix: It should not return nullptr , as per the [w3c web storage >> spec](https://www.w3.org/TR/2016/REC-webstorag

Re: RFR: 8255940: localStorage is null after window.close() [v7]

2022-02-28 Thread Jay Bhaskar
> Issue: The current implementation of DOMWindow ::localStorage(..) returns > null pointer in case of page is being closed. > Fix: It should not return nullptr , as per the [w3c web storage > spec](https://www.w3.org/TR/2016/REC-webstorage-20160419/) > "User agents should expire data from the l