On Mon, 6 Dec 2021 13:05:16 GMT, Jeanette Winzenburg
wrote:
> might also need a test that verifies the focusWithin of a parent added
> somewhere above the focused node? hmm .. or maybe not, that would require to
> re-arrange a complete subtree ..
Inserting a parent into a scene graph such
On Mon, 2 Aug 2021 13:20:29 GMT, Michael Strauß wrote:
> > 3. I think the way you are propagating `focusWithin` might not work if
> > nodes are added or removed from the scene graph.
>
> I've added a test for this case:
> `FocusTest.testFocusStatesAreClearedFromFormerParentsOfFocusedNode`.
On Sat, 26 Jun 2021 00:01:20 GMT, Michael Strauß wrote:
> 3. I think the way you are propagating `focusWithin` might not work if nodes
> are added or removed from the scene graph.
I've added a test for this case:
`FocusTest.testFocusStatesAreClearedFromFormerParentsOfFocusedNode`.
On Fri, 25 Jun 2021 23:17:10 GMT, Kevin Rushforth wrote:
> 1. `FocusPropertyBase` overrides `set` (which is unusual). The current
> implementation (of `FocusedProperty `) has some custom logic as well, but it
> didn't try to use the set method of a writable property. Also, you use a
>
On Wed, 9 Jun 2021 14:18:41 GMT, Michael Strauß wrote:
>> This PR adds the `Node.focusVisible` and `Node.focusWithin` properties, as
>> well as the corresponding `:focus-visible` and `:focus-within` CSS
>> pseudo-classes.
>
> Michael Strauß has updated the pull request incrementally with two
On Wed, 9 Jun 2021 13:01:17 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - wording
>> - Re-ordered methods
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 8167:
>
> This PR adds the `Node.focusVisible` and `Node.focusWithin` properties, as
> well as the corresponding `:focus-visible` and `:focus-within` CSS
> pseudo-classes.
Michael Strauß has updated the pull request incrementally with two additional
commits since the last revision:
- wording
-
