Re: RFR: 8268642: Expand the javafx.beans.property.Property documentation [v2]

2021-07-08 Thread Kevin Rushforth
On Thu, 24 Jun 2021 01:53:53 GMT, Michael Strauß wrote: >> * Expand the `Property.bind` and `Property.bindBidirectional` documentation >> * Change the name of the formal parameter of `Property.bind` to "source" >> (currently, it is inconsistently named "observable", "rawObservable" or >> "newOb

Re: RFR: 8268642: Expand the javafx.beans.property.Property documentation [v2]

2021-06-28 Thread Marius Hanl
On Thu, 24 Jun 2021 01:53:53 GMT, Michael Strauß wrote: >> * Expand the `Property.bind` and `Property.bindBidirectional` documentation >> * Change the name of the formal parameter of `Property.bind` to "source" >> (currently, it is inconsistently named "observable", "rawObservable" or >> "newOb

Re: RFR: 8268642: Expand the javafx.beans.property.Property documentation [v2]

2021-06-23 Thread Nir Lisker
On Thu, 24 Jun 2021 02:20:09 GMT, Michael Strauß wrote: >> modules/javafx.base/src/main/java/javafx/beans/property/Property.java line >> 68: >> >>> 66: >>> 67: /** >>> 68: * Removes a unidirectional binding that was established with >>> {@link #bind(ObservableValue)}. >> >> Why "**a

Re: RFR: 8268642: Expand the javafx.beans.property.Property documentation [v2]

2021-06-23 Thread Michael Strauß
On Thu, 24 Jun 2021 01:00:54 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changes as per review > > modules/javafx.base/src/main/java/javafx/beans/property/Property.java line 68: > >> 66: >>

Re: RFR: 8268642: Expand the javafx.beans.property.Property documentation [v2]

2021-06-23 Thread Michael Strauß
> * Expand the `Property.bind` and `Property.bindBidirectional` documentation > * Change the name of the formal parameter of `Property.bind` to "source" > (currently, it is inconsistently named "observable", "rawObservable" or > "newObservable") Michael Strauß has updated the pull request increm

Re: RFR: 8268642: Expand the javafx.beans.property.Property documentation

2021-06-23 Thread Nir Lisker
On Mon, 14 Jun 2021 17:06:34 GMT, Michael Strauß wrote: > * Expand the `Property.bind` and `Property.bindBidirectional` documentation > * Change the name of the formal parameter of `Property.bind` to "source" > (currently, it is inconsistently named "observable", "rawObservable" or > "newObserv

Re: RFR: 8268642: Expand the javafx.beans.property.Property documentation

2021-06-15 Thread Nir Lisker
On Mon, 14 Jun 2021 17:06:34 GMT, Michael Strauß wrote: > * Expand the `Property.bind` and `Property.bindBidirectional` documentation > * Change the name of the formal parameter of `Property.bind` to "source" > (currently, it is inconsistently named "observable", "rawObservable" or > "newObserv

Re: RFR: 8268642: Expand the javafx.beans.property.Property documentation

2021-06-14 Thread Kevin Rushforth
On Mon, 14 Jun 2021 17:06:34 GMT, Michael Strauß wrote: > * Expand the `Property.bind` and `Property.bindBidirectional` documentation > * Change the name of the formal parameter of `Property.bind` to "source" > (currently, it is inconsistently named "observable", "rawObservable" or > "newObserv