Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v10]

2022-03-08 Thread Ambarish Rapte
On Tue, 8 Mar 2022 20:32:53 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window = activeWindow

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v10]

2022-03-08 Thread Kevin Rushforth
On Tue, 8 Mar 2022 20:32:53 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window = activeWindow

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v10]

2022-03-08 Thread Thiago Milczarek Sayao
> Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(activeWindows.size() - 1); > window.setIconified(false); >

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v9]

2022-03-08 Thread Thiago Milczarek Sayao
On Tue, 8 Mar 2022 13:12:03 GMT, Ambarish Rapte wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Capture event serial on process_key > > modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp l

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v9]

2022-03-08 Thread Ambarish Rapte
On Tue, 25 Jan 2022 23:57:09 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window = activeWindo

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v9]

2022-03-07 Thread Kevin Rushforth
On Tue, 25 Jan 2022 23:57:09 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window = activeWindo

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v9]

2022-02-10 Thread Kevin Rushforth
On Tue, 25 Jan 2022 23:57:09 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window = activeWindo

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v7]

2022-02-07 Thread Thiago Milczarek Sayao
On Sat, 11 Dec 2021 00:32:06 GMT, Kevin Rushforth wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Minimize changes > > On my Ubuntu 20.04 VM the bug still happens about 1/2 the time with this fix. @kevin

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v9]

2022-01-25 Thread Thiago Milczarek Sayao
> Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(activeWindows.size() - 1); > window.setIconified(false); >

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v8]

2022-01-25 Thread Thiago Milczarek Sayao
> Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(activeWindows.size() - 1); > window.setIconified(false); >

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v7]

2021-12-10 Thread Kevin Rushforth
On Mon, 1 Nov 2021 16:46:34 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window = activeWindow

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v7]

2021-12-04 Thread Pankaj Bansal
On Mon, 1 Nov 2021 16:46:34 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window = activeWindow

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v7]

2021-11-30 Thread Thiago Milczarek Sayao
On Mon, 1 Nov 2021 16:46:34 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window = activeWindow

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v7]

2021-11-01 Thread Thiago Milczarek Sayao
On Mon, 1 Nov 2021 16:46:34 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window = activeWindow

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v7]

2021-11-01 Thread Thiago Milczarek Sayao
> Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(activeWindows.size() - 1); > window.setIconified(false); >

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v4]

2021-10-29 Thread Thiago Milczarek Sayao
> Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(activeWindows.size() - 1); > window.setIconified(false); >

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v3]

2021-10-12 Thread Thiago Milczarek Sayao
On Tue, 12 Oct 2021 15:16:53 GMT, Pankaj Bansal wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java >> line 861: >> >>> 859: >>> 860: // walk backwards to find a blocker >>> 861: for (int i = activeWindows.size() - 1; i > 0; i--) { >> >>

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v3]

2021-10-12 Thread Pankaj Bansal
On Tue, 12 Oct 2021 15:12:43 GMT, Kevin Rushforth wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Break if reach self > > modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java >

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v3]

2021-10-12 Thread Kevin Rushforth
On Wed, 22 Sep 2021 16:39:15 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window = activeWindo

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v3]

2021-10-12 Thread Kevin Rushforth
On Wed, 22 Sep 2021 16:39:15 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window = activeWindo

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation

2021-10-06 Thread Thiago Milczarek Sayao
On Mon, 16 Aug 2021 06:23:01 GMT, Pankaj Bansal wrote: >> Weird, It works consistently for me on 20.04. Just tested again to be sure. > >> Weird, It works consistently for me on 20.04. Just tested again to be sure. > > I am running a 20.04 VM. The test fails for me 60-70% of the time. I will >

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v3]

2021-10-06 Thread Pankaj Bansal
On Wed, 22 Sep 2021 16:39:15 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window = activeWindo

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v3]

2021-09-30 Thread Thiago Milczarek Sayao
On Wed, 22 Sep 2021 16:39:15 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window = activeWindo

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v3]

2021-09-22 Thread Thiago Milczarek Sayao
> Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(activeWindows.size() - 1); > window.setIconified(false); >

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation

2021-09-21 Thread Thiago Milczarek Sayao
On Thu, 5 Aug 2021 23:38:06 GMT, Thiago Milczarek Sayao wrote: > Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(act

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v2]

2021-09-21 Thread Thiago Milczarek Sayao
> Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(activeWindows.size() - 1); > window.setIconified(false); >

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation

2021-09-21 Thread Thiago Milczarek Sayao
On Thu, 5 Aug 2021 23:38:06 GMT, Thiago Milczarek Sayao wrote: > Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(act

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation

2021-09-17 Thread Kevin Rushforth
On Thu, 5 Aug 2021 23:38:06 GMT, Thiago Milczarek Sayao wrote: > Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(act

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation

2021-09-12 Thread Thiago Milczarek Sayao
On Mon, 16 Aug 2021 06:23:01 GMT, Pankaj Bansal wrote: >> Weird, It works consistently for me on 20.04. Just tested again to be sure. > >> Weird, It works consistently for me on 20.04. Just tested again to be sure. > > I am running a 20.04 VM. The test fails for me 60-70% of the time. I will >

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation

2021-08-15 Thread Pankaj Bansal
On Sun, 15 Aug 2021 20:10:43 GMT, Thiago Milczarek Sayao wrote: > Weird, It works consistently for me on 20.04. Just tested again to be sure. I am running a 20.04 VM. The test fails for me 60-70% of the time. I will request someone in team to try this once. - PR: https://git.open

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation

2021-08-15 Thread Thiago Milczarek Sayao
On Thu, 5 Aug 2021 23:38:06 GMT, Thiago Milczarek Sayao wrote: > Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(act

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation

2021-08-15 Thread Pankaj Bansal
On Thu, 5 Aug 2021 23:38:06 GMT, Thiago Milczarek Sayao wrote: > Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(act

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation

2021-08-05 Thread Thiago Milczarek Sayao
On Thu, 5 Aug 2021 23:38:06 GMT, Thiago Milczarek Sayao wrote: > Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(act