On Sun, 19 Sep 2021 10:53:02 GMT, Marius Hanl wrote:
>>> > ```
>>> > public static Border stroke(Paint stroke, double width) {
>>> > ```
>>> > ...
>>> > But I really want to hear other opinions. This can also be a follow up. :)
>>>
>>> I don't mind adding this variant, but it needs consensus.
On Thu, 16 Sep 2021 21:15:20 GMT, Kevin Rushforth wrote:
> > > ```
> > > public static Border stroke(Paint stroke, double width) {
> > > ```
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > ...
> > > But I really want to hear other
On Wed, 15 Sep 2021 11:16:39 GMT, Ambarish Rapte wrote:
> Above one will just be uniform with existing doc.
In this case it doesn't matter much, but in general I don't like many places of
the `Background` and `Border` docs as they stand :)
I already looked at them as a starting point when
On Thu, 16 Sep 2021 21:15:20 GMT, Kevin Rushforth wrote:
> I agree that it needs consensus, so the question is how many apps would use
> it from code (as opposed to CSS), and be satisfied with the other defaults. I
> don't object to adding a 2nd variant that takes a stroke width as long as we
On Thu, 9 Sep 2021 23:43:29 GMT, Nir Lisker wrote:
>> Added convenience factory factory methods for Background and Border.
>
> Nir Lisker has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Removed whitespaces
> - Added tests and doc
On Thu, 16 Sep 2021 08:36:49 GMT, Marius Hanl wrote:
> One comment from my side: I would find it quite useful if we have another
> border factory method with a double as the second parameter which let us
> specify the border width. So e.g.
>
> ```
> public static Border stroke(Paint stroke,
On Thu, 9 Sep 2021 23:43:29 GMT, Nir Lisker wrote:
>> Added convenience factory factory methods for Background and Border.
>
> Nir Lisker has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Removed whitespaces
> - Added tests and doc
On Wed, 15 Sep 2021 13:04:52 GMT, Kevin Rushforth wrote:
> another possibility is to just capitalize the first occurrence and leave the
> others as lower-case?
That sounds good too, so only the first occurrence would be changed.
-
PR: https://git.openjdk.java.net/jfx/pull/610
On Wed, 15 Sep 2021 11:08:04 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Removed whitespaces
>> - Added tests and doc updates
>
>
On Thu, 9 Sep 2021 23:43:29 GMT, Nir Lisker wrote:
>> Added convenience factory factory methods for Background and Border.
>
> Nir Lisker has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Removed whitespaces
> - Added tests and doc
On Wed, 15 Sep 2021 11:03:20 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Removed whitespaces
>> - Added tests and doc updates
>
>
On Thu, 9 Sep 2021 23:43:29 GMT, Nir Lisker wrote:
>> Added convenience factory factory methods for Background and Border.
>
> Nir Lisker has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Removed whitespaces
> - Added tests and doc
On Thu, 9 Sep 2021 23:43:29 GMT, Nir Lisker wrote:
>> Added convenience factory factory methods for Background and Border.
>
> Nir Lisker has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Removed whitespaces
> - Added tests and doc
> Added convenience factory factory methods for Background and Border.
Nir Lisker has updated the pull request incrementally with two additional
commits since the last revision:
- Removed whitespaces
- Added tests and doc updates
-
Changes:
- all:
14 matches
Mail list logo
