Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS [v2]

2021-12-16 Thread Ajit Ghaisas
On Wed, 15 Dec 2021 22:57:26 GMT, Kevin Rushforth wrote: >> Build change to strip the non-global symbols from native shared libraries on >> Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` >> build. >> >> Here is a before / after size comparison. All sizes in KBytes:

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS [v2]

2021-12-16 Thread Johan Vos
On Wed, 15 Dec 2021 22:57:26 GMT, Kevin Rushforth wrote: >> Build change to strip the non-global symbols from native shared libraries on >> Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` >> build. >> >> Here is a before / after size comparison. All sizes in KBytes:

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS [v2]

2021-12-16 Thread Kevin Rushforth
On Thu, 16 Dec 2021 01:33:31 GMT, Michael Strauß wrote: > Here are my results when building with `-PCONF=Release` on macOS 11.6.1: My guess is that the differences are due to either your macOS version or the Xcode you used to build, and that your "current" numbers would also be different from

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS

2021-12-15 Thread Johan Vos
On Wed, 15 Dec 2021 22:12:12 GMT, Kevin Rushforth wrote: > > The only question I have for now is if it would make sense to have a new > > configuration instead of binding this to DEBUG_NATIVE. > > I had initially thought of only stripping the binaries for production builds, > e.g., when `-PCON

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS [v2]

2021-12-15 Thread Michael Strauß
On Wed, 15 Dec 2021 22:57:26 GMT, Kevin Rushforth wrote: >> Build change to strip the non-global symbols from native shared libraries on >> Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` >> build. >> >> Here is a before / after size comparison. All sizes in KBytes:

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS [v2]

2021-12-15 Thread Michael Strauß
On Wed, 15 Dec 2021 22:57:26 GMT, Kevin Rushforth wrote: >> Build change to strip the non-global symbols from native shared libraries on >> Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` >> build. >> >> Here is a before / after size comparison. All sizes in KBytes:

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS [v2]

2021-12-15 Thread Kevin Rushforth
> Build change to strip the non-global symbols from native shared libraries on > Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` > build. > > Here is a before / after size comparison. All sizes in KBytes: > > ### Linux > > | Native Library | Current | Stripped | > |

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS

2021-12-15 Thread Kevin Rushforth
On Wed, 15 Dec 2021 21:23:23 GMT, Johan Vos wrote: > The only question I have for now is if it would make sense to have a new > configuration instead of binding this to DEBUG_NATIVE. I had initially thought of only stripping the binaries for production builds, e.g., when `-PCONF=Release` is sp

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS

2021-12-15 Thread Johan Vos
On Wed, 15 Dec 2021 00:25:08 GMT, Kevin Rushforth wrote: > Build change to strip the non-global symbols from native shared libraries on > Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` > build. > > Here is a before / after size comparison. All sizes in KBytes: > >