Re: Re: cleanup obsolete code

2021-01-21 Thread Eric Bresie
Would removal of this break anything on other platforms (OS or hardware [embedded/non-embedded], Wayland)? Assume since focused x11 (mainly Unix platforms) it shouldn’t but figured I’d ask. A little off topic but is an architecture diagram with applicable elements available someplace? If not

Re: cleanup obsolete code

2021-01-18 Thread Johan Vos
Related to this question, there is the comment from Kevin about removing references to es2-eglfb/es2-eglx11 in other files, e.g. ES2Pipeline.java [1] While I believe this is a good idea, it opens room for more cleanup (or at least more consistency): In some cases, library names indicate a

Re: cleanup obsolete code

2021-01-16 Thread Johan Vos
I would guess those were used before Monocle was introduced. On Sat, Jan 16, 2021 at 12:47 PM Nir Lisker wrote: > Out of curiosity, what were they used for? > > On Thu, Jan 14, 2021 at 3:54 PM Johan Vos wrote: > >> Hi, >> >> We currently have a number of GLFactory implementations in the ES2

Re: cleanup obsolete code

2021-01-16 Thread Nir Lisker
Out of curiosity, what were they used for? On Thu, Jan 14, 2021 at 3:54 PM Johan Vos wrote: > Hi, > > We currently have a number of GLFactory implementations in the ES2 Prism > pipeline that are probably never used: EGLX11 and EGLFX. On Linux, we use > X11, and systems with monocle can use

Re: cleanup obsolete code

2021-01-14 Thread Kevin Rushforth
Hi Johan, This seems like good cleanup. I can't think of any problems that would arise. -- Kevin On 1/14/2021 5:53 AM, Johan Vos wrote: Hi, We currently have a number of GLFactory implementations in the ES2 Prism pipeline that are probably never used: EGLX11 and EGLFX. On Linux, we use