Re: Request for permission to backport fixes to jfx-11

2019-10-24 Thread Johan Vos
Looking a bit deeper into it, it seems there are some related issues that might be caused by the same root cause, or by this fix. I'll request to backport it once we have more insight about the potential regressions. - Johan On Tue, Oct 22, 2019 at 1:47 PM Johan Vos wrote: > I'm ok with the

Re: Request for permission to backport fixes to jfx-11

2019-10-22 Thread Johan Vos
I'm ok with the backport, as long as the patch applies clean -- which it most likely does, as I don't think we have other changes in that file. - Johan On Mon, Oct 21, 2019 at 11:15 PM Kevin Rushforth wrote: > > JDK-8193502 > > Johan can comment on whether he wants to backport it. As noted

Re: Request for permission to backport fixes to jfx-11

2019-10-21 Thread Kevin Rushforth
> JDK-8193502 Johan can comment on whether he wants to backport it. As noted below, someone reported a regression associated with it when using gtk2, but we don't have a bug filed or a test case. > It might have been solved in the fix for JDK-8179073. Not sure what you mean since

Re: Request for permission to backport fixes to jfx-11

2019-10-21 Thread Sverre Moe
Could JavaFX 11 also get backported the fix related for JDK-8193502? It might have been solved in the fix for JDK-8179073. I noticed this regression right after JDK 9 build 161. Recently also JavaFX 8 got this regression after update 181. It seems this was fixed in JavaFX 13. I asked on GitHub

Re: Request for permission to backport fixes to jfx-11

2019-10-21 Thread Kevin Rushforth
+1 -- Kevin On 10/21/2019 3:16 AM, Johan Vos wrote: Hi Kevin, I request permission to backport the following issues to the jfx-11 repository. All patches apply clean or with minor changes (e.g. build.properties must keep jfx.release.major.version to 11) Thanks, - Johan

Request for permission to backport fixes to jfx-11

2019-10-21 Thread Johan Vos
Hi Kevin, I request permission to backport the following issues to the jfx-11 repository. All patches apply clean or with minor changes (e.g. build.properties must keep jfx.release.major.version to 11) Thanks, - Johan https://bugs.openjdk.java.net/browse/JDK-8221302 : Upgrade to gcc 8.2 on