Re: Review: Switch to Jigsaw-aware boot JDK for compiling FX 9

2016-11-02 Thread David Hill
On 11/2/16, 1:01 PM, Phil Race wrote: Updated with your suggestion, moved the obvious hot spots to the top. David, I generally make the following request of "large" reviews : One thing that would help a lot here is if the "important" files were at the top rather than buried due to lexical sort

Re: Review: Switch to Jigsaw-aware boot JDK for compiling FX 9

2016-11-02 Thread Phil Race
David, I generally make the following request of "large" reviews : One thing that would help a lot here is if the "important" files were at the top rather than buried due to lexical sorting by path name. In particular files like build.gradle and so on .. people then get a sense of what it is

Review: Switch to Jigsaw-aware boot JDK for compiling FX 9

2016-11-02 Thread David Hill
JBS: https://bugs.openjdk.java.net/browse/JDK-8161704 Webrev: http://cr.openjdk.java.net/~ddhill/8161704/ Kevin, Chien, Vadim, There is a lot of change in this webrev, but there are a lot of common patterns (or sets of changes) ./apps - the majority of the change is altering the NB project fi