Re: To write tests or not to write tests ...

2019-11-15 Thread Jeanette Winzenburg
Zitat von Kevin Rushforth : In general, I would say it's OK to rely on existing tests for trivial refactoring, that is a refactoring where it seems fairly obvious that there are not going to be changes in behavior (even if such tests may be inadequate). For less trivial refactoring, if

Re: To write tests or not to write tests ...

2019-11-08 Thread Kevin Rushforth
In general, I would say it's OK to rely on existing tests for trivial refactoring, that is a refactoring where it seems fairly obvious that there are not going to be changes in behavior (even if such tests may be inadequate). For less trivial refactoring, if there are clearly missing tests, I

To write tests or not to write tests ...

2019-11-08 Thread Jeanette Winzenburg
... if changes are "just" a re-arrangement of code (like https://github.com/openjdk/jfx/pull/6 - 8207957: TableSkinUtils should not contain actual code implementation)? In an ideal world, there would be a safety-net of tests (they would have been written at the time the old code was