Re: Updated OpenJFX build instructions

2017-12-24 Thread Nir Lisker
Just as I was about to ask Santa for a successful build Iv'e managed to do it. Here are my conclusions for Win10 without WebKit: 1. vcvars32.bat VS 2017 does not create vcvars32.bat by default, some components need to be selected. I don't know which ones exactly, I think it's "VC++ 2017 v141

Re: Updated OpenJFX build instructions

2017-12-23 Thread Kevin Rushforth
It's quite possible that Microsoft changed something in their installation of Visual Studio. We are relying on the VC/Auxiliary/Build directory being created as part of the (default) Visual Studio installation so we can find vcvars32.bat. You might look in your installation and see whether

Re: Updated OpenJFX build instructions

2017-12-22 Thread Nir Lisker
I did set them, but... if I set them in bash they disappear the next time I launch it, which made me think they are not being set properly for some reason even though they appear in `export -p` immediately after. Launching bash as admin didn't do anything (I thought write permissions issue). So I

Re: Updated OpenJFX build instructions

2017-12-22 Thread Kevin Rushforth
Thanks for the feedback...I'll note it. As for the build failure, did you install Visual Studio 2017 and set the two env variables (VS150COMNTOOLS and MSVC_VER) to point to it? If so, then it should determine WINSDK_DIR without anything else needed. -- Kevin Nir Lisker wrote: Thanks

Re: Updated OpenJFX build instructions

2017-12-22 Thread Nir Lisker
Thanks Kevin, I'm going through the process now on Win 10. A few things to note: - In the Platform Prerequisites/cygwin it says to make sure mercurial package is installed. Later, under Common Prerequisites/Mercurial it says "you can also install Mercurial as a cygwin package". It's not clear

Re: Updated OpenJFX build instructions

2017-12-22 Thread Michael Ennen
Thanks for taking the time to do this, Kevin. On Fri, Dec 22, 2017 at 11:13 AM, Kevin Rushforth < kevin.rushfo...@oracle.com> wrote: > [resend with typo fixed in Subject line] > > I did a first pass over the build instructions on the OpenJFX Wiki [1]. I > think I cleaned up the worst of the

Updated OpenJFX build instructions

2017-12-22 Thread Kevin Rushforth
[resend with typo fixed in Subject line] I did a first pass over the build instructions on the OpenJFX Wiki [1]. I think I cleaned up the worst of the inaccuracies, and added some information that will make it easier to build. I'm not the best person to see whether anything important is