Re: split code and tests in a PR

2021-06-22 Thread Kevin Rushforth
When I am doing a review and want to test a PR, I do something similar to what Johan mentioned. I download the PR to my local fork, verify it (often with manual testing in addition to the provided tests), and then backout the code changes to see whether the provided automated test would catch t

Re: split code and tests in a PR

2021-06-22 Thread Nir Lisker
I also thought it would be useful for the bot to run the tests after the patch and notify on a failure. I didn't think about applying the new tests to the old code with "hopes" for a failure, I like this idea. Providing 2 downloads is also useful. One thing we need to be careful with is that an ol

split code and tests in a PR

2021-06-22 Thread Johan Vos
Hi, I really like the automation that Skara is providing. It saves time for committers as well as for reviewers. In order to increase productivity even more (without decreasing quality), there might be an additional step we might somehow automate. Many PR's contain changes in java code and in test