Re: Formatted text field API (RT-14000, RT-30881)
There's a new proposal here: https://javafx-jira.kenai.com/browse/RT-14000
I merged FormattedTextField and content filter to a single Formatter
class, that's now part of the TextInputControl.
-Martin
On 06/11/2014 10:50 AM, Martin Sladecek wrote:
Hello,
I would like to start some discussion about formatted text field API.
The related JIRA issues are RT-14000 (formatted text field) and
RT-30881 (content filter).
The RT-30881 defines a content filter for all text input controls (in
TextInputControl class), like TextField and TextArea. This was
originally implemented by Richard Bair and briefly discussed here:
http://mail.openjdk.java.net/pipermail/openjfx-dev/2012-December/004687.html.
I've tried to build formatted text field on top of that (and made some
changes to the API) since content filtering is something most
formatted text fields will use.
First, the TextInputControl additions:
* contentFilter property of type ObjectPropertyContentFilter
So let's look at the content filter and content change (both nested
classes of TextInputControl):
/**
* Content Filter specifies the filter to be used with {@link
TextInputControl#contentFilterProperty()}.
* It allow user to intercept and modify any change done to the
text content.
* To avoid content that's not valid for the filter, it's possible
to assign a default value supplier for the filter.
* p
* The filter itself is an {@code UnaryOperator} that accepts
{@link javafx.scene.control.TextInputControl.ContentChange} object.
* It should return a {@link
javafx.scene.control.TextInputControl.ContentChange} object that
contains the actual (filtered)
* change. Returning null rejects the change.
* p
* If default value supplier is provided, it is used when the
{@code ContentFilter} is assigned to a {@code TextInputControl}
* and it's current text is invalid. It is expected that the
provided default value is accepted by the filtering operator.
*/
public static class ContentFilter {
/**
* Creates a new filter with the providing filtering operator.
* @param filter the filtering operator
*
* @throws java.lang.NullPointerException if filter is null
*/
public ContentFilter(UnaryOperatorContentChange filter) {}
/**
* Creates a new filter with the providing filtering operator
and default value supplier.
* @param filter the filtering operator
* @param defaultValue the default value or null
*
* @throws java.lang.NullPointerException if filter is null
*/
public ContentFilter(UnaryOperatorContentChange filter,
SupplierString defaultValue) {}
/**
* The filtering operator of this filter.
* @return the operator
*/
public UnaryOperatorContentChange getFilter() {}
/**
* The default value provider of this filter
* @return the default value provider or null
*/
public SupplierString getDefaultValue() {}
/**
* Chains this filter with a filtering operator. The other
filtering operator is used only if this
* filter's operator rejects the operation. The default value
of the new {@code ContentFilter} is the same
* as of this filter.
* @param other the filtering operator to chain
* @return a new ContentFilter as described above
*/
public ContentFilter orApply(UnaryOperatorContentChange
other) {}
/**
* Chains this filter with a filtering operator of another
{@code ContentFilter}. The other filtering operator is used only if this
* filter's operator rejects the operation. The default value
of the new {@code ContentFilter} is the same
* as of this filter.
* @param other the filter to chain
* @return a new ContentFilter as described above
*/
public ContentFilter orApply(ContentFilter other) {}
}
/**
* Contains the state representing a change in the content for a
* TextInputControl. This object is passed to any registered
* {@code contentFilter} on the TextInputControl whenever the text
* for the TextInputControl is modified.
* p
* This class contains state and convenience methods for
determining what
* change occurred on the control. It also has a reference to the
* TextInputControl itself so that the developer may query any
other
* state on the control. Note that you should never modify the
state
* of the control directly from within the contentFilter handler.
* /p
* p
* The ContentChange is mutable, but not observable. It should
be used
* only for the life of a single change. It is intended that the
* ContentChange will be modified from within the contentFilter.
* /p
*/
public static final class
hg: openjfx/8u-dev/rt: RT-37586 [StackedAreaChart] Display problem with StackedAreaChart when the axis is not displayed
Changeset: c21b1705eb10 Author:Martin Sladecek martin.slade...@oracle.com Date: 2014-07-02 13:12 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c21b1705eb10 RT-37586 [StackedAreaChart] Display problem with StackedAreaChart when the axis is not displayed Reviewed by: dgrieve ! modules/controls/src/main/java/javafx/scene/chart/StackedAreaChart.java
hg: openjfx/8u-dev/rt: RT-37747 Additional app-thread checks should be added (back) after RT-17716
Changeset: 8cc538c3a7f8 Author:Martin Sladecek martin.slade...@oracle.com Date: 2014-07-02 13:17 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8cc538c3a7f8 RT-37747 Additional app-thread checks should be added (back) after RT-17716 Reviewed by: kcr, anthony ! modules/graphics/src/main/java/javafx/scene/Parent.java ! modules/graphics/src/main/java/javafx/stage/Stage.java ! modules/graphics/src/test/java/javafx/scene/SceneTest.java ! modules/graphics/src/test/java/javafx/stage/PopupTest.java
hg: openjfx/8u20/rt: Added tag 8u20-b21 for changeset dab88dec3067
Changeset: 84eeb1f71882 Author:hudson Date: 2014-07-02 07:51 -0700 URL: http://hg.openjdk.java.net/openjfx/8u20/rt/rev/84eeb1f71882 Added tag 8u20-b21 for changeset dab88dec3067 ! .hgtags
OpenJFX: API Review Process
Hi all, We've been working hard to document OpenJFX development over the past few months and strangely, the API Review Process was not described anywhere. To fix this, I have updated the wiki: https://wiki.openjdk.java.net/display/OpenJFX/API+Review API is forever so it is very important that we are careful and consistent in our approach to updating the toolkit. Steve
hg: openjfx/8u-dev/rt: 3 new changesets
Changeset: dab88dec3067 Author:Felipe Heidrich felipe.heidr...@oracle.com Date: 2014-06-26 05:10 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/dab88dec3067 RT-37704: [Regression, Linux] ArrayIndexOutOfBoundsException when trying to open HTMLEditor font name combobox. ! modules/graphics/src/main/java/com/sun/javafx/font/freetype/FTFontFile.java Changeset: 84eeb1f71882 Author:hudson Date: 2014-07-02 07:51 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/84eeb1f71882 Added tag 8u20-b21 for changeset dab88dec3067 ! .hgtags Changeset: 4b53bb6d1abf Author:kcr Date: 2014-07-02 10:05 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/4b53bb6d1abf Automated merge with http://hg.openjdk.java.net/openjfx/8u20/rt - .idea/rt-tests.iml - modules/graphics/src/main/java/com/sun/glass/ui/PlatformAccessible.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/dispman/DispmanAcceleratedScreen.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/dispman/DispmanCursor.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/dispman/DispmanPlatform.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/dispman/DispmanPlatformFactory.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/dispman/DispmanScreen.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/headless/HeadlessPlatform.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/headless/HeadlessPlatformFactory.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/headless/HeadlessScreen.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/input/InputDevice.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/input/InputDeviceRegistry.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/input/KeyInput.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/input/KeyState.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/input/MouseInput.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/input/MouseInputSynthesizer.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/input/MouseState.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/input/TouchInput.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/input/TouchState.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/input/filters/AssignPointIDTouchFilter.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/input/filters/LookaheadTouchFilter.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/input/filters/NearbyPointsTouchFilter.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/input/filters/SmallMoveTouchFilter.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/input/filters/TouchFilter.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/input/filters/TouchPipeline.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/AbsoluteInputCapabilities.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/FBDevScreen.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/GetEvent.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/Input.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/KeyBits.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/LinuxEventBuffer.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/LinuxEventBuffers.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/LinuxFrameBuffer.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/LinuxInputDevice.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/LinuxInputDeviceRegistry.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/LinuxInputProcessor.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/LinuxKeyProcessor.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/LinuxMouseProcessor.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/LinuxPlatform.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/LinuxPlatformFactory.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/LinuxSimpleTouchProcessor.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/LinuxStatefulMultiTouchProcessor.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/LinuxStatelessMultiTouchProcessor.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/LinuxSystem.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/LinuxTouchProcessor.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/LinuxTouchTransform.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/SysFS.java - modules/graphics/src/main/java/com/sun/glass/ui/monocle/linux/Udev.java -
[8u40] Review request: RT-37602: [Spec] Cursor.setVisible behavior is unspecified
Hi Daniel, Please review the fix: https://javafx-jira.kenai.com/browse/RT-37602 -- best regards, Anthony
Is Bundler now working for command line parameters?
Hi Danno, Is b20 have the fix for command line parameters that should get passed to the args for the static main method? And if so how do I do that via the deployfx ant task? Thanks, -Tony
Re: Is Bundler now working for command line parameters?
This won’t be fixed until 8u40. What platforms are you targeting? Mac, Linux, Windows? On Jul 2, 2014, at 2:35 PM, Tony Anecito adanec...@yahoo.com wrote: Hi Danno, Is b20 have the fix for command line parameters that should get passed to the args for the static main method? And if so how do I do that via the deployfx ant task? Thanks, -Tony
Review Request: RT-37788
Chris, Kevin, Steve, Please review this fix for RT-37788. Since I am not an objective C any comments are welcome. Also, please consider if this is too much for an 8u20 fix (the diff is against the current 8u40 codebase). Webrev: http://cr.openjdk.java.net/~shemnon/RT-37788/webrev.00/ JIRA: https://javafx-jira.kenai.com/browse/RT-37788 —Danno
Re: Review Request: RT-37788
I'm glad your not an objective C. I suggest getting Felipe to look at this code too should we decide to go ahead with it. Steve On 2014-07-02, 5:15 PM, Danno Ferrin wrote: Chris, Kevin, Steve, Please review this fix for RT-37788. Since I am not an objective C any comments are welcome. Also, please consider if this is too much for an 8u20 fix (the diff is against the current 8u40 codebase). Webrev: http://cr.openjdk.java.net/~shemnon/RT-37788/webrev.00/ JIRA: https://javafx-jira.kenai.com/browse/RT-37788 —Danno
Re: Review Request: RT-37788
I’m not sure about for 8u20. Seems fairly straight forward, and your Obj-C
seems as good as any Obj-C. My only complaint at the moment is the following:
358 if ([pathParts count] 2) {
359 // for 3 or more steps, the domain is first.second.third and the
keys are /first/second/third/, fourth/, fifth/... etc
360 persistentDomain = [NSString stringWithFormat: @%@.%@.%@,
[pathParts objectAtIndex: 0],
361 [pathParts objectAtIndex: 1], [pathParts
objectAtIndex: 2]];
362
363 [dictPath replaceObjectAtIndex: 0 withObject: [NSString
stringWithFormat:@/%@/%@/%@, [pathParts objectAtIndex: 0],
364[pathParts
objectAtIndex: 1], [pathParts objectAtIndex: 2]]];
365 [dictPath removeObjectAtIndex: 2];
366 [dictPath removeObjectAtIndex: 1];
367 } else {
368 // for 1 or two steps, the domain is first.second.third and the
keys are /, first/, second/
369 persistentDomain = @DEFAULT_JAVA_PREFS_DOMAIN;
370 [dictPath insertObject: @ atIndex:0];
371 }
what if [pathParts count] is 0? I’d probably do a switch:
switch ([pathParts count]) {
case 0:
//error
return/break;
case 1:
case 2:
368 // for 1 or two steps, the domain is first.second.third and the
keys are /, first/, second/
369 persistentDomain = @DEFAULT_JAVA_PREFS_DOMAIN;
370 [dictPath insertObject: @ atIndex:0];
default:
359 // for 3 or more steps, the domain is first.second.third and the
keys are /first/second/third/, fourth/, fifth/... etc
360 persistentDomain = [NSString stringWithFormat: @%@.%@.%@,
[pathParts objectAtIndex: 0],
361 [pathParts objectAtIndex: 1], [pathParts
objectAtIndex: 2]];
362
363 [dictPath replaceObjectAtIndex: 0 withObject: [NSString
stringWithFormat:@/%@/%@/%@, [pathParts objectAtIndex: 0],
364[pathParts
objectAtIndex: 1], [pathParts objectAtIndex: 2]]];
365 [dictPath removeObjectAtIndex: 2];
366 [dictPath removeObjectAtIndex: 1];
}
Make sense? Clear as mud?
Chris
On Jul 2, 2014, at 2:15 PM, Danno Ferrin danno.fer...@oracle.com wrote:
Chris, Kevin, Steve,
Please review this fix for RT-37788. Since I am not an objective C any
comments are welcome. Also, please consider if this is too much for an 8u20
fix (the diff is against the current 8u40 codebase).
Webrev: http://cr.openjdk.java.net/~shemnon/RT-37788/webrev.00/
JIRA: https://javafx-jira.kenai.com/browse/RT-37788
—Danno
Re: Review Request: RT-37788
Personally, I wouldn't change any native code at this point unless it
was fixing a crash. The review is for 8u40, correct?
Steve
On 2014-07-02, 5:38 PM, Chris Bensen wrote:
I’m not sure about for 8u20. Seems fairly straight forward, and your
Obj-C seems as good as any Obj-C. My only complaint at the moment is
the following:
358 if ([pathParts count] 2) {
359 // for 3 or more steps, the domain is first.second.third and the keys are
/first/second/third/, fourth/, fifth/... etc
360 persistentDomain = [NSString stringWithFormat: @%@.%@.%@,
[pathParts objectAtIndex: 0],
361 [pathParts objectAtIndex: 1], [pathParts
objectAtIndex: 2]];
362
363 [dictPath replaceObjectAtIndex: 0 withObject: [NSString
stringWithFormat:@/%@/%@/%@, [pathParts objectAtIndex: 0],
364[pathParts
objectAtIndex: 1], [pathParts objectAtIndex: 2]]];
365 [dictPath removeObjectAtIndex: 2];
366 [dictPath removeObjectAtIndex: 1];
367 } else {
368 // for 1 or two steps, the domain is first.second.third and the keys are /,
first/, second/
369 persistentDomain = @DEFAULT_JAVA_PREFS_DOMAIN;
370 [dictPath insertObject: @ atIndex:0];
371 }
what if [pathParts count] is 0? I’d probably do a switch:
switch ([pathParts count]) {
case 0:
//error
return/break;
case 1:
case 2:
368 // for 1 or two steps, the domain is first.second.third and the keys are /,
first/, second/
369 persistentDomain = @DEFAULT_JAVA_PREFS_DOMAIN;
370 [dictPath insertObject: @ atIndex:0];
default:
359 // for 3 or more steps, the domain is first.second.third and the keys are
/first/second/third/, fourth/, fifth/... etc
360 persistentDomain = [NSString stringWithFormat: @%@.%@.%@,
[pathParts objectAtIndex: 0],
361 [pathParts objectAtIndex: 1], [pathParts
objectAtIndex: 2]];
362
363 [dictPath replaceObjectAtIndex: 0 withObject: [NSString
stringWithFormat:@/%@/%@/%@, [pathParts objectAtIndex: 0],
364[pathParts
objectAtIndex: 1], [pathParts objectAtIndex: 2]]];
365 [dictPath removeObjectAtIndex: 2];
366 [dictPath removeObjectAtIndex: 1];
}
Make sense? Clear as mud?
Chris
On Jul 2, 2014, at 2:15 PM, Danno Ferrin danno.fer...@oracle.com
mailto:danno.fer...@oracle.com wrote:
Chris, Kevin, Steve,
Please review this fix for RT-37788. Since I am not an objective C
any comments are welcome. Also, please consider if this is too much
for an 8u20 fix (the diff is against the current 8u40 codebase).
Webrev: http://cr.openjdk.java.net/~shemnon/RT-37788/webrev.00/
http://cr.openjdk.java.net/%7Eshemnon/RT-37788/webrev.00/
JIRA: https://javafx-jira.kenai.com/browse/RT-37788
—Danno
Re: Review Request: RT-37788
Yes, this has to be fixed in native code. 8u40 it is then.
I can make it cause a crash, but that starts with shooting myself in the foot,
and not much can be done to fix it (by passing in bogus VM arguments).
On Jul 2, 2014, at 3:40 PM, Stephen F Northover steve.x.northo...@oracle.com
wrote:
Personally, I wouldn't change any native code at this point unless it was
fixing a crash. The review is for 8u40, correct?
Steve
On 2014-07-02, 5:38 PM, Chris Bensen wrote:
I’m not sure about for 8u20. Seems fairly straight forward, and your Obj-C
seems as good as any Obj-C. My only complaint at the moment is the following:
358 if ([pathParts count] 2) {
359 // for 3 or more steps, the domain is first.second.third and
the keys are /first/second/third/, fourth/, fifth/... etc
360 persistentDomain = [NSString stringWithFormat: @%@.%@.%@,
[pathParts objectAtIndex: 0],
361 [pathParts objectAtIndex: 1], [pathParts
objectAtIndex: 2]];
362
363 [dictPath replaceObjectAtIndex: 0 withObject: [NSString
stringWithFormat:@/%@/%@/%@, [pathParts objectAtIndex: 0],
364[pathParts
objectAtIndex: 1], [pathParts objectAtIndex: 2]]];
365 [dictPath removeObjectAtIndex: 2];
366 [dictPath removeObjectAtIndex: 1];
367 } else {
368 // for 1 or two steps, the domain is first.second.third and the
keys are /, first/, second/
369 persistentDomain = @DEFAULT_JAVA_PREFS_DOMAIN;
370 [dictPath insertObject: @ atIndex:0];
371 }
what if [pathParts count] is 0? I’d probably do a switch:
switch ([pathParts count]) {
case 0:
//error
return/break;
case 1:
case 2:
368 // for 1 or two steps, the domain is first.second.third and the
keys are /, first/, second/
369 persistentDomain = @DEFAULT_JAVA_PREFS_DOMAIN;
370 [dictPath insertObject: @ atIndex:0];
default:
359 // for 3 or more steps, the domain is first.second.third and
the keys are /first/second/third/, fourth/, fifth/... etc
360 persistentDomain = [NSString stringWithFormat: @%@.%@.%@,
[pathParts objectAtIndex: 0],
361 [pathParts objectAtIndex: 1], [pathParts
objectAtIndex: 2]];
362
363 [dictPath replaceObjectAtIndex: 0 withObject: [NSString
stringWithFormat:@/%@/%@/%@, [pathParts objectAtIndex: 0],
364[pathParts
objectAtIndex: 1], [pathParts objectAtIndex: 2]]];
365 [dictPath removeObjectAtIndex: 2];
366 [dictPath removeObjectAtIndex: 1];
}
Make sense? Clear as mud?
Chris
On Jul 2, 2014, at 2:15 PM, Danno Ferrin danno.fer...@oracle.com wrote:
Chris, Kevin, Steve,
Please review this fix for RT-37788. Since I am not an objective C any
comments are welcome. Also, please consider if this is too much for an
8u20 fix (the diff is against the current 8u40 codebase).
Webrev: http://cr.openjdk.java.net/~shemnon/RT-37788/webrev.00/
JIRA: https://javafx-jira.kenai.com/browse/RT-37788
—Danno
Code Review Request For RT-37789: Embedded, 3D: Rendering artifacts on the Freescale iMX6 device
Hi Kevin, Please review this fix, details is in the JIRA: https://javafx-jira.kenai.com/browse/RT-37789 - Chien
hg: openjfx/8u-dev/rt: Fix RT-37300: Canvas needs a fast rectangular clip capability
Changeset: ddf059995fc0 Author:flar james.gra...@oracle.com Date: 2014-07-02 16:21 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/ddf059995fc0 Fix RT-37300: Canvas needs a fast rectangular clip capability Reviewed by: Felipe ! modules/graphics/src/main/java/com/sun/javafx/geom/Path2D.java ! modules/graphics/src/main/java/com/sun/javafx/sg/prism/NGCanvas.java
[8u40] review request: RT-37790: ObservableList.java is missing from javafx-src.zip
David, Please review this simple build fix to restore some missing source files in javafx-src.zip in the JDK (it doesn't affect the runtime). The patch is in the JIRA. https://javafx-jira.kenai.com/browse/RT-37790 -- Kevin
Re: Review Request: RT-37788
Hello, Danno.
I’ve noticed that you are leaking userDefaults and expandedOptions objects.
Adding autorelease to them would save you some memory.
With best regards. Petr.
On Jul 3, 2014, at 1:43 AM, Danno Ferrin danno.fer...@oracle.com wrote:
Yes, this has to be fixed in native code. 8u40 it is then.
I can make it cause a crash, but that starts with shooting myself in the
foot, and not much can be done to fix it (by passing in bogus VM arguments).
On Jul 2, 2014, at 3:40 PM, Stephen F Northover
steve.x.northo...@oracle.com wrote:
Personally, I wouldn't change any native code at this point unless it was
fixing a crash. The review is for 8u40, correct?
Steve
On 2014-07-02, 5:38 PM, Chris Bensen wrote:
I’m not sure about for 8u20. Seems fairly straight forward, and your Obj-C
seems as good as any Obj-C. My only complaint at the moment is the
following:
358 if ([pathParts count] 2) {
359 // for 3 or more steps, the domain is first.second.third and
the keys are /first/second/third/, fourth/, fifth/... etc
360 persistentDomain = [NSString stringWithFormat: @%@.%@.%@,
[pathParts objectAtIndex: 0],
361 [pathParts objectAtIndex: 1], [pathParts
objectAtIndex: 2]];
362
363 [dictPath replaceObjectAtIndex: 0 withObject: [NSString
stringWithFormat:@/%@/%@/%@, [pathParts objectAtIndex: 0],
364[pathParts
objectAtIndex: 1], [pathParts objectAtIndex: 2]]];
365 [dictPath removeObjectAtIndex: 2];
366 [dictPath removeObjectAtIndex: 1];
367 } else {
368 // for 1 or two steps, the domain is first.second.third and the
keys are /, first/, second/
369 persistentDomain = @DEFAULT_JAVA_PREFS_DOMAIN;
370 [dictPath insertObject: @ atIndex:0];
371 }
what if [pathParts count] is 0? I’d probably do a switch:
switch ([pathParts count]) {
case 0:
//error
return/break;
case 1:
case 2:
368 // for 1 or two steps, the domain is first.second.third and the
keys are /, first/, second/
369 persistentDomain = @DEFAULT_JAVA_PREFS_DOMAIN;
370 [dictPath insertObject: @ atIndex:0];
default:
359 // for 3 or more steps, the domain is first.second.third and
the keys are /first/second/third/, fourth/, fifth/... etc
360 persistentDomain = [NSString stringWithFormat: @%@.%@.%@,
[pathParts objectAtIndex: 0],
361 [pathParts objectAtIndex: 1], [pathParts
objectAtIndex: 2]];
362
363 [dictPath replaceObjectAtIndex: 0 withObject: [NSString
stringWithFormat:@/%@/%@/%@, [pathParts objectAtIndex: 0],
364[pathParts
objectAtIndex: 1], [pathParts objectAtIndex: 2]]];
365 [dictPath removeObjectAtIndex: 2];
366 [dictPath removeObjectAtIndex: 1];
}
Make sense? Clear as mud?
Chris
On Jul 2, 2014, at 2:15 PM, Danno Ferrin danno.fer...@oracle.com wrote:
Chris, Kevin, Steve,
Please review this fix for RT-37788. Since I am not an objective C any
comments are welcome. Also, please consider if this is too much for an
8u20 fix (the diff is against the current 8u40 codebase).
Webrev: http://cr.openjdk.java.net/~shemnon/RT-37788/webrev.00/
JIRA: https://javafx-jira.kenai.com/browse/RT-37788
—Danno
Re: Is Bundler now working for command line parameters?
Hi Danno, Mac then Windows app stores. Regards, -Tony On Wednesday, July 2, 2014 2:41 PM, Danno Ferrin danno.fer...@oracle.com wrote: This won’t be fixed until 8u40. What platforms are you targeting? Mac, Linux, Windows? On Jul 2, 2014, at 2:35 PM, Tony Anecito adanec...@yahoo.com wrote: Hi Danno, Is b20 have the fix for command line parameters that should get passed to the args for the static main method? And if so how do I do that via the deployfx ant task? Thanks, -Tony
