[8u40] Review request for RT-38058: Pagination leak
Jonathan, I've pulled out the following patch from this JIRA issue and used jvisualvm to verify that this indeed does solve our pagination leak using the HelloPagination app. Could you please give this a review? Thanks. --morris BUG - https://javafx-jira.kenai/browse/RT-38058 WEBREV - http://javaweb.us.oracle.com/~mameyer/webrevs/01/RT-38058
Re: [8u40] Review request for RT-38058: Pagination leak
Here is an open webrev: WEBREV - http://cr.openjdk.java.net/~morris/RT-38058.01 On 10/6/14, 2:50 PM, Morris Meyer wrote: Jonathan, I've pulled out the following patch from this JIRA issue and used jvisualvm to verify that this indeed does solve our pagination leak using the HelloPagination app. Could you please give this a review? Thanks. --morris BUG - https://javafx-jira.kenai/browse/RT-38058 WEBREV - http://javaweb.us.oracle.com/~mameyer/webrevs/01/RT-38058
javapackager native windows bundle non empty app.classpath (package.cfg)
Hoping to address my question to the appropriate list...
Is it possible to use the javapackager (ant-tasks) to create a Windows exe and
having the app.classpath property of package.cfg populated? I use something
like this:
fx:deploy nativeBundles=all outdir=${basedir}/${dist.dir}
outfile=${application.title} verbose=true width=600 height=400
fx:application name=${application.name}
mainClass=${javafx.main.class}/
fx:resources
!-- include dependencies copied by the maven-dependency-plugin --
fx:fileset dir=target/dependency includes=*.jar type=jar/
/fx:resources
fx:info title=${application.title} category=${application.group}
vendor=${application.vendor} copyright=${application.copyright}
fx:icon href=${application.icon}/
/fx:info
/fx:deploy
The directory target/dependency contains several jar files (which by the way
end up properly in the generated JNLP file) but only the jar file of the main
class is references in the package.cfg inside
native/bundles/${application.title}/app/package.cfg:
app.mainjar=app-1.0-SNAPSHOT.jar
app.version=1.0
app.id=org.example.demo.app
app.preferences.id=org/example/demo/app
app.mainclass= org/example/demo/app/DemoApp
app.classpath=
In the source code of
java/com/sun/javafx/tools/packager/bundlers/WinAppBundler.java I found the
following comment:
private void writePkgInfo(MapString, ? super Object params, File
pkgInfoFile) throws FileNotFoundException {
[...]
//This will be emtry string for correctly packaged JavaFX apps
out.println(app.classpath= + MAIN_JAR_CLASSPATH.fetchFrom(params));
[...]
}
So it seems that having a classpath with fx:deploy besides the main JAR is
not possible/wanted.
Thanks in advance,
Stefan
Review for RT-38725
Kevin, Stephen, and anyone running Mac OSX 10.8 (Mountain Lion) with XCode 5.1.1 This patch should get the new launcher building on 10.7, 10.8, and 10.9 (and 10.10 maybe when it is released). However, we don't have anyone running Mountain Lion and/or XCode 5.1.1. The XCode issue is the more imprtaint one since JDK 9 appears to be moving to 5.1.1/clang on a 10.9 build machine, possibly with 10.8 SDK. Is there anyone on this list running either Mountain Lion or XCode 5.1.1 that could test this theory out? It's verified on 10.7.5 with XCode 4.5 and 10.9.5 with XCode 6 with either the 10.7 or 10.9 sdk. WebRev: http://cr.openjdk.java.net/~shemnon/RT-38725/webrev.00/ JIRA: https://javafx-jira.kenai.com/browse/RT-38725
Re: Problems with gradle
Can you elaborate? -- Kevin
Re: javapackager native windows bundle non empty app.classpath (package.cfg)
This looks to be a bug. Can you post what version of the jdk you are using?
Also, can you post a JIRA for this at javafx-jira.kenai.com?
On Oct 6, 2014, at 2:13 PM, Stefan Kreutter openjfx-...@kreutter.de wrote:
Hoping to address my question to the appropriate list...
Is it possible to use the javapackager (ant-tasks) to create a Windows exe
and having the app.classpath property of package.cfg populated? I use
something like this:
fx:deploy nativeBundles=all outdir=${basedir}/${dist.dir}
outfile=${application.title} verbose=true width=600 height=400
fx:application name=${application.name}
mainClass=${javafx.main.class}/
fx:resources
!-- include dependencies copied by the maven-dependency-plugin --
fx:fileset dir=target/dependency includes=*.jar type=jar/
/fx:resources
fx:info title=${application.title} category=${application.group}
vendor=${application.vendor} copyright=${application.copyright}
fx:icon href=${application.icon}/
/fx:info
/fx:deploy
The directory target/dependency contains several jar files (which by the way
end up properly in the generated JNLP file) but only the jar file of the main
class is references in the package.cfg inside
native/bundles/${application.title}/app/package.cfg:
app.mainjar=app-1.0-SNAPSHOT.jar
app.version=1.0
app.id=org.example.demo.app
app.preferences.id=org/example/demo/app
app.mainclass= org/example/demo/app/DemoApp
app.classpath=
In the source code of
java/com/sun/javafx/tools/packager/bundlers/WinAppBundler.java I found the
following comment:
private void writePkgInfo(MapString, ? super Object params, File
pkgInfoFile) throws FileNotFoundException {
[...]
//This will be emtry string for correctly packaged JavaFX apps
out.println(app.classpath= + MAIN_JAR_CLASSPATH.fetchFrom(params));
[...]
}
So it seems that having a classpath with fx:deploy besides the main JAR is
not possible/wanted.
Thanks in advance,
Stefan
