[9] Review request for 8130381 - KeyEvents lost when focused node is removed from the Scene

2016-02-16 Thread Elina Kleyman Matok
Chien, Kevin, guys, Please review fix for next issue: JIRA: https://bugs.openjdk.java.net/browse/JDK-8130381 WEBREV: http://cr.openjdk.java.net/~ekleyman/8130381/ Thanks, Elina

please review: refactor test launchers to make common the building of the command

2016-02-16 Thread David Hill
Kevin, could you please review: webrev: http://cr.openjdk.java.net/~ddhill/8147427 bug: https://bugs.openjdk.java.net/browse/JDK-8147427 -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." --

Traversal sub-system

2016-02-16 Thread Hervé Girod
Hello, I'm sure this has already been answered before in this list, but is it planned to move the existing traversal sub-system (focus system) to a public API for JDK 9? Hervé Sent from my iPad

Re: Traversal sub-system

2016-02-16 Thread Jonathan Giles
Yes, it is something that Leif is exploring for JDK 9. It is not a hard commitment, but is something we are trying to get into JDK 9. See here: https://bugs.openjdk.java.net/browse/JDK-8091673 -- Jonathan On 17/02/16 11:10 AM, Hervé Girod wrote: Hello, I'm sure this has already been answered

Re: [Review request] 8088853: Applying dashed border to separator makes whole application hang

2016-02-16 Thread Jim Graham
[I believe you sent this to the wrong mailing list - the "-request" list is for changing your membership to the mailing list, not for sending mail to the list itself. I fixed it here in my reply...] That looks fine. I'll note that the "dashCumulative" variable does not need to be computed

Re: Traversal sub-system

2016-02-16 Thread Herve Girod
Thanks for the information! 2/16 11:10 AM, Hervé Girod wrote: > >> Hello, I'm sure this has already been answered before in this list, but >> is it planned to move the existing traversal sub-system (focus system) to a >> public API for JDK 9? >> >> Hervé >> >> Sent from my iPad >> > >

[9] review request:

2016-02-16 Thread Kevin Rushforth
Jim and Alexander, Please review the following fix to allow JFXPanel to compile (and run) again on JDK 9. https://bugs.openjdk.java.net/browse/JDK-8149967 http://cr.openjdk.java.net/~kcr/8149967/webrev.00/ Note that I did not provide a fallback to the existing JDK 8 method, since we are

Re: [9] review request: 8149967: Cannot compile JFXPanel with JDK 9: SurfaceData::getDefaultScale not found

2016-02-16 Thread Kevin Rushforth
[resend with correct subject line] Jim and Alexander, Please review the following fix to allow JFXPanel to compile (and run) again on JDK 9. https://bugs.openjdk.java.net/browse/JDK-8149967 http://cr.openjdk.java.net/~kcr/8149967/webrev.00/ Note that I did not provide a fallback to the

Re: [9] review request: 8149967: Cannot compile JFXPanel with JDK 9: SurfaceData::getDefaultScale not found

2016-02-16 Thread Jim Graham
I added a comment on the bug about BC, but it sounds like you already considered it. I'm fine with this as is, but would push for moving to JDK9 ASAP... ...jim On 2/16/2016 3:49 PM, Kevin Rushforth wrote: [resend with correct subject line] Jim and Alexander, Please

Code Review Request For 8137252: JavaFX StackPane bounds not updated

2016-02-16 Thread Chien Yang
Hi Kevin and Jonathan, Please review the proposed fix and the detail of the fix is recorded in the JIRA: JIRA: https://bugs.openjdk.java.net/browse/JDK-8137252 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8137252/webrev.00/ Thanks, - Chien