Re: CFV: New OpenJFX Committer: Rajath Kamath

2018-03-29 Thread Phil Race
Vote: yes -phil.

HEADS-UP: Proposal to bump the minimum boot JDK for FX to JDK 10

2018-03-29 Thread Kevin Rushforth
As mentioned in another thread [1] we should update the minimum boot JDK used to build FX to 10, which will allow the use of JDK 10 langauge features, such as 'var', as well as JDK 10 APIs. It's also the right time to do this in general. I filed a new RFE [2] to track this and plan to send it

Re: JEP 286: Local-Variable Type Inference: Usage

2018-03-29 Thread Kevin Rushforth
I tend to agree, so I would prefer to see them used judiciously. The write-up by Stuart (referenced below) raised some good points about when to use them vs when you might not want to. -- Kevin Artem Ananiev wrote: On 2018/03/29 9:36, Kevin Rushforth wrote: As a prerequisite, we would

Re: JEP 286: Local-Variable Type Inference: Usage

2018-03-29 Thread Artem Ananiev
On 2018/03/29 9:36, Kevin Rushforth wrote: As a prerequisite, we would need to update the minimum boot JDK to JDK 10, which I was going to propose doing anyway -- it seems the right time now that JDK 10 is out. I have no objections to then allowing the use of 'var' in new code. Do any others

JDK-8200206: Adding an animation to more than one parent results in inconsistent state

2018-03-29 Thread Nir Lisker
Hello, Iv'e created bug https://bugs.openjdk.java.net/browse/JDK-8200206. The behavior was noticed back when writing missing documentation for Transition [1]. Please evaluate. Thanks, Nir [1] http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-January/021249.html

Re: CFV: New OpenJFX Committer: Rajath Kamath

2018-03-29 Thread Kevin Rushforth
I note that this vote is not valid. Only existing OpenJFX Project Committers are eligible to vote. Thanks. -- Kevin Shiv Kumar Ganesh wrote: VOTE: yes On Thu, Mar 29, 2018, 10:23 AM Arunprasad Rajkumar > wrote:

Re: [11] Review request: 8199841: Add gradle wrapper files to build

2018-03-29 Thread Johan Vos
Looks good. - Johan On Thu, Mar 29, 2018 at 6:40 PM Kevin Rushforth wrote: > Hi Johan, > > Please review the following to add gradle wrapper: > > https://bugs.openjdk.java.net/browse/JDK-8199841 > http://cr.openjdk.java.net/~kcr/8199841/webrev.00/ > > This is the

RE: CFV: New OpenJFX Committer: Rajath Kamath

2018-03-29 Thread Murali Billa
VOTE: YES > On 29-Mar-2018, at 10:12 PM, Kevin Rushforth > wrote: > > I hereby nominate Rajath Kamath [1] to OpenJFX Committer. > > Rajath is a member of JavaFX team at Oracle, who has contributed 17 > changesets [2][3] to OpenJFX. > > Votes are due by April 12,

Re: CFV: New OpenJFX Committer: Rajath Kamath

2018-03-29 Thread Shiv Kumar Ganesh
VOTE: yes On Thu, Mar 29, 2018, 10:23 AM Arunprasad Rajkumar < arunprasad.rajku...@oracle.com> wrote: > VOTE: Yes > > > On 29-Mar-2018, at 10:12 PM, Kevin Rushforth > wrote: > > > > I hereby nominate Rajath Kamath [1] to OpenJFX Committer. > > > > Rajath is a member

Re: CFV: New OpenJFX Committer: Rajath Kamath

2018-03-29 Thread Arunprasad Rajkumar
VOTE: Yes > On 29-Mar-2018, at 10:12 PM, Kevin Rushforth > wrote: > > I hereby nominate Rajath Kamath [1] to OpenJFX Committer. > > Rajath is a member of JavaFX team at Oracle, who has contributed 17 > changesets [2][3] to OpenJFX. > > Votes are due by April 12,

Re: CFV: New OpenJFX Committer: Rajath Kamath

2018-03-29 Thread Kevin Rushforth
Vote: YES Kevin Rushforth wrote: I hereby nominate Rajath Kamath [1] to OpenJFX Committer. Rajath is a member of JavaFX team at Oracle, who has contributed 17 changesets [2][3] to OpenJFX. Votes are due by April 12, 2018. Only current OpenJFX Committers [4] are eligible to vote on this

CFV: New OpenJFX Committer: Rajath Kamath

2018-03-29 Thread Kevin Rushforth
I hereby nominate Rajath Kamath [1] to OpenJFX Committer. Rajath is a member of JavaFX team at Oracle, who has contributed 17 changesets [2][3] to OpenJFX. Votes are due by April 12, 2018. Only current OpenJFX Committers [4] are eligible to vote on this nomination. Votes must be cast in the

[11] Review request: 8199841: Add gradle wrapper files to build

2018-03-29 Thread Kevin Rushforth
Hi Johan, Please review the following to add gradle wrapper: https://bugs.openjdk.java.net/browse/JDK-8199841 http://cr.openjdk.java.net/~kcr/8199841/webrev.00/ This is the aggregation of two changesets pushed to the github mirror:

Re: JEP 286: Local-Variable Type Inference: Usage

2018-03-29 Thread Kevin Rushforth
As a prerequisite, we would need to update the minimum boot JDK to JDK 10, which I was going to propose doing anyway -- it seems the right time now that JDK 10 is out. I have no objections to then allowing the use of 'var' in new code. Do any others have any concerns? -- Kevin Nir Lisker

JEP 286: Local-Variable Type Inference: Usage

2018-03-29 Thread Nir Lisker
Hello, A style guide for usage of 'var' has been published at http://openjdk.java.net/projects/amber/LVTIstyle.html. Can we start using this feature in contributions to OpenJFX? - Nir

Re: OpenJFX GitHub mirror

2018-03-29 Thread Nir Lisker
I think that the labels should be succinct, so one label should suffice. Either github-link or github-bug are fine for me, the latter because there is webbug label already. If a PR needs review just use the review-request existing label. As for issues and PRs, the issue links section in the JIRA

Re: OpenJFX GitHub mirror

2018-03-29 Thread Tom Schindl
well could we have 2: * github-issue * github-pr The first one indicates someone is working on it over at github, whereas the second means there's a PR that needs to be review. Tom On 29.03.18 08:42, Laurent Bourgès wrote: > Hi, > > As such github references point to either issue or PR, I

Re: OpenJFX GitHub mirror

2018-03-29 Thread Laurent Bourgès
Hi, As such github references point to either issue or PR, I recommend using the term 'github-link'. Laurent Le jeu. 29 mars 2018 à 03:40, Kevin Rushforth a écrit : > I think this would be fine. We would want something that didn't conflict > with anything else and