Re: CFV: New OpenJFX Committer: Rajath Kamath

[Phil Race]

Vote: yes

-phil.

HEADS-UP: Proposal to bump the minimum boot JDK for FX to JDK 10

[Kevin Rushforth]

As mentioned in another thread [1] we should update the minimum boot JDK 
used to build FX to 10, which will allow the use of JDK 10 langauge 
features, such as 'var', as well as JDK 10 APIs. It's also the right 
time to do this in general. I filed a new RFE [2] to track this and plan 
to send it out for review next week.


Please let me know if there are any concerns. We already use JDK 10 to 
build FX 11 ea bits. I presume that the travis and appveyor CI builds of 
the github mirror do the same?


-- Kevin

[1] 
http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-March/021671.html


[2] https://bugs.openjdk.java.net/browse/JDK-8200446

Re: JEP 286: Local-Variable Type Inference: Usage

[Kevin Rushforth]

I tend to agree, so I would prefer to see them used judiciously. The 
write-up by Stuart (referenced below) raised some good points about when 
to use them vs when you might not want to.


-- Kevin


Artem Ananiev wrote:


On 2018/03/29 9:36, Kevin Rushforth wrote:

As a prerequisite, we would need to update the minimum boot JDK to JDK
10, which I was going to propose doing anyway -- it seems the right time
now that JDK 10 is out.

I have no objections to then allowing the use of 'var' in new code.

Do any others have any concerns?


My personal experience with "var"s - they are used a lot in Scala, for 
example - is they make code very unreadable, especially when working 
with collections and streams. The only case when a "var" is suitable 
is new object creation:


var object = new SomeType()

In all other cases they are more painful than valuable.

I can say it differently. It's very easy to use "var"s wrong. No 
matter what style guides are available, people will often use them in 
a way that makes code less readable.


Just my $0.02

Thanks,

Artem


-- Kevin


Nir Lisker wrote:

Hello,

A style guide for usage of 'var' has been published at
http://openjdk.java.net/projects/amber/LVTIstyle.html. Can we start 
using

this feature in contributions to OpenJFX?

- Nir

Re: JEP 286: Local-Variable Type Inference: Usage

[Artem Ananiev]

On 2018/03/29 9:36, Kevin Rushforth wrote:

As a prerequisite, we would need to update the minimum boot JDK to JDK
10, which I was going to propose doing anyway -- it seems the right time
now that JDK 10 is out.

I have no objections to then allowing the use of 'var' in new code.

Do any others have any concerns?


My personal experience with "var"s - they are used a lot in Scala, for 
example - is they make code very unreadable, especially when working 
with collections and streams. The only case when a "var" is suitable is 
new object creation:


var object = new SomeType()

In all other cases they are more painful than valuable.

I can say it differently. It's very easy to use "var"s wrong. No matter 
what style guides are available, people will often use them in a way 
that makes code less readable.


Just my $0.02

Thanks,

Artem


-- Kevin


Nir Lisker wrote:

Hello,

A style guide for usage of 'var' has been published at
http://openjdk.java.net/projects/amber/LVTIstyle.html. Can we start using
this feature in contributions to OpenJFX?

- Nir

JDK-8200206: Adding an animation to more than one parent results in inconsistent state

[Nir Lisker]

Hello,

Iv'e created bug https://bugs.openjdk.java.net/browse/JDK-8200206. The
behavior was noticed back when writing missing documentation for Transition
[1]. Please evaluate.

Thanks,
Nir

[1]
http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-January/021249.html

Re: CFV: New OpenJFX Committer: Rajath Kamath

[Kevin Rushforth]

I note that this vote is not valid. Only existing OpenJFX Project 
Committers are eligible to vote.


Thanks.

-- Kevin


Shiv Kumar Ganesh wrote:

VOTE: yes

On Thu, Mar 29, 2018, 10:23 AM Arunprasad Rajkumar 
> wrote:


VOTE: Yes

> On 29-Mar-2018, at 10:12 PM, Kevin Rushforth
>
wrote:
>
> I hereby nominate Rajath Kamath [1] to OpenJFX Committer.
>
> Rajath is a member of JavaFX team at Oracle, who has contributed
17 changesets [2][3] to OpenJFX.
>
> Votes are due by April 12, 2018.
>
> Only current OpenJFX Committers [4] are eligible to vote on this
nomination. Votes must be cast in the open by replying to this
mailing list.
>
> For Lazy Consensus voting instructions, see [5]. Nomination to a
project Committer is described in [6].
>
> By way of background, an earlier nomination failed [7]. Since
then, Rajath has contributed 2 more test fixes and 1 more product fix.
>
> Thanks.
>
> -- Kevin
>
> [1] http://openjdk.java.net/census#rkamath
>
> [2]

http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?revcount=20=author%28rkamath%29


> [3]

http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?revcount=20=rajath.kamath


>
> [4] http://openjdk.java.net/census#openjfx
>
> [5] http://openjdk.java.net/bylaws#lazy-consensus
>
> [6] http://openjdk.java.net/projects#project-committer
>
> [7]
http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-February/021499.html
>

Re: [11] Review request: 8199841: Add gradle wrapper files to build

[Johan Vos]

Looks good.

- Johan

On Thu, Mar 29, 2018 at 6:40 PM Kevin Rushforth 
wrote:

> Hi Johan,
>
> Please review the following to add gradle wrapper:
>
> https://bugs.openjdk.java.net/browse/JDK-8199841
> http://cr.openjdk.java.net/~kcr/8199841/webrev.00/
>
> This is the aggregation of two changesets pushed to the github mirror:
>
>
> https://github.com/javafxports/openjdk-jfx/commit/7ff32048e62e7338ed6e2142ca0887b1ebc8aaa7
>
> https://github.com/javafxports/openjdk-jfx/commit/5bb8f3f25d31af37dedb040da7e4cd3c91a31919
>
> so there should be no merge conflict. It includes the associated
> third-party legal file.
>
> -- Kevin
>
>

RE: CFV: New OpenJFX Committer: Rajath Kamath

[Murali Billa]

VOTE: YES


> On 29-Mar-2018, at 10:12 PM, Kevin Rushforth  
> wrote:
> 
> I hereby nominate Rajath Kamath [1] to OpenJFX Committer.
> 
> Rajath is a member of JavaFX team at Oracle, who has contributed 17 
> changesets [2][3] to OpenJFX.
> 
> Votes are due by April 12, 2018.
> 
> Only current OpenJFX Committers [4] are eligible to vote on this nomination. 
> Votes must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [5]. Nomination to a project 
> Committer is described in [6].
> 
> By way of background, an earlier nomination failed [7]. Since then, Rajath 
> has contributed 2 more test fixes and 1 more product fix.
> 
> Thanks.
> 
> -- Kevin
> 
> [1] http://openjdk.java.net/census#rkamath
> 
> [2] 
> http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?revcount=20=auth
> or%28rkamath%29 [3] 
> http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?revcount=20=raja
> th.kamath
> 
> [4] http://openjdk.java.net/census#openjfx
> 
> [5] http://openjdk.java.net/bylaws#lazy-consensus
> 
> [6] http://openjdk.java.net/projects#project-committer
> 
> [7] 
> http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-February/02149
> 9.html
> 

Re: CFV: New OpenJFX Committer: Rajath Kamath

[Shiv Kumar Ganesh]

VOTE: yes

On Thu, Mar 29, 2018, 10:23 AM Arunprasad Rajkumar <
arunprasad.rajku...@oracle.com> wrote:

> VOTE: Yes
>
> > On 29-Mar-2018, at 10:12 PM, Kevin Rushforth 
> wrote:
> >
> > I hereby nominate Rajath Kamath [1] to OpenJFX Committer.
> >
> > Rajath is a member of JavaFX team at Oracle, who has contributed 17
> changesets [2][3] to OpenJFX.
> >
> > Votes are due by April 12, 2018.
> >
> > Only current OpenJFX Committers [4] are eligible to vote on this
> nomination. Votes must be cast in the open by replying to this mailing list.
> >
> > For Lazy Consensus voting instructions, see [5]. Nomination to a project
> Committer is described in [6].
> >
> > By way of background, an earlier nomination failed [7]. Since then,
> Rajath has contributed 2 more test fixes and 1 more product fix.
> >
> > Thanks.
> >
> > -- Kevin
> >
> > [1] http://openjdk.java.net/census#rkamath
> >
> > [2]
> http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?revcount=20=author%28rkamath%29
> > [3]
> http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?revcount=20=rajath.kamath
> >
> > [4] http://openjdk.java.net/census#openjfx
> >
> > [5] http://openjdk.java.net/bylaws#lazy-consensus
> >
> > [6] http://openjdk.java.net/projects#project-committer
> >
> > [7]
> http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-February/021499.html
> >
>
>

Re: CFV: New OpenJFX Committer: Rajath Kamath

[Arunprasad Rajkumar]

VOTE: Yes

> On 29-Mar-2018, at 10:12 PM, Kevin Rushforth  
> wrote:
> 
> I hereby nominate Rajath Kamath [1] to OpenJFX Committer.
> 
> Rajath is a member of JavaFX team at Oracle, who has contributed 17 
> changesets [2][3] to OpenJFX.
> 
> Votes are due by April 12, 2018.
> 
> Only current OpenJFX Committers [4] are eligible to vote on this nomination. 
> Votes must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [5]. Nomination to a project 
> Committer is described in [6].
> 
> By way of background, an earlier nomination failed [7]. Since then, Rajath 
> has contributed 2 more test fixes and 1 more product fix.
> 
> Thanks.
> 
> -- Kevin
> 
> [1] http://openjdk.java.net/census#rkamath
> 
> [2] 
> http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?revcount=20=author%28rkamath%29
> [3] 
> http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?revcount=20=rajath.kamath
> 
> [4] http://openjdk.java.net/census#openjfx
> 
> [5] http://openjdk.java.net/bylaws#lazy-consensus
> 
> [6] http://openjdk.java.net/projects#project-committer
> 
> [7] 
> http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-February/021499.html
> 

Re: CFV: New OpenJFX Committer: Rajath Kamath

[Kevin Rushforth]

Vote: YES


Kevin Rushforth wrote:

I hereby nominate Rajath Kamath [1] to OpenJFX Committer.

Rajath is a member of JavaFX team at Oracle, who has contributed 17 
changesets [2][3] to OpenJFX.


Votes are due by April 12, 2018.

Only current OpenJFX Committers [4] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [5]. Nomination to a 
project Committer is described in [6].


By way of background, an earlier nomination failed [7]. Since then, 
Rajath has contributed 2 more test fixes and 1 more product fix.


Thanks.

-- Kevin

[1] http://openjdk.java.net/census#rkamath

[2] 
http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?revcount=20=author%28rkamath%29 

[3] 
http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?revcount=20=rajath.kamath 



[4] http://openjdk.java.net/census#openjfx

[5] http://openjdk.java.net/bylaws#lazy-consensus

[6] http://openjdk.java.net/projects#project-committer

[7] 
http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-February/021499.html 

CFV: New OpenJFX Committer: Rajath Kamath

[Kevin Rushforth]

I hereby nominate Rajath Kamath [1] to OpenJFX Committer.

Rajath is a member of JavaFX team at Oracle, who has contributed 17 
changesets [2][3] to OpenJFX.


Votes are due by April 12, 2018.

Only current OpenJFX Committers [4] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing list.


For Lazy Consensus voting instructions, see [5]. Nomination to a project 
Committer is described in [6].


By way of background, an earlier nomination failed [7]. Since then, 
Rajath has contributed 2 more test fixes and 1 more product fix.


Thanks.

-- Kevin

[1] http://openjdk.java.net/census#rkamath

[2] 
http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?revcount=20=author%28rkamath%29
[3] 
http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?revcount=20=rajath.kamath


[4] http://openjdk.java.net/census#openjfx

[5] http://openjdk.java.net/bylaws#lazy-consensus

[6] http://openjdk.java.net/projects#project-committer

[7] 
http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-February/021499.html

[11] Review request: 8199841: Add gradle wrapper files to build

[Kevin Rushforth]

Hi Johan,

Please review the following to add gradle wrapper:

https://bugs.openjdk.java.net/browse/JDK-8199841
http://cr.openjdk.java.net/~kcr/8199841/webrev.00/

This is the aggregation of two changesets pushed to the github mirror:

https://github.com/javafxports/openjdk-jfx/commit/7ff32048e62e7338ed6e2142ca0887b1ebc8aaa7
https://github.com/javafxports/openjdk-jfx/commit/5bb8f3f25d31af37dedb040da7e4cd3c91a31919

so there should be no merge conflict. It includes the associated 
third-party legal file.


-- Kevin

Re: JEP 286: Local-Variable Type Inference: Usage

[Kevin Rushforth]

As a prerequisite, we would need to update the minimum boot JDK to JDK 
10, which I was going to propose doing anyway -- it seems the right time 
now that JDK 10 is out.


I have no objections to then allowing the use of 'var' in new code.

Do any others have any concerns?

-- Kevin


Nir Lisker wrote:

Hello,

A style guide for usage of 'var' has been published at
http://openjdk.java.net/projects/amber/LVTIstyle.html. Can we start using
this feature in contributions to OpenJFX?

- Nir
  

JEP 286: Local-Variable Type Inference: Usage

[Nir Lisker]

Hello,

A style guide for usage of 'var' has been published at
http://openjdk.java.net/projects/amber/LVTIstyle.html. Can we start using
this feature in contributions to OpenJFX?

- Nir

Re: OpenJFX GitHub mirror

[Nir Lisker]

I think that the labels should be succinct, so one label should suffice.
Either github-link or github-bug are fine for me, the latter because there
is webbug label already. If a PR needs review just use the review-request
existing label.

As for issues and PRs, the issue links section in the JIRA ticket could
reflect what exists in GitHub, so there can be 2 web links named "GitHub
issue" and "GitHub PR" if need be.

- Nir

On Thu, Mar 29, 2018 at 10:08 AM, Tom Schindl 
wrote:

> well could we have 2:
> * github-issue
> * github-pr
>
> The first one indicates someone is working on it over at github, whereas
> the second means there's a PR that needs to be review.
>
> Tom
>
> On 29.03.18 08:42, Laurent Bourgès wrote:
> > Hi,
> >
> > As such github references point to either issue or PR, I recommend using
> > the term 'github-link'.
> >
> > Laurent
> >
> > Le jeu. 29 mars 2018 à 03:40, Kevin Rushforth <
> kevin.rushfo...@oracle.com>
> > a écrit :
> >
> >> I think this would be fine. We would want something that didn't conflict
> >> with anything else and wasn't confusing. Possible choices:
> >>
> >> github-link
> >> github-bug
> >> gitbug-issue
> >>
> >> Any preferences?
> >>
> >> -- Kevin
> >>
> >>
> >> Nir Lisker wrote:
> >>> Kevin, can we get a label for this?
> >>>
> >>> - Nir
> >>>
> >>> On Mon, Mar 26, 2018 at 4:37 PM, Johan Vos 
> >> wrote:
> >>>
> >>>
>  Hi Nir,
> 
>  About 4. (jfx-dev): you're right, I just removed that repository. That
> >> was
>  just some testing before we did the real thing.
> 
>  As for the other points: I agree
> 
>  - Johan
> 
>  On Mon, Mar 26, 2018 at 12:03 PM Nir Lisker 
> wrote:
> 
> 
> > Hi All,
> >
> > A few comments about the mirror and JBS:
> >
> > 1. In PRs and issues on GitHub, I strongly suggest that the link to
> >> JBS be
> > included in the top comment. If the JBS issue was created after a
> > discussion, edit it in.
> >
> > 2. In JBS, I suggest to link to the GitHub mirror via More > Link >
> Web
> > Link and in the Link Text use something like "GitHub mirror" (open
> for
> > suggestions). JIRA renders the link in an easy to see way (easier
> than
> > looking at URLs). Iv'e tried it in a couple of issues, e.g.,
> > https://bugs.openjdk.java.net/browse/JDK-8198795 and it seems
> >> preferable
> > to
> > me.
> >
> > 3. In JBS, I suggest a new label will be used for issues which are
> >> linked
> > to GitHub for search purposes. This is similar to the webbug label.
> >
> > If these are agreeable, please add them to the contribution
> >> instructions.
> >
> > 4. What is https://github.com/javafxports/jfx-dev? Newcomers can
> >> confuse
> > it
> > with javafxports/openjdk-jfx.
> >
> > 5. When the mirror is fully ready and operational, we should
> advertise
> >> on
> > community pages (like Reddit) to gather up contributors. Please keep
> a
> > mental reminder when the time comes.
> >
> > Thanks to all who are working on this.
> >
> > - Nir
> >
> >
> >>
>

Re: OpenJFX GitHub mirror

[Tom Schindl]

well could we have 2:
* github-issue
* github-pr

The first one indicates someone is working on it over at github, whereas
the second means there's a PR that needs to be review.

Tom

On 29.03.18 08:42, Laurent Bourgès wrote:
> Hi,
> 
> As such github references point to either issue or PR, I recommend using
> the term 'github-link'.
> 
> Laurent
> 
> Le jeu. 29 mars 2018 à 03:40, Kevin Rushforth 
> a écrit :
> 
>> I think this would be fine. We would want something that didn't conflict
>> with anything else and wasn't confusing. Possible choices:
>>
>> github-link
>> github-bug
>> gitbug-issue
>>
>> Any preferences?
>>
>> -- Kevin
>>
>>
>> Nir Lisker wrote:
>>> Kevin, can we get a label for this?
>>>
>>> - Nir
>>>
>>> On Mon, Mar 26, 2018 at 4:37 PM, Johan Vos 
>> wrote:
>>>
>>>
 Hi Nir,

 About 4. (jfx-dev): you're right, I just removed that repository. That
>> was
 just some testing before we did the real thing.

 As for the other points: I agree

 - Johan

 On Mon, Mar 26, 2018 at 12:03 PM Nir Lisker  wrote:


> Hi All,
>
> A few comments about the mirror and JBS:
>
> 1. In PRs and issues on GitHub, I strongly suggest that the link to
>> JBS be
> included in the top comment. If the JBS issue was created after a
> discussion, edit it in.
>
> 2. In JBS, I suggest to link to the GitHub mirror via More > Link > Web
> Link and in the Link Text use something like "GitHub mirror" (open for
> suggestions). JIRA renders the link in an easy to see way (easier than
> looking at URLs). Iv'e tried it in a couple of issues, e.g.,
> https://bugs.openjdk.java.net/browse/JDK-8198795 and it seems
>> preferable
> to
> me.
>
> 3. In JBS, I suggest a new label will be used for issues which are
>> linked
> to GitHub for search purposes. This is similar to the webbug label.
>
> If these are agreeable, please add them to the contribution
>> instructions.
>
> 4. What is https://github.com/javafxports/jfx-dev? Newcomers can
>> confuse
> it
> with javafxports/openjdk-jfx.
>
> 5. When the mirror is fully ready and operational, we should advertise
>> on
> community pages (like Reddit) to gather up contributors. Please keep a
> mental reminder when the time comes.
>
> Thanks to all who are working on this.
>
> - Nir
>
>
>>

Re: OpenJFX GitHub mirror

[Laurent Bourgès]

Hi,

As such github references point to either issue or PR, I recommend using
the term 'github-link'.

Laurent

Le jeu. 29 mars 2018 à 03:40, Kevin Rushforth 
a écrit :

> I think this would be fine. We would want something that didn't conflict
> with anything else and wasn't confusing. Possible choices:
>
> github-link
> github-bug
> gitbug-issue
>
> Any preferences?
>
> -- Kevin
>
>
> Nir Lisker wrote:
> > Kevin, can we get a label for this?
> >
> > - Nir
> >
> > On Mon, Mar 26, 2018 at 4:37 PM, Johan Vos 
> wrote:
> >
> >
> >> Hi Nir,
> >>
> >> About 4. (jfx-dev): you're right, I just removed that repository. That
> was
> >> just some testing before we did the real thing.
> >>
> >> As for the other points: I agree
> >>
> >> - Johan
> >>
> >> On Mon, Mar 26, 2018 at 12:03 PM Nir Lisker  wrote:
> >>
> >>
> >>> Hi All,
> >>>
> >>> A few comments about the mirror and JBS:
> >>>
> >>> 1. In PRs and issues on GitHub, I strongly suggest that the link to
> JBS be
> >>> included in the top comment. If the JBS issue was created after a
> >>> discussion, edit it in.
> >>>
> >>> 2. In JBS, I suggest to link to the GitHub mirror via More > Link > Web
> >>> Link and in the Link Text use something like "GitHub mirror" (open for
> >>> suggestions). JIRA renders the link in an easy to see way (easier than
> >>> looking at URLs). Iv'e tried it in a couple of issues, e.g.,
> >>> https://bugs.openjdk.java.net/browse/JDK-8198795 and it seems
> preferable
> >>> to
> >>> me.
> >>>
> >>> 3. In JBS, I suggest a new label will be used for issues which are
> linked
> >>> to GitHub for search purposes. This is similar to the webbug label.
> >>>
> >>> If these are agreeable, please add them to the contribution
> instructions.
> >>>
> >>> 4. What is https://github.com/javafxports/jfx-dev? Newcomers can
> confuse
> >>> it
> >>> with javafxports/openjdk-jfx.
> >>>
> >>> 5. When the mirror is fully ready and operational, we should advertise
> on
> >>> community pages (like Reddit) to gather up contributors. Please keep a
> >>> mental reminder when the time comes.
> >>>
> >>> Thanks to all who are working on this.
> >>>
> >>> - Nir
> >>>
> >>>
>