Re: JavaFX and it use of GTK3

2018-06-20 Thread Sverre Moe
> > What does GTK have to say for JavaFX (disregard any AWT/Swing and SWT) ?
>
> FX is not a GTK app from a rendering perspective.
> It is used for all needed interaction with the Windowing System

Makes sense. For GUI components such as the FileChooser.
The FileChooser in JavaFX is using the system GTK theme, regardless of
Modena or any other configured styling.

> > Does it mean JavaFX supports GTK3 themes? If one have selected a
> > desktop GTK theme could it be used in the JavaFX application for
> > styling?
> No .. and no.

I was wondering because I know Eclipse have been effected in the past
by my installed GTK themes.
To be able to utilize the GTK theme would have helped to keep theme
consistent. Since dialogs such as FileChooser are using the GTK theme.

> > Has Qt ever been a consideration for JavaFX instead of GTK?
>
> No.
Why not? Would it be difficult to implement an Qt alternative for GTK
in Java? If it is even feasible.

In effect it means JavaFX will not work on systems that doesn't have
GTK installed, though OpenJDK have no install requirement on GTK.
I am running KDE which uses Qt, and apart from a very few applications
I have very little reliance on GTK.


Re: Table Input

2018-06-20 Thread José Pereda
As Daniel points out, the TableView2 control is a Gluon contribution that
has been merged recently to ControlsFX, but it hasn't been released yet.
Actually there is a pending PR to rename the new control to
FixableTableView.

Regarding commit on focus, it has been implemented in two new table cell
factories, for TextField and ComboBox cells [2].

You can use the snapshot to test it, and of course, you can clone the
repository, there are two samples [1] available.

Jose


[1]
https://bitbucket.org/controlsfx/controlsfx/src/default/controlsfx-samples/src/main/java/org/controlsfx/samples/tableview2
[2]
https://bitbucket.org/controlsfx/controlsfx/src/default/controlsfx/src/main/java/org/controlsfx/control/tableview2/cell/TextField2TableCell.java


On Wed, Jun 20, 2018 at 7:06 PM, Daniel Peintner 
wrote:

> Hi,
>
> > I believe the last time I looked at the TableView2 contribution at
> > > ControlsFX (which can be used as a TableView replacement), commit on
> > focus
> > > lost was implemented/supported.
> > Do you have a link?
> >
>
> The PR has been merged but the contribution is not yet available as
> ControlsFX release.
> Note: I think the credits go to Jose Pereda (Gluon?)
>
> The easist way to test it is using jpro demo [1] where you can find a
> TableView2 section.
>
> Having said that, I don't actually know how it is implemented. I just
> noticed commit on focus lost support while playing with this demo.
>
> -- Daniel
>
> [1] https://demos.jpro.one/controlsfx.html
>
>
>
> >  seems to not have it.
> >
> > ---rony
> >
> > > Jonathan Giles  schrieb am Mi., 20. Juni
> > 2018,
> > > 10:28:
> > >
> > >> Yup,
> > >>
> > >> A great regret. I wish it were supported, but it isn't due to
> historical
> > >> legacy. There are some small ways you can make some progress, e.g. add
> > >> focus listeners on the editor node, but they are half solutions at
> best.
> > >>
> > >> -- Jonathan
> > >> (Tapped on a touch device)
> > >>
> > >> On Wed, 20 Jun 2018, 10:25 AM ,  wrote:
> > >>
> > >>> Zitat von Tom Eugelink :
> > >>>
> >  This is a well known and already deeply discussed issue. I'm still
> >  not sure where we are with it, but Jonathan knows I believe.
> > 
> > 
> > >>> https://bugs.openjdk.java.net/browse/JDK-8089514
> > >>>
> > >>> tbd_major ... since nearly 7 years :(( actually, it took 4 years to
> > >>> get the necessity accepted, then another 2 years playing with
> > >>> incomplete suggested fixes and then ...
> > >>>
> > >>> It's a complex problem, requires
> > >>>
> > >>> a) additional commit/cancel api on the virtual controls to allow
> > >>> collaborators to cleanly terminate ongoing edits - this part has
> still
> > >>> been debated
> > >>> b) a major cleanup of cell implementations - this part was under way
> > >>> (and evolving into the good direction) until Jonathan left
> > >>>
> > >>>
> > >>> CU, Jeanette
> > >>>
> >  On 19-6-2018 20:53, Ty Young wrote:
> > > On 06/19/2018 10:51 AM, omnip...@gmail.com wrote:
> > >
> > >> A minor issue in the Table component existed in previous versions
> of
> > >>> JavaFX
> > >> when editing in a cell was turned on. Only if the Return key was
> > >> pressed was
> > >> the data entered into the backing bean. Leaving the cell with Tab
> or
> > >> by
> > >> mouse did not register the change. I thought just when a cell
> looses
> > >>> focus
> > >> it should trigger updating the bean. I have not looked at the
> recent
> > >>> builds
> > >> but I thought I'd ask if it has come up on anyone's radar. I
> > >> noticed it when
> > >> I moved from teaching Swing to FX.
> > >>
> > >>
> > >> Ken Fogel
> > >>
> > >>
> > >>
> > > IIRC, this isn't specific to Table. A spinner with editing enabled
> > > also does this and it breaks events(onKeyTyped does nothing).
> >
> >
>



--


Re: JavaFX and it use of GTK3

2018-06-20 Thread Phil Race

J

On 06/20/2018 12:21 PM, Sverre Moe wrote:

Pardon me for asking this on the dev mailing list, but I wanted to get
this directly from the source.

I was glad to read that Java had gotten support for GTK3. Prior to
this I was oblivious with JavaFX relationship with GTK, apart from the
various Gtk-WARNING when starting applications. Then I began to
ponder, what does GTK do for JavaFX.

What does GTK have to say for JavaFX (disregard any AWT/Swing and SWT) ?


FX is not a GTK app from a rendering perspective.
It is used for all needed interaction with the Windowing System
and FX needs to co-exist with other libraries (eg SWT) using GTK3.


The JEP for GTK3 support mentioned the motivation for it:
* Active development is on GTK3 and GTK2 may not be available on Linux
in the future lifetime of JDK 9/10/11.
* Mixing of packages using different GTK versions causes application
failures. They mention this problem affects applications when using
Eclipse which are SWT-based. I tried running Eclipse with GTK3 enabled
without problem.

Other than that:
Does it provide better graphics with GTK3

No.

Does it provide different visual graphics with GTK3


No

Does it provide better performance with GTK3


Unlikely

Does it mean JavaFX supports GTK3 themes? If one have selected a
desktop GTK theme could it be used in the JavaFX application for
styling?

No .. and no.


Has Qt ever been a consideration for JavaFX instead of GTK?


No.

-phil.


JavaFX and it use of GTK3

2018-06-20 Thread Sverre Moe
Pardon me for asking this on the dev mailing list, but I wanted to get
this directly from the source.

I was glad to read that Java had gotten support for GTK3. Prior to
this I was oblivious with JavaFX relationship with GTK, apart from the
various Gtk-WARNING when starting applications. Then I began to
ponder, what does GTK do for JavaFX.

What does GTK have to say for JavaFX (disregard any AWT/Swing and SWT) ?

The JEP for GTK3 support mentioned the motivation for it:
* Active development is on GTK3 and GTK2 may not be available on Linux
in the future lifetime of JDK 9/10/11.
* Mixing of packages using different GTK versions causes application
failures. They mention this problem affects applications when using
Eclipse which are SWT-based. I tried running Eclipse with GTK3 enabled
without problem.

Other than that:
Does it provide better graphics with GTK3
Does it provide different visual graphics with GTK3
Does it provide better performance with GTK3

Does it mean JavaFX supports GTK3 themes? If one have selected a
desktop GTK theme could it be used in the JavaFX application for
styling?

Has Qt ever been a consideration for JavaFX instead of GTK?


Review-Request for JDK-8191661

2018-06-20 Thread Tom Schindl
Hi,

I'd like to request a review for the fix of JDK-8191661. The change is
at https://github.com/javafxports/openjdk-jfx/pull/100

Tom


Re: Table Input

2018-06-20 Thread Jonathan Giles
Yup,

A great regret. I wish it were supported, but it isn't due to historical
legacy. There are some small ways you can make some progress, e.g. add
focus listeners on the editor node, but they are half solutions at best.

-- Jonathan
(Tapped on a touch device)

On Wed, 20 Jun 2018, 10:25 AM ,  wrote:

>
> Zitat von Tom Eugelink :
>
> > This is a well known and already deeply discussed issue. I'm still
> > not sure where we are with it, but Jonathan knows I believe.
> >
> >
>
> https://bugs.openjdk.java.net/browse/JDK-8089514
>
> tbd_major ... since nearly 7 years :(( actually, it took 4 years to
> get the necessity accepted, then another 2 years playing with
> incomplete suggested fixes and then ...
>
> It's a complex problem, requires
>
> a) additional commit/cancel api on the virtual controls to allow
> collaborators to cleanly terminate ongoing edits - this part has still
> been debated
> b) a major cleanup of cell implementations - this part was under way
> (and evolving into the good direction) until Jonathan left
>
>
> CU, Jeanette
>
> > On 19-6-2018 20:53, Ty Young wrote:
> >> On 06/19/2018 10:51 AM, omnip...@gmail.com wrote:
> >>
> >>> A minor issue in the Table component existed in previous versions of
> JavaFX
> >>> when editing in a cell was turned on. Only if the Return key was
> >>> pressed was
> >>> the data entered into the backing bean. Leaving the cell with Tab or by
> >>> mouse did not register the change. I thought just when a cell looses
> focus
> >>> it should trigger updating the bean. I have not looked at the recent
> builds
> >>> but I thought I'd ask if it has come up on anyone's radar. I
> >>> noticed it when
> >>> I moved from teaching Swing to FX.
> >>>
> >>>
> >>> Ken Fogel
> >>>
> >>>
> >>>
> >>
> >> IIRC, this isn't specific to Table. A spinner with editing enabled
> >> also does this and it breaks events(onKeyTyped does nothing).
>
>
>
>


Re: Table Input

2018-06-20 Thread fastegal



Zitat von Tom Eugelink :

This is a well known and already deeply discussed issue. I'm still  
not sure where we are with it, but Jonathan knows I believe.





https://bugs.openjdk.java.net/browse/JDK-8089514

tbd_major ... since nearly 7 years :(( actually, it took 4 years to  
get the necessity accepted, then another 2 years playing with  
incomplete suggested fixes and then ...


It's a complex problem, requires

a) additional commit/cancel api on the virtual controls to allow  
collaborators to cleanly terminate ongoing edits - this part has still  
been debated
b) a major cleanup of cell implementations - this part was under way  
(and evolving into the good direction) until Jonathan left



CU, Jeanette


On 19-6-2018 20:53, Ty Young wrote:

On 06/19/2018 10:51 AM, omnip...@gmail.com wrote:


A minor issue in the Table component existed in previous versions of JavaFX
when editing in a cell was turned on. Only if the Return key was  
pressed was

the data entered into the backing bean. Leaving the cell with Tab or by
mouse did not register the change. I thought just when a cell looses focus
it should trigger updating the bean. I have not looked at the recent builds
but I thought I'd ask if it has come up on anyone's radar. I  
noticed it when

I moved from teaching Swing to FX.


Ken Fogel





IIRC, this isn't specific to Table. A spinner with editing enabled  
also does this and it breaks events(onKeyTyped does nothing).






Re: Table Input

2018-06-20 Thread Daniel Peintner
Hi,

> I believe the last time I looked at the TableView2 contribution at
> > ControlsFX (which can be used as a TableView replacement), commit on
> focus
> > lost was implemented/supported.
> Do you have a link?
>

The PR has been merged but the contribution is not yet available as
ControlsFX release.
Note: I think the credits go to Jose Pereda (Gluon?)

The easist way to test it is using jpro demo [1] where you can find a
TableView2 section.

Having said that, I don't actually know how it is implemented. I just
noticed commit on focus lost support while playing with this demo.

-- Daniel

[1] https://demos.jpro.one/controlsfx.html



>  seems to not have it.
>
> ---rony
>
> > Jonathan Giles  schrieb am Mi., 20. Juni
> 2018,
> > 10:28:
> >
> >> Yup,
> >>
> >> A great regret. I wish it were supported, but it isn't due to historical
> >> legacy. There are some small ways you can make some progress, e.g. add
> >> focus listeners on the editor node, but they are half solutions at best.
> >>
> >> -- Jonathan
> >> (Tapped on a touch device)
> >>
> >> On Wed, 20 Jun 2018, 10:25 AM ,  wrote:
> >>
> >>> Zitat von Tom Eugelink :
> >>>
>  This is a well known and already deeply discussed issue. I'm still
>  not sure where we are with it, but Jonathan knows I believe.
> 
> 
> >>> https://bugs.openjdk.java.net/browse/JDK-8089514
> >>>
> >>> tbd_major ... since nearly 7 years :(( actually, it took 4 years to
> >>> get the necessity accepted, then another 2 years playing with
> >>> incomplete suggested fixes and then ...
> >>>
> >>> It's a complex problem, requires
> >>>
> >>> a) additional commit/cancel api on the virtual controls to allow
> >>> collaborators to cleanly terminate ongoing edits - this part has still
> >>> been debated
> >>> b) a major cleanup of cell implementations - this part was under way
> >>> (and evolving into the good direction) until Jonathan left
> >>>
> >>>
> >>> CU, Jeanette
> >>>
>  On 19-6-2018 20:53, Ty Young wrote:
> > On 06/19/2018 10:51 AM, omnip...@gmail.com wrote:
> >
> >> A minor issue in the Table component existed in previous versions of
> >>> JavaFX
> >> when editing in a cell was turned on. Only if the Return key was
> >> pressed was
> >> the data entered into the backing bean. Leaving the cell with Tab or
> >> by
> >> mouse did not register the change. I thought just when a cell looses
> >>> focus
> >> it should trigger updating the bean. I have not looked at the recent
> >>> builds
> >> but I thought I'd ask if it has come up on anyone's radar. I
> >> noticed it when
> >> I moved from teaching Swing to FX.
> >>
> >>
> >> Ken Fogel
> >>
> >>
> >>
> > IIRC, this isn't specific to Table. A spinner with editing enabled
> > also does this and it breaks events(onKeyTyped does nothing).
>
>


Re: Table Input

2018-06-20 Thread Daniel Peintner
Hi,

I believe the last time I looked at the TableView2 contribution at
ControlsFX (which can be used as a TableView replacement), commit on focus
lost was implemented/supported.

-- Daniel


Jonathan Giles  schrieb am Mi., 20. Juni 2018,
10:28:

> Yup,
>
> A great regret. I wish it were supported, but it isn't due to historical
> legacy. There are some small ways you can make some progress, e.g. add
> focus listeners on the editor node, but they are half solutions at best.
>
> -- Jonathan
> (Tapped on a touch device)
>
> On Wed, 20 Jun 2018, 10:25 AM ,  wrote:
>
> >
> > Zitat von Tom Eugelink :
> >
> > > This is a well known and already deeply discussed issue. I'm still
> > > not sure where we are with it, but Jonathan knows I believe.
> > >
> > >
> >
> > https://bugs.openjdk.java.net/browse/JDK-8089514
> >
> > tbd_major ... since nearly 7 years :(( actually, it took 4 years to
> > get the necessity accepted, then another 2 years playing with
> > incomplete suggested fixes and then ...
> >
> > It's a complex problem, requires
> >
> > a) additional commit/cancel api on the virtual controls to allow
> > collaborators to cleanly terminate ongoing edits - this part has still
> > been debated
> > b) a major cleanup of cell implementations - this part was under way
> > (and evolving into the good direction) until Jonathan left
> >
> >
> > CU, Jeanette
> >
> > > On 19-6-2018 20:53, Ty Young wrote:
> > >> On 06/19/2018 10:51 AM, omnip...@gmail.com wrote:
> > >>
> > >>> A minor issue in the Table component existed in previous versions of
> > JavaFX
> > >>> when editing in a cell was turned on. Only if the Return key was
> > >>> pressed was
> > >>> the data entered into the backing bean. Leaving the cell with Tab or
> by
> > >>> mouse did not register the change. I thought just when a cell looses
> > focus
> > >>> it should trigger updating the bean. I have not looked at the recent
> > builds
> > >>> but I thought I'd ask if it has come up on anyone's radar. I
> > >>> noticed it when
> > >>> I moved from teaching Swing to FX.
> > >>>
> > >>>
> > >>> Ken Fogel
> > >>>
> > >>>
> > >>>
> > >>
> > >> IIRC, this isn't specific to Table. A spinner with editing enabled
> > >> also does this and it breaks events(onKeyTyped does nothing).
> >
> >
> >
> >
>


Re: Table Input

2018-06-20 Thread Rony G. Flatscher


On 20.06.2018 15:33, Daniel Peintner wrote:
> I believe the last time I looked at the TableView2 contribution at
> ControlsFX (which can be used as a TableView replacement), commit on focus
> lost was implemented/supported.
Do you have a link?

 seems to not have it.

---rony

> Jonathan Giles  schrieb am Mi., 20. Juni 2018,
> 10:28:
>
>> Yup,
>>
>> A great regret. I wish it were supported, but it isn't due to historical
>> legacy. There are some small ways you can make some progress, e.g. add
>> focus listeners on the editor node, but they are half solutions at best.
>>
>> -- Jonathan
>> (Tapped on a touch device)
>>
>> On Wed, 20 Jun 2018, 10:25 AM ,  wrote:
>>
>>> Zitat von Tom Eugelink :
>>>
 This is a well known and already deeply discussed issue. I'm still
 not sure where we are with it, but Jonathan knows I believe.


>>> https://bugs.openjdk.java.net/browse/JDK-8089514
>>>
>>> tbd_major ... since nearly 7 years :(( actually, it took 4 years to
>>> get the necessity accepted, then another 2 years playing with
>>> incomplete suggested fixes and then ...
>>>
>>> It's a complex problem, requires
>>>
>>> a) additional commit/cancel api on the virtual controls to allow
>>> collaborators to cleanly terminate ongoing edits - this part has still
>>> been debated
>>> b) a major cleanup of cell implementations - this part was under way
>>> (and evolving into the good direction) until Jonathan left
>>>
>>>
>>> CU, Jeanette
>>>
 On 19-6-2018 20:53, Ty Young wrote:
> On 06/19/2018 10:51 AM, omnip...@gmail.com wrote:
>
>> A minor issue in the Table component existed in previous versions of
>>> JavaFX
>> when editing in a cell was turned on. Only if the Return key was
>> pressed was
>> the data entered into the backing bean. Leaving the cell with Tab or
>> by
>> mouse did not register the change. I thought just when a cell looses
>>> focus
>> it should trigger updating the bean. I have not looked at the recent
>>> builds
>> but I thought I'd ask if it has come up on anyone's radar. I
>> noticed it when
>> I moved from teaching Swing to FX.
>>
>>
>> Ken Fogel
>>
>>
>>
> IIRC, this isn't specific to Table. A spinner with editing enabled
> also does this and it breaks events(onKeyTyped does nothing).