Re: request to backport JDK-8193445 to JavaFX 11

[Kevin Rushforth]

+1

On 12/6/2019 1:05 PM, Johan Vos wrote:

Hi Kevin,

I request permission to backport the fix for
https://bugs.openjdk.java.net/browse/JDK-8193445 to the 11-dev repository (
hg.openjdk.java.net/openjfx/11-dev/rt)

The patch applies clean to the 11-dev repository.

- Johan

request to backport JDK-8193445 to JavaFX 11

[Johan Vos]

Hi Kevin,

I request permission to backport the fix for
https://bugs.openjdk.java.net/browse/JDK-8193445 to the 11-dev repository (
hg.openjdk.java.net/openjfx/11-dev/rt)

The patch applies clean to the 11-dev repository.

- Johan

Re: [Integrated] RFR: 8221334: TableViewSkin: must initialize flow's cellCount in constructor

[Ajit Ghaisas]

Changeset: 07af89a9
Author:Jeanette Winzenburg 
Committer: Ajit Ghaisas 
Date:  2019-12-06 11:25:18 +
URL:   https://git.openjdk.java.net/jfx/commit/07af89a9

8221334: TableViewSkin: must initialize flow's cellCount in constructor

Reviewed-by: aghaisas

! 
modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableViewSkin.java
+ 
modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/ConcreteVirtualContainerTest.java

Re: [Rev 01] RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

[Ajit Ghaisas]

On Fri, 6 Dec 2019 09:42:05 GMT, Jeanette Winzenburg  
wrote:

>> fix for https://bugs.openjdk.java.net/browse/JDK-8220722
>> 
>> - replaces the manually registered listener with registerChangeListener(...)
>> - added test that's failing before and passing after the fix (plus a sanity 
>> test that the skin still is listening to changes)
> 
> The pull request has been updated with a new target base due to a merge or a 
> rebase.



-

Marked as reviewed by aghaisas (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/59