On Thu, 30 Jan 2020 23:07:53 GMT, Kevin Rushforth wrote:
> This is a fix for
> [JDK-8231513](https://bugs.openjdk.java.net/browse/JDK-8231513) to disable
> the use of `CGEventTap` when running on macOS 10.15 or later.
>
> The effect of this bug is that a scary dialog is shown for all users the
On Thu, 30 Jan 2020 08:15:39 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> With my basic testing, the change looks good, scaled up and scaled down
> snapshots seem correct visually.
>
> After this change the tiled snapshot will be limited by dime
On Fri, 31 Jan 2020 11:16:22 GMT, Frederic Thevenet
wrote:
>> With my basic testing, the change looks good, scaled up and scaled down
>> snapshots seem correct visually.
>>
>> After this change the tiled snapshot will be limited by dimensions of the
>> `WritableImage`.
>> We can not create a
On Fri, 31 Jan 2020 13:01:51 GMT, Kevin Rushforth wrote:
>> Since @kevinrushforth and @arapte have completed their review, is this ready
>> to integrate?
>> I'm a little confused by the fact this has both `rfr` and `ready` labels
>> attached; is this an expected behaviour?
>
> Yes, this is rea
On Fri, 24 Jan 2020 17:08:42 GMT, Phil Race wrote:
> … the available font data.
Looks good.
-
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.java.net/jfx/pull/95
On Fri, 31 Jan 2020 09:17:59 GMT, Johan Vos wrote:
>> This is a fix for
>> [JDK-8231513](https://bugs.openjdk.java.net/browse/JDK-8231513) to disable
>> the use of `CGEventTap` when running on macOS 10.15 or later.
>>
>> The effect of this bug is that a scary dialog is shown for all users the
On Fri, 24 Jan 2020 21:05:49 GMT, Phil Race wrote:
> Check if the glyph will fit before trying to cache it.
Looks good.
-
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.java.net/jfx/pull/96
How would one go about creating a testcase that needs a jar-file either on the
class- or module path?
Are there any test units that would demonstrate how to do it? If not, what
approach would you
suggest (and if so, are there any samples already somewhere to study)?
---
Background: for creatin
Take a look at the JarLauncherTest in the tests/system dir. There is
some (ugly) build logic in build.gradle to support it.
-- Kevin
On 1/31/2020 7:28 AM, Rony G. Flatscher wrote:
How would one go about creating a testcase that needs a jar-file either on the
class- or module path?
Are there
And if you need a modular jar, you might look at ModuleLauncherTest instead.
-- Kevin
On 1/31/2020 7:35 AM, Kevin Rushforth wrote:
Take a look at the JarLauncherTest in the tests/system dir. There is
some (ugly) build logic in build.gradle to support it.
-- Kevin
On 1/31/2020 7:28 AM, Rony
Changeset: 1823f6ec
Author:Frederic Thevenet
Committer: Kevin Rushforth
Date: 2020-01-31 14:11:47 +
URL: https://git.openjdk.java.net/jfx/commit/1823f6ec
8088198: Exception thrown from snapshot if dimensions are larger than max
texture size
Reviewed-by: arapte, kcr
! module
> This PR defines a pre-processor in the phong frag files to avoid inline
> declaration of #extension when several frags are combined that leads to the
> error:
>
> syntax error: #extension must always be before any non-preprocessor tokens
The pull request has been updated with 1 additional com
On Fri, 31 Jan 2020 00:51:22 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/diffuse_color.frag
> line 32:
>
>> 31: #extension GL_OES_standard_derivatives : enable
>> 32: #define EX
Changeset: 1823f6ec
Author:Frederic Thevenet
Committer: Kevin Rushforth
Date: 2020-01-31 14:11:47 +
URL: https://git.openjdk.java.net/jfx/commit/1823f6ec
8088198: Exception thrown from snapshot if dimensions are larger than max
texture size
Reviewed-by: arapte, kcr
! module
> [8236858](https://bugs.openjdk.java.net/browse/JDK-8236858) (Animations do
> not play backwards after being paused) has been split to deal with
> [embedded](https://bugs.openjdk.java.net/browse/JDK-8237974) and [not
> embedded](https://bugs.openjdk.java.net/browse/JDK-8237975) animations. This
On Fri, 31 Jan 2020 00:31:17 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> The fix looks fine, and all my testing looks good, too. I don't have a good
> recommendation for the test...I'd go with whatever is easiest for jfx14 and
> address it mor
Changeset: d05e8fc4
Author:Phil Race
Date: 2020-01-31 18:21:51 +
URL: https://git.openjdk.java.net/jfx/commit/d05e8fc4
8237833: Check glyph size before adding to glyph texture cache
Reviewed-by: kcr
! modules/javafx.graphics/src/main/java/com/sun/prism/impl/GlyphCache.java
Changeset: 95bf2c00
Author:Phil Race
Date: 2020-01-31 18:22:52 +
URL: https://git.openjdk.java.net/jfx/commit/95bf2c00
8237782: Only read advances up to the minimum of the numHorMetrics or the
available font data.
Reviewed-by: kcr
! modules/javafx.graphics/src/main/java/com/
On Fri, 31 Jan 2020 18:42:06 GMT, Nir Lisker wrote:
>> [8236858](https://bugs.openjdk.java.net/browse/JDK-8236858) (Animations do
>> not play backwards after being paused) has been split to deal with
>> [embedded](https://bugs.openjdk.java.net/browse/JDK-8237974) and [not
>> embedded](https://
On Fri, 31 Jan 2020 00:44:40 GMT, Phil Race wrote:
>> The pull request has been updated with 1 additional commit.
>
> Looks OK to me.
Pushed a fix to address the review comments.
@rwestberg for some reason the above commit didn't send an RFR reply to
openjfx-dev nor did it produce a new webre
> This is a fix for
> [JDK-8231513](https://bugs.openjdk.java.net/browse/JDK-8231513) to disable
> the use of `CGEventTap` when running on macOS 10.15 or later.
>
> The effect of this bug is that a scary dialog is shown for all users the
> first time they run a JavaFX application and move the m
On Fri, 31 Jan 2020 23:49:21 GMT, Jose Pereda wrote:
>> This PR defines a pre-processor in the phong frag files to avoid inline
>> declaration of #extension when several frags are combined that leads to the
>> error:
>>
>> syntax error: #extension must always be before any non-preprocessor tok
On Fri, 31 Jan 2020 18:41:57 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> Looks good.
@arapte can you be the second reviewer for this?
-
PR: https://git.openjdk.java.net/jfx/pull/98
23 matches
Mail list logo
