Re: [Rev 02] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
On Fri, 20 Mar 2020 11:28:46 GMT, Ajit Ghaisas wrote: >> Rony G. Flatscher has updated the pull request incrementally with one >> additional commit since the last revision: >> >> corrected wrong test string > > tests/system/src/testscriptapp1/java/mymod/myapp1/Util.java line 2: > >> 1: /* >> 2: * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights >> reserved. >> 3: * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > > Please remove "2017, " Since this file was copied verbatim from one of the other test apps, the initial `2017,` is correct. > tests/system/src/testscriptapp1/java/mymod/myapp1/Constants.java line 2: > >> 1: /* >> 2: * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights >> reserved. >> 3: * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > > Please remove "2017, " Same as above. The `2017,` is correct. - PR: https://git.openjdk.java.net/jfx/pull/122
Re: [Rev 02] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
On Thu, 27 Feb 2020 15:56:25 GMT, Rony G. Flatscher wrote: >> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV > > Rony G. Flatscher has updated the pull request incrementally with one > additional commit since the last revision: > > corrected wrong test string tests/system/src/testscriptapp1/java/mymod/myapp1/Util.java line 2: > 1: /* > 2: * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights > reserved. > 3: * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. Please remove "2017, " tests/system/src/testscriptapp1/java/mymod/myapp1/Constants.java line 2: > 1: /* > 2: * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights > reserved. > 3: * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. Please remove "2017, " - PR: https://git.openjdk.java.net/jfx/pull/122
Re: RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
On Fri, 13 Mar 2020 15:15:39 GMT, Kevin Rushforth wrote: >> Is there anything I can do to keep the ball rolling ? > > I just need time to do final testing of this, along with the review of the > updated test. > > @aghaisas will also review. The changes look good to me. I verified that the test fails without fix and passes with it. - PR: https://git.openjdk.java.net/jfx/pull/122
JavaFX Swipe Events Glitch On Mobile
Swipe Events like swipeup and swipedown don't get registered and their related set methods don't get called. OnTouch works rarely. JavaFX Version : 14 Gluon Client Plugin : 0.0.18 Regards, Debayan
