Re: [Rev 06] RFR: 8236259: MemoryLeak in ProgressIndicator

2020-05-03 Thread Florian Kirmaier
On Fri, 1 May 2020 15:05:26 GMT, Jesper Skov wrote: >> @FlorianKirmaier >> Please integrate this PR by issuing `/integrate` command in a new comment. >> After that one of us can sponsor it. > > @FlorianKirmaier did you want to persue a common shared in-tree GC testing > facility? > > Otherwi

RFR: 8244297 memory leak test utility

2020-05-03 Thread Florian Kirmaier
Hi everyone, as discussed in my older PR, I want to add some utility to test for memory leaks. Check out my PR for more details: https://github.com/openjdk/jfx/pull/204 Greetings Florian Kirmaier

RFR: 8244297: memory leak test utility

2020-05-03 Thread Florian Kirmaier
It's based on the discussion of my previous PR: https://github.com/openjdk/jfx/pull/71 I Added test utility class copied from JMemoryBuddy and used it to simplify 4 of the existing unit tests. It's a direct copy of my project [JMemoryBuddy](https://github.com/Sandec/JMemoryBuddy) without any c

Re: RFR: 8241999: ChoiceBox: incorrect toggle selected for uncontained

2020-05-03 Thread Ajit Ghaisas
On Tue, 28 Apr 2020 20:44:01 GMT, Kevin Rushforth wrote: >> The issue is that the toggles is not reliably unselected if an uncontained >> value is set. >> >> The root is ChoiceBoxSelectionModel which doesn't update the index on >> selecting an uncontained item, in particular it >> fails to kee

Re: RFR: 8241999: ChoiceBox: incorrect toggle selected for uncontained

2020-05-03 Thread Ajit Ghaisas
On Tue, 28 Apr 2020 15:36:53 GMT, Jeanette Winzenburg wrote: > The issue is that the toggles is not reliably unselected if an uncontained > value is set. > > The root is ChoiceBoxSelectionModel which doesn't update the index on > selecting an uncontained item, in particular it > fails to keep