Re: [Rev 01] RFR: 8247163: JFXPanel throws exception on click when no Scene is set

> Fixing exception when clicking on JFXPanel when no Scene is set. > > quick test: `./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests: test > --tests *javafx.embed.swing.JFXPan* --info` > > It's a regression from my previous PR: https://github.com/openjdk/jfx/pull/25 Florian Kirmaier has

Re: [Rev 01] RFR: 8247163: JFXPanel throws exception on click when no Scene is set

On Thu, 11 Jun 2020 23:37:40 GMT, Kevin Rushforth wrote: >> The fix looks correct to me (I haven't tested it yet). I left a minor >> comment inline. > > The fix and test both look good. Approved pending the minor format change (no > need for a second reviewer). Great, I've added the requested

Re: [Rev 01] RFR: 8247163: JFXPanel throws exception on click when no Scene is set

On Thu, 11 Jun 2020 00:32:34 GMT, Kevin Rushforth wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8247163: >> Added space based on code review > > modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPane

Re: [Rev 04] RFR: 8208169: can not print selected pages of web page

> Print function of WebEngine.java ignores page range setting and prints given > number of pages starting from first page, > which is the root cause of this issue. To fix it, put check for page ranges > and if it available, use it for printing > pages otherwise print all pages as usual. Bhawesh

Re: [Rev 05] RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

> This PR fixes JDK-8176270 by clamping the end index of the selected text to > the length of the text. Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last revision: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes

Re: [Rev 03] RFR: 8244418: MenuBar: IOOB exception on requestFocus on empty bar

On Mon, 15 Jun 2020 11:50:41 GMT, Ajit Ghaisas wrote: >> Issue : >> https://bugs.openjdk.java.net/browse/JDK-8244418 >> >> Root Cause : >> Incorrect assumption about menu list size. >> >> Fix : >> Added check for empty menu list before trying to access it. >> >> Test : >> Added a unit test tha

Re: RFR: 8246745: ListCell/Skin: misbehavior on switching skin

On Tue, 16 Jun 2020 05:50:43 GMT, Ambarish Rapte wrote: >> hmm, do you mean a list with height of one cell only? >> >> My experiment (having counters per instance and per computeXXHeight), logs 1 >> (or 2) for computePref with fixed size and >> 5 (1 each for min/max and 3 for pref) without fixe

Re: [Integrated] RFR: 8244418: MenuBar: IOOB exception on requestFocus on empty bar

On Fri, 8 May 2020 12:21:48 GMT, Ajit Ghaisas wrote: > Issue : > https://bugs.openjdk.java.net/browse/JDK-8244418 > > Root Cause : > Incorrect assumption about menu list size. > > Fix : > Added check for empty menu list before trying to access it. > > Test : > Added a unit test that fails befo

Re: [Rev 04] RFR: 8208169: can not print selected pages of web page

On Tue, 16 Jun 2020 07:59:02 GMT, Bhawesh Choudhary wrote: >> Print function of WebEngine.java ignores page range setting and prints given >> number of pages starting from first page, >> which is the root cause of this issue. To fix it, put check for page ranges >> and if it available, use it

Re: Test style questions

1. It's a judgment call. I tend to like fairly fine-grained tests as long as they are (at least mostly) independent. If the test is "do A", "verify state", "do B", "verify state" and B is something that you need to do after A, then having them in the same test is better. 2. It depends. If the

Re: RFR: 8247360: Add missing license file for Microsoft DirectShow Samples

On Tue, 16 Jun 2020 22:25:48 GMT, Kevin Rushforth wrote: > This adds a missing third-party license file for the Microsoft DirectShow > Samples. @sashamatveev can you review this? - PR: https://git.openjdk.java.net/jfx/pull/252

RFR: 8247360: Add missing license file for Microsoft DirectShow Samples

This adds a missing third-party license file for the Microsoft DirectShow Samples. - Commit messages: - 8247360: Add missing license file for Microsoft DirectShow Samples Changes: https://git.openjdk.java.net/jfx/pull/252/files Webrev: https://webrevs.openjdk.java.net/jfx/252/webr

Re: RFR: 8247360: Add missing license file for Microsoft DirectShow Samples

On Tue, 16 Jun 2020 22:25:48 GMT, Kevin Rushforth wrote: > This adds a missing third-party license file for the Microsoft DirectShow > Samples. Marked as reviewed by almatvee (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/252

Re: [Integrated] RFR: 8247360: Add missing license file for Microsoft DirectShow Samples

On Tue, 16 Jun 2020 22:25:48 GMT, Kevin Rushforth wrote: > This adds a missing third-party license file for the Microsoft DirectShow > Samples. This pull request has now been integrated. Changeset: 54e2507f Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx/commit/54e2507f

11-dev backport request: JDK-8247360: Add missing license file for Microsoft DirectShow Samples

Hi Johan, I request approval to backport the following to 11-dev for 11.0.8: JDK-8247360 [1] : Add missing license file for Microsoft DirectShow Samples -- Kevin [1] https://bugs.openjdk.java.net/browse/JDK-8247360

Re: Test style questions

Thanks for the guidance. Since my additional tests happen to test against a regression that was actually happening I'll keep them in my PR. If the reviewer finds them superfluous I can still remove them. Am Di., 16. Juni 2020 um 16:17 Uhr schrieb Kevin Rushforth < kevin.rushfo...@oracle.com>: >