Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus [v5]

2020-06-25 Thread Abhinay Agarwal
> In Android, TextInputControls (TextField and TextArea) are responsible for > showing and hiding software keyboard. > Currently, a focus listener is attached to these controls and is used to > toggle the visibility of keyboard. This > condition fails in cases where the control already has focus

Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus [v6]

2020-06-25 Thread Abhinay Agarwal
> In Android, TextInputControls (TextField and TextArea) are responsible for > showing and hiding software keyboard. > Currently, a focus listener is attached to these controls and is used to > toggle the visibility of keyboard. This > condition fails in cases where the control already has focus

Re: RFR: 8193800: TreeTableView selection changes on sorting [v6]

2020-06-25 Thread Kevin Rushforth
On Wed, 24 Jun 2020 11:02:53 GMT, Ambarish Rapte wrote: >> Issue: >> In TreeTableView, in case of Multiple selection mode, if nested items are >> selected, then TreeTableView does not >> retain/update the selection correctly when the tree items are >> permuted(either by `sort()` or by reorderin

Re: RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts [v4]

2020-06-25 Thread Kevin Rushforth
On Fri, 19 Jun 2020 16:04:16 GMT, Rony G. Flatscher wrote: >> This PR adds a "compile" process instruction to FXML files with the optional >> PI data "true" (default) and "false". The >> PI data is turned into a boolean value using "Boolean.parseBoolean(String)". >> This makes it possible to in

RFR: 8247947: Build DirectShow Samples (Base Classes) from source checked into repo

2020-06-25 Thread Alexander Matveev
- Added DirectShow baseclasses to repository. - Dependency on Windows SDK 7.1 DirectShow baseclasses was removed. - Commit messages: - 8247947: Fixed files permissions - 8247947: Build DirectShow Samples (Base Classes) from source checked into repo Changes: https://git.openjdk.jav

RFR: 8201567: QuantumRenderer modifies buffer in use by JavaFX Application Thread

2020-06-25 Thread John Neffenger
Fixes [JDK-8201567](https://bugs.openjdk.java.net/browse/JDK-8201567). - Commit messages: - 8201567: QuantumRenderer modifies buffer in use by JavaFX Application Thread Changes: https://git.openjdk.java.net/jfx/pull/255/files Webrev: https://webrevs.openjdk.java.net/jfx/255/webrev.

RFR: 8248381: Create a daemon thread for MonocleTimer

2020-06-25 Thread John Neffenger
Fixes [JDK-8248381](https://bugs.openjdk.java.net/browse/JDK-8248381). - Commit messages: - 8248381: Create a daemon thread for MonocleTimer Changes: https://git.openjdk.java.net/jfx/pull/256/files Webrev: https://webrevs.openjdk.java.net/jfx/256/webrev.00 Issue: https://bugs.ope

Re: RFR: 8201567: QuantumRenderer modifies buffer in use by JavaFX Application Thread

2020-06-25 Thread John Neffenger
On Fri, 26 Jun 2020 03:47:55 GMT, John Neffenger wrote: > Fixes [JDK-8201567](https://bugs.openjdk.java.net/browse/JDK-8201567). The method `QueuedPixelSource.usesSameBuffer` calls `Pixels.getPixels` on the QuantumRenderer thread while trying to find a buffer that's not in use, yet in doing so