Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v15]

2020-07-01 Thread Frederic Thevenet
> Issue JDK-8088198, where an exception would be thrown when trying to capture > a snapshot whose final dimensions would be > larger than the running platform's maximum supported texture size, was > addressed in openjfx14. The fix, based around > the idea of capturing as many tiles of the

FINAL REMINDER: JavaFX 15 RDP1 starts tomorrow [was: Proposed schedule for JavaFX 15]

2020-07-01 Thread Kevin Rushforth
As a reminder, RDP1 starts tomorrow. I will fork the 'jfx15' branch at 16:00 UTC. -- Kevin On 6/18/2020 9:38 AM, Kevin Rushforth wrote: As a reminder, RDP1 for JavaFX 15 starts on July 2, 2020 at 16:00 UTC (09:00 Pacific time), which is two weeks from today. Please allow sufficient time

Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v15]

2020-07-01 Thread Kevin Rushforth
On Wed, 1 Jul 2020 09:44:05 GMT, Frederic Thevenet wrote: >> Issue JDK-8088198, where an exception would be thrown when trying to capture >> a snapshot whose final dimensions would be >> larger than the running platform's maximum supported texture size, was >> addressed in openjfx14. The fix,

Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened

2020-07-01 Thread Johan Vos
On Mon, 29 Jun 2020 18:49:33 GMT, John Neffenger wrote: >> The rationale makes sense (open/open/close) instead of (open/close/open) > > Based on my notes below, I believe this change is safe for any Linux input > device driver because the driver shouldn't > receive the intermediate *open* and

Re: RFR: 8248317: Change JavaFX release version to 16

2020-07-01 Thread Johan Vos
On Tue, 30 Jun 2020 15:30:31 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 16. I will integrate this immediately > after forking the `jfx15` stabilization > branch. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/260

Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v15]

2020-07-01 Thread Ambarish Rapte
On Wed, 1 Jul 2020 09:44:05 GMT, Frederic Thevenet wrote: >> Issue JDK-8088198, where an exception would be thrown when trying to capture >> a snapshot whose final dimensions would be >> larger than the running platform's maximum supported texture size, was >> addressed in openjfx14. The fix,

Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v14]

2020-07-01 Thread Kevin Rushforth
On Wed, 1 Jul 2020 09:17:16 GMT, Frederic Thevenet wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolkit.java >> line 1638: >> >>> 1637: renderWholeImage(x, y, w, h, rf, pImage); >>> 1638: } >>> 1639:

Re: RFR: 8201570: Get two bytes for the Linux input event type, not four

2020-07-01 Thread Johan Vos
On Mon, 29 Jun 2020 11:31:41 GMT, Johan Vos wrote: >> Fixes [JDK-8201570](https://bugs.openjdk.java.net/browse/JDK-8201570). > > This fixes a bug that currently didn't cause any harm > (https://bugs.openjdk.java.net/browse/JDK-8201570?focusedCommentId=14172176) > , but it's better to fix it

Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v16]

2020-07-01 Thread Frederic Thevenet
> Issue JDK-8088198, where an exception would be thrown when trying to capture > a snapshot whose final dimensions would be > larger than the running platform's maximum supported texture size, was > addressed in openjfx14. The fix, based around > the idea of capturing as many tiles of the

Integrated: 8244212: Optionally download media and webkit libraries from latest openjfx EA build

2020-07-01 Thread Jesper Skov
On Thu, 30 Apr 2020 18:56:40 GMT, Jesper Skov wrote: > I have tested on Linux (Fedora 31) only. > It works as intended (with one test failure due to 15-ea+4 being too old now). > > UPDATE_STUB_CACHE suggests there is some magic available to help manage the > stub cache. > But as I could not

Re: RFR: 8244212: Optionally download media and webkit libraries from latest openjfx EA build

2020-07-01 Thread Nir Lisker
On Mon, 29 Jun 2020 11:23:01 GMT, Johan Vos wrote: >> I have tested on Linux (Fedora 31) only. >> It works as intended (with one test failure due to 15-ea+4 being too old >> now). >> >> UPDATE_STUB_CACHE suggests there is some magic available to help manage the >> stub cache. >> But as I

Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v16]

2020-07-01 Thread Kevin Rushforth
On Wed, 1 Jul 2020 16:20:53 GMT, Frederic Thevenet wrote: >> Issue JDK-8088198, where an exception would be thrown when trying to capture >> a snapshot whose final dimensions would be >> larger than the running platform's maximum supported texture size, was >> addressed in openjfx14. The fix,

Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v15]

2020-07-01 Thread Kevin Rushforth
On Wed, 1 Jul 2020 14:29:55 GMT, Frederic Thevenet wrote: > Someone will still need to run the tests on macOS, I'm afraid. I'll do a quick sanity test on all three platforms. - PR: https://git.openjdk.java.net/jfx/pull/112

RFR: 8247963: Update SQLite to version 3.32.3

2020-07-01 Thread Arun Joseph
We currently use SQLite version 3.31.1. We should update to the latest stable release version 3.32.3 released on 2020-06-18. https://www.sqlite.org/index.html - Commit messages: - 8247963: Update SQLite to version 3.32.3 Changes: https://git.openjdk.java.net/jfx/pull/261/files

Integrated: 8238954: Improve performance of tiled snapshot rendering

2020-07-01 Thread Frederic Thevenet
On Wed, 12 Feb 2020 13:21:03 GMT, Frederic Thevenet wrote: > Issue JDK-8088198, where an exception would be thrown when trying to capture > a snapshot whose final dimensions would be > larger than the running platform's maximum supported texture size, was > addressed in openjfx14. The fix,

Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v15]

2020-07-01 Thread Kevin Rushforth
On Wed, 1 Jul 2020 14:29:55 GMT, Frederic Thevenet wrote: >> Marked as reviewed by arapte (Reviewer). > > I have read Ambarish's code more closely and I am now convinced it is indeed > easier to understand; beyond the change > from "while" to "for" loops, it introduces an extra set of

Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v16]

2020-07-01 Thread Ambarish Rapte
On Wed, 1 Jul 2020 17:54:29 GMT, Frederic Thevenet wrote: >> Issue JDK-8088198, where an exception would be thrown when trying to capture >> a snapshot whose final dimensions would be >> larger than the running platform's maximum supported texture size, was >> addressed in openjfx14. The fix,

Re: RFR: 8244212: Optionally download media and webkit libraries from latest openjfx EA build

2020-07-01 Thread Johan Vos
On Wed, 1 Jul 2020 17:58:10 GMT, Nir Lisker wrote: >> Marked as reviewed by jvos (Reviewer). > > Do the build instructions need to be updated? The build instruction can indeed refer to WEBKIT-MEDIA-STUBS.md now. - PR: https://git.openjdk.java.net/jfx/pull/202

Re: RFR: 8247963: Update SQLite to version 3.32.3

2020-07-01 Thread Kevin Rushforth
On Wed, 1 Jul 2020 17:14:30 GMT, Arun Joseph wrote: > We currently use SQLite version 3.31.1. We should update to the latest stable > release version 3.32.3 released on > 2020-06-18. https://www.sqlite.org/index.html Looks good. Tested on all three platforms. - Marked as reviewed

Re: MacOS Big Sur and OpenJFX on Arm Macs

2020-07-01 Thread Scott Palmer
JavaFX already runs on some Arm-based devices like the Raspberry Pi, so I expect an Arm-based port for new Macs won’t be that big of a job (relatively speaking) Hopefully by that time there will be a Metal-base rendering pipeline as well. The Metal-based pipeline for Swing seems to be coming

Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-07-01 Thread Nir Lisker
On Wed, 13 May 2020 23:50:37 GMT, Kevin Rushforth wrote: >>> We should make sure that we aren't seeing any significant performance drop >>> when rendering spheres (at a couple >>> different tessellation levels) or boxes. >> >> I missed this. Do you mean that the test should create a mesh of a

Re: RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException [v7]

2020-07-01 Thread Robert Lichtenberger
> This PR fixes JDK-8176270 by clamping the end index of the selected text to > the length of the text. Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last revision: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes

Re: RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException [v6]

2020-07-01 Thread Robert Lichtenberger
On Tue, 30 Jun 2020 23:05:40 GMT, Kevin Rushforth wrote: >> Robert Lichtenberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8176270: Adding ChangeListener to TextField.selectedTextProperty causes >> StringOutOfBoundsException >>

Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v15]

2020-07-01 Thread Frederic Thevenet
On Wed, 1 Jul 2020 13:42:12 GMT, Ambarish Rapte wrote: >> Frederic Thevenet has updated the pull request incrementally with one >> additional commit since the last revision: >> >> - Removed unused imports in Snapshot2Test >> - Fixed comments in QuantumToolkit >> - Only initialize RTT

MacOS Big Sur and OpenJFX on Arm Macs

2020-07-01 Thread Danny Gonzalez
Hi All, Not sure if this is the correct place to direct this conversation but here goes. With the imminent arrival of Arm Macs in late 2020 running MacOS Big Sur, what are the plans to ensure that OpenJFX and Java will run on this platform? Are there plans to get the Developer Transition Kit

Re: RFR: 8247963: Update SQLite to version 3.32.3

2020-07-01 Thread Kevin Rushforth
On Wed, 1 Jul 2020 17:14:30 GMT, Arun Joseph wrote: > We currently use SQLite version 3.31.1. We should update to the latest stable > release version 3.32.3 released on > 2020-06-18. https://www.sqlite.org/index.html @guruhb @bhaweshkc can one of you review this as well? - PR:

Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v14]

2020-07-01 Thread Frederic Thevenet
On Tue, 30 Jun 2020 21:22:14 GMT, Ambarish Rapte wrote: >> Frederic Thevenet has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Prevent attempt to render tiles with a 0 sized dimension. > >