On Fri, 14 Aug 2020 06:23:18 GMT, Tobias Diez
wrote:
>> Currently, loading a style sheet file using
>> `WebView.getEngine().setUserStyleSheetLocation(url)` fails if the url
>> start's with `jrt`, i.e. if the file is packaged in an application image
>> using jlink. This is fixed with this PR.
On Thu, 24 Oct 2019 16:42:14 GMT, Tobias Diez
wrote:
> Currently, loading a style sheet file using
> `WebView.getEngine().setUserStyleSheetLocation(url)` fails if the url
> start's with `jrt`, i.e. if the file is packaged in an application image
> using jlink. This is fixed with this PR.
On Thu, 13 Aug 2020 21:36:52 GMT, Kevin Rushforth wrote:
>> Tobias Diez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove whitespace
>
> modules/javafx.web/src/test/java/test/javafx/scene/web/MiscellaneousTest.java
> line 478:
>
> Currently, loading a style sheet file using
> `WebView.getEngine().setUserStyleSheetLocation(url)` fails if the url
> start's with `jrt`, i.e. if the file is packaged in an application image
> using jlink. This is fixed with this PR.
Tobias Diez has updated the pull request incrementally with
> Closed focused Stages are not collected with Monocle
>
> This commit adds a unit-test and a fix for collecting focused closed stages.
>
> ticket: https://bugs.openjdk.java.net/browse/JDK-8241840
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the
On Thu, 13 Aug 2020 19:31:57 GMT, Kevin Rushforth wrote:
>> They are called from the following static method:
>> @BeforeClass
>> public static void initFX() throws Exception {
>> initFXBase();
>> }
>
> No, these two are only used from `testClosedFocusedStageLeakBase`, which
On Thu, 13 Aug 2020 19:49:45 GMT, Kevin Rushforth wrote:
>> The fix looks good now. I'll file a follow-up issue for the potential leak
>> on the other platforms.
>>
>> My thinking is that if `focusedWindow` is only used in Monocle, we should
>> push the tracking down to the platform rather
>>
On Thu, 13 Aug 2020 19:26:47 GMT, Kevin Rushforth wrote:
>> tests/system/src/test/java/test/javafx/stage/FocusedWindowMonocleTest.java
>> line 56:
>>
>>> 55: }
>>> 56: }
>>
>> Minor: Add missing newline
>
> I meant that the file should end with a newline (it doesn't matter whether or
>
On Fri, 14 Aug 2020 10:09:22 GMT, Florian Kirmaier
wrote:
>> Closed focused Stages are not collected with Monocle
>>
>> This commit adds a unit-test and a fix for collecting focused closed stages.
>>
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8241840
>
> Florian Kirmaier has updated
On Fri, 14 Aug 2020 12:35:00 GMT, Kevin Rushforth wrote:
>> Tobias Diez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update MiscellaneousTest.java
>
> Given the simplicity of the fix, I think the minimal test is enough.
@arun-Joseph
On Fri, 14 Aug 2020 06:23:18 GMT, Tobias Diez
wrote:
>> Currently, loading a style sheet file using
>> `WebView.getEngine().setUserStyleSheetLocation(url)` fails if the url
>> start's with `jrt`, i.e. if the file is packaged in an application image
>> using jlink. This is fixed with this PR.
11 matches
Mail list logo
