TableView Future/Enhancements

2020-10-13 Thread Daniel Peintner
All, I would like to ask some questions (and provide feedback) w.r.t. the current TableView control in JavaFX. If this is not the *right* place to ask such questions please let me know and I apologize. The desire of a table (spreadsheet) control is to be editable and usable also with the keyboard

RFR: 8242621: TabPane: Memory leak when switching skin

2020-10-13 Thread Ambarish Rapte
`TabPaneSkin` installs some listeners that are not removed when `TabPaneSkin` is changed. The fix converts listeners to WeakListeners and also removes them on dispose. There is a NPE check change needed in `isHosrizontal()`. Without this check it causes NPE if pulse is in progress while TabPaneS

RFR: 8254040: [testbug] Need additional regressions tests for ObservableList removeAll / retainAll

2020-10-13 Thread Jeanette Winzenburg
issue is about missing regressions tests for [JDK-8093144](https://bugs.openjdk.java.net/browse/JDK-8093144) added tests for implementations of ObservableList that might be effected (FilteredList, selectedItems in ListView and friends) - see bug report for details. Happily, the tests are passing

Re: RFR: 8242621: TabPane: Memory leak when switching skin

2020-10-13 Thread Jeanette Winzenburg
On Tue, 13 Oct 2020 12:56:10 GMT, Ambarish Rapte wrote: > `TabPaneSkin` installs some listeners that are not removed when `TabPaneSkin` > is changed. > The fix converts listeners to WeakListeners and also removes them on dispose. > > There is a NPE check change needed in `isHosrizontal()`. With

Re: RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop

2020-10-13 Thread Oliver Schmidtmer
On Fri, 9 Oct 2020 23:17:27 GMT, Kevin Rushforth wrote: >> The full recreation of the pipeline is only done when D3DERR_DEVICEREMOVED >> is occurring. On other causes of why the >> device is not ready, only the factory reference in the painter is cleared. > >> The full recreation of the pipeline

Re: RFR: [WIP] 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop

2020-10-13 Thread Oliver Schmidtmer
On Tue, 13 Oct 2020 16:22:36 GMT, Oliver Schmidtmer wrote: >>> The full recreation of the pipeline is only done when D3DERR_DEVICEREMOVED >>> is occurring >> >> I see that now. That part is fine then. >> >> Another concern is that this would be the first time we have recreated a >> GraphicsP

Re: RFR: 8253935: [testbug] ComboBoxTest.testEditorKeyInputsWhenPopupIsShowing fails on Mac, Linux [v2]

2020-10-13 Thread Ambarish Rapte
> The test fails on Mac and Linux. > Cause of failure: > - Linux: Unlike Windows, on Linux CTRL + Arrow keys move the caret to > end/beginning of current word and not to > beginning/end of next word. > - Mac: On Mac correct keys to traverse through words is ALT + Arrow and not > CTRL + Arrow. A

Re: RFR: 8253935: [testbug] ComboBoxTest.testEditorKeyInputsWhenPopupIsShowing fails on Mac, Linux [v3]

2020-10-13 Thread Ambarish Rapte
> The test fails on Mac and Linux. > Cause of failure: > - Linux: Unlike Windows, on Linux CTRL + Arrow keys move the caret to > end/beginning of current word and not to > beginning/end of next word. > - Mac: On Mac correct keys to traverse through words is ALT + Arrow and not > CTRL + Arrow. A

Re: RFR: 8253935: [testbug] ComboBoxTest.testEditorKeyInputsWhenPopupIsShowing fails on Mac, Linux [v3]

2020-10-13 Thread Ambarish Rapte
On Mon, 12 Oct 2020 19:51:37 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> use getShourtcutKey() > > modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java > lin

Re: RFR: 8253935: [testbug] ComboBoxTest.testEditorKeyInputsWhenPopupIsShowing fails on Mac, Linux [v3]

2020-10-13 Thread Kevin Rushforth
On Tue, 13 Oct 2020 17:28:23 GMT, Ambarish Rapte wrote: >> The test fails on Mac and Linux. >> Cause of failure: >> - Linux: Unlike Windows, on Linux CTRL + Arrow keys move the caret to >> end/beginning of current word and not to >> beginning/end of next word. >> - Mac: On Mac correct keys to

Integrated: 8253935: [testbug] ComboBoxTest.testEditorKeyInputsWhenPopupIsShowing fails on Mac, Linux

2020-10-13 Thread Ambarish Rapte
On Mon, 12 Oct 2020 19:37:41 GMT, Ambarish Rapte wrote: > The test fails on Mac and Linux. > Cause of failure: > - Linux: Unlike Windows, on Linux CTRL + Arrow keys move the caret to > end/beginning of current word and not to > beginning/end of next word. > - Mac: On Mac correct keys to traver