Re: RFR: 8231372: JFXPanel fails to render if setScene called on Swing thread [v2]

2020-12-08 Thread Prasanta Sadhukhan
On Sat, 5 Dec 2020 13:42:21 GMT, Kevin Rushforth wrote: >> This fix was originally proposed by @mruzicka in PR #16 which was closed >> several months ago without being integrated. At the time we didn't have a >> test case that was failing. >> >> While evaluating a bug that I filed, >>

RFR: 8257758: Allow building of JavaFX native libs for Apple Silicon

2020-12-08 Thread Johan Vos
Fix for JDK-8257758 In case the -PtargetArch=arm64 option is supplied to the gradle build, the native components that are part of the JavaFX build will target this platform. - Commit messages: - Allow to build an arm64-macos build Changes:

Integrated: 8231372: JFXPanel fails to render if setScene called on Swing thread

2020-12-08 Thread Kevin Rushforth
On Fri, 4 Dec 2020 02:07:37 GMT, Kevin Rushforth wrote: > This fix was originally proposed by @mruzicka in PR #16 which was closed > several months ago without being integrated. At the time we didn't have a > test case that was failing. > > While evaluating a bug that I filed, >

RFR: 8257897: Fix webkit build for XCode 12

2020-12-08 Thread Arun Joseph
The WebKit build fails with recent Xcode 12. Bug: `getVTablePointer()` should return a const void* Fix: Use const void* and remove dependency on JavaVM.framework in Xcode Upstream fix: https://bugs.webkit.org/show_bug.cgi?id=207871 Test: Build webkit with the Xcode 12 compiler with and without

RFR: 8257719: JFXPanel scene fails to render correctly on HiDPI after fix for JDK-8199592

2020-12-08 Thread Jose Pereda
This PR fixes a regression introduced in [JDK-8199592](https://bugs.openjdk.java.net/browse/JDK-8199592), where scene initialization was moved after updating output scales. However, in case of embedded windows (used by `JFXPanel` or `FXCanvas`), the scene has to be initialized before. A test

RFR: 8256983: GitHub actions: specify the version of each platform OS and compiler

2020-12-08 Thread Kevin Rushforth
As described in the [JBS issue](https://bugs.openjdk.java.net/browse/JDK-8256983), we should specify the specific version of each OS and compiler rather than just using the defaults. This will help insulate us from changes to the defaults that can break the build, and has recently done so. On

Re: RFR: 8257758: Allow building of JavaFX native libs for Apple Silicon

2020-12-08 Thread Kevin Rushforth
On Tue, 8 Dec 2020 11:00:43 GMT, Johan Vos wrote: > Fix for JDK-8257758 > > In case the -PtargetArch=arm64 option is supplied to the gradle build, the > native components that are part of the JavaFX build will target this platform. I haven't tested it yet. I made a naming suggestion, but

Re: RFR: 8257719: JFXPanel scene fails to render correctly on HiDPI after fix for JDK-8199592

2020-12-08 Thread Kevin Rushforth
On Tue, 8 Dec 2020 16:29:52 GMT, Jose Pereda wrote: > This PR fixes a regression introduced in > [JDK-8199592](https://bugs.openjdk.java.net/browse/JDK-8199592), where scene > initialization was moved after updating output scales. However, in case of > embedded windows (used by `JFXPanel` or

Re: RFR: 8257719: JFXPanel scene fails to render correctly on HiDPI after fix for JDK-8199592 [v2]

2020-12-08 Thread Kevin Rushforth
On Tue, 8 Dec 2020 21:34:46 GMT, Jose Pereda wrote: >> This PR fixes a regression introduced in >> [JDK-8199592](https://bugs.openjdk.java.net/browse/JDK-8199592), where scene >> initialization was moved after updating output scales. However, in case of >> embedded windows (used by `JFXPanel`

Re: RFR: 8257897: Fix webkit build for XCode 12

2020-12-08 Thread Kevin Rushforth
On Tue, 8 Dec 2020 17:29:56 GMT, Arun Joseph wrote: > The WebKit build fails with recent Xcode 12. > > Bug: `getVTablePointer()` should return a const void* > > Fix: Use const void* and remove dependency on JavaVM.framework in Xcode > Upstream fix:

Re: RFR: 8257719: JFXPanel scene fails to render correctly on HiDPI after fix for JDK-8199592 [v2]

2020-12-08 Thread Jose Pereda
> This PR fixes a regression introduced in > [JDK-8199592](https://bugs.openjdk.java.net/browse/JDK-8199592), where scene > initialization was moved after updating output scales. However, in case of > embedded windows (used by `JFXPanel` or `FXCanvas`), the scene has to be > initialized

Integrated: 8257897: Fix webkit build for XCode 12

2020-12-08 Thread Arun Joseph
On Tue, 8 Dec 2020 17:29:56 GMT, Arun Joseph wrote: > The WebKit build fails with recent Xcode 12. > > Bug: `getVTablePointer()` should return a const void* > > Fix: Use const void* and remove dependency on JavaVM.framework in Xcode > Upstream fix: