RFR: 8260163: IrresponsiveScriptTest.testInfiniteLoopInScript unit test fails on Windows

2021-01-31 Thread Arun Joseph
Windows uses `WorkQueueGeneric` instead of `WorkQueueWin` from WebKit 610.2 onwards. In `WorkQueueWin`, `WorkQueue::dispatchAfter()` had a 20 ms `slopAdjustment` as the timer (called from `::SetTimer`) sometimes fire a few ms early. The same is not present in `WorkQueueGeneric` and needs to be

Re: RFR: 8252935: Add treeShowing listener only when needed [v4]

2021-01-31 Thread John Hendrikx
> This is a PoC for performance testing. > > It contains commented out code in PopupWindow and ProgressIndicatorSkin and > two tests are failing because of that. > > This code avoids registering two listeners (on Scene and on Window) for each > and every Node to support the aforementioned

Re: RFR: 8252935: Add treeShowing listener only when needed [v3]

2021-01-31 Thread John Hendrikx
On Thu, 28 Jan 2021 13:37:59 GMT, Kevin Rushforth wrote: >> John Hendrikx has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Add performance test >> - Use registerChangeListener in ProgressIndicatorSkin > > The updated fix using

Re: RFR: 8252935: Add treeShowing listener only when needed [v4]

2021-01-31 Thread John Hendrikx
On Fri, 22 Jan 2021 21:36:06 GMT, Kevin Rushforth wrote: >> John Hendrikx has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Add missing TreeShowingExpressionTest which also tests SubScene >> - Also dispose listeners on Window/Showing